[Freedreno] [PATCH v3 3/3] drm/msm/dp: check main link status before start aux read

2021-04-15 Thread Kuogee Hsieh
Maybe when the cable is disconnected the DP phy should be shutdown and some bit in the phy could effectively "cut off" the aux channel and then NAKs would start coming through here in the DP controller I/O register space. This patch have DP aux channel read/write to return NAK immediately if DP con

[Freedreno] [PATCH v3 2/3] drm/msm/dp: initialize audio_comp when audio starts

2021-04-15 Thread Kuogee Hsieh
Initialize audio_comp when audio starts and wait for audio_comp at dp_display_disable(). This will take care of both dongle unplugged and display off (suspend) cases. Changes in v2: -- add dp_display_signal_audio_start() Changes in v3: -- restore dp_display_handle_plugged_change() at dp_hpd_unplu

Re: [Freedreno] [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-04-15 15:02:40) > On 2021-04-15 13:06, Stephen Boyd wrote: > > > > Is it really necessary to have this patch at all? I think there are > > bigger problems with suspend/resume of the DP driver in relation to the > > kthread stopping. I hope that the aux channel w

Re: [Freedreno] [v1 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Document use-aux-backlight

2021-04-15 Thread Rob Herring
On Wed, Apr 14, 2021 at 10:09:49PM +0530, Rajeev Nandan wrote: > If the panel connected to the bridge supports backlight control > using DPCD registers on the DisplayPort aux channel, setting > "use-aux-backlight" property in the bridge node will enable the > registration of a DP aux backlight devi

Re: [Freedreno] [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-15 Thread khsieh
On 2021-04-15 13:06, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-04-15 10:37:29) On 2021-04-14 14:09, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-04-13 16:11:44) >> Make sure main link is in connection state before start aux >> read/write operation to avoid unnecessary long dela

Re: [Freedreno] [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-15 Thread Stephen Boyd
Quoting khs...@codeaurora.org (2021-04-15 10:37:29) > On 2021-04-14 14:09, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2021-04-13 16:11:44) > >> Make sure main link is in connection state before start aux > >> read/write operation to avoid unnecessary long delay due to > >> main link had been unp

Re: [Freedreno] [PATCH v2 2/3] drm/msm/dp: initialize audio_comp when audio starts

2021-04-15 Thread khsieh
On 2021-04-14 14:22, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-14 14:02:50) Initialize audio_comp when audio starts and wait for audio_comp at dp_display_disable(). This will take care of both dongle unplugged and display off (suspend) cases. Changes in v2: -- add dp_display_start_audio

Re: [Freedreno] [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-15 Thread khsieh
On 2021-04-14 14:09, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-13 16:11:44) Make sure main link is in connection state before start aux read/write operation to avoid unnecessary long delay due to main link had been unplugged. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_a

Re: [Freedreno] [PATCH] drm/msm/dsi: fix msm_dsi_phy_get_clk_provider return code

2021-04-15 Thread Dmitry Baryshkov
Hi On 12/04/2021 03:01, Dmitry Baryshkov wrote: msm_dsi_phy_get_clk_provider() always returns two provided clocks, so return 0 instead of returning incorrect -EINVAL error code. Fixes: 5d13459650b3 ("drm/msm/dsi: push provided clocks handling into a generic code") Signed-off-by: Dmitry Baryshk