Re: [Freedreno] [PATCH v4 2/3] drm/msm: add support to take dpu snapshot

2021-04-14 Thread Rob Clark
On Wed, Apr 14, 2021 at 5:16 PM Dmitry Baryshkov wrote: > > On 15/04/2021 02:11, Abhinav Kumar wrote: > > Add the msm_disp_snapshot module which adds supports to dump dpu > > registers and capture the drm atomic state which can be used in > > case of error conditions. > > > > changes in v4: > >

Re: [Freedreno] [PATCH v4 2/3] drm/msm: add support to take dpu snapshot

2021-04-14 Thread abhinavk
Hi Dmitry Thanks for the review. On 2021-04-14 17:16, Dmitry Baryshkov wrote: On 15/04/2021 02:11, Abhinav Kumar wrote: Add the msm_disp_snapshot module which adds supports to dump dpu registers and capture the drm atomic state which can be used in case of error conditions. changes in v4: -

Re: [Freedreno] [PATCH v4 2/3] drm/msm: add support to take dpu snapshot

2021-04-14 Thread Dmitry Baryshkov
On 15/04/2021 02:11, Abhinav Kumar wrote: Add the msm_disp_snapshot module which adds supports to dump dpu registers and capture the drm atomic state which can be used in case of error conditions. changes in v4: - rename dpu_dbg to msm_disp_snapshot and move it to msm/disp - start using a li

[Freedreno] [PATCH v4 3/3] drm/msm: add disp snapshot points across dpu driver

2021-04-14 Thread Abhinav Kumar
Add snapshot points across dpu driver to trigger dumps when critical errors are hit. changes in v4: - change the callers to use the new snapshot macro Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 18 +++--- drivers/gpu/drm/msm/disp/dpu1/dp

[Freedreno] [PATCH v4 0/3] Add devcoredump support for DPU

2021-04-14 Thread Abhinav Kumar
This series adds support to use devcoredump for DPU driver. It introduces the msm_disp_snapshot module which assists in the capturing of register dumps during error scenarios. When a display related error happens, the msm_disp_snapshot module captures all the relevant register dumps along with th

[Freedreno] [PATCH v4 2/3] drm/msm: add support to take dpu snapshot

2021-04-14 Thread Abhinav Kumar
Add the msm_disp_snapshot module which adds supports to dump dpu registers and capture the drm atomic state which can be used in case of error conditions. changes in v4: - rename dpu_dbg to msm_disp_snapshot and move it to msm/disp - start using a list of blocks to store the hardware block infor

[Freedreno] [PATCH v4 1/3] drm: allow drm_atomic_print_state() to accept any drm_printer

2021-04-14 Thread Abhinav Kumar
Currently drm_atomic_print_state() internally allocates and uses a drm_info printer. Allow it to accept any drm_printer type so that the API can be leveraged even for taking drm snapshot. Rename the drm_atomic_print_state() to drm_atomic_print_new_state() so that it reflects its functionality bett

Re: [Freedreno] [PATCH v2 2/3] drm/msm/dp: initialize audio_comp when audio starts

2021-04-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-14 14:02:50) > Initialize audio_comp when audio starts and wait for audio_comp at > dp_display_disable(). This will take care of both dongle unplugged > and display off (suspend) cases. > > Changes in v2: > -- add dp_display_start_audio() > > Signed-off-by: Kuogee Hs

Re: [Freedreno] [PATCH v2 1/3] drm/msm/dp: check sink_count before update is_connected status

2021-04-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-14 14:02:34) > Link status is different from display connected status in the case > of something like an Apple dongle where the type-c plug can be > connected, and therefore the link is connected, but no sink is > connected until an HDMI cable is plugged into the dongl

Re: [Freedreno] [PATCH v2 3/3] drm/msm/dp: check main link status before start aux read

2021-04-14 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-13 16:11:44) > Make sure main link is in connection state before start aux > read/write operation to avoid unnecessary long delay due to > main link had been unplugged. > > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/dp/dp_aux.c | 5 + > drivers/gp

[Freedreno] [PATCH v2 2/3] drm/msm/dp: initialize audio_comp when audio starts

2021-04-14 Thread Kuogee Hsieh
Initialize audio_comp when audio starts and wait for audio_comp at dp_display_disable(). This will take care of both dongle unplugged and display off (suspend) cases. Changes in v2: -- add dp_display_start_audio() Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_audio.c | 1 + drive

[Freedreno] [PATCH v2 1/3] drm/msm/dp: check sink_count before update is_connected status

2021-04-14 Thread Kuogee Hsieh
Link status is different from display connected status in the case of something like an Apple dongle where the type-c plug can be connected, and therefore the link is connected, but no sink is connected until an HDMI cable is plugged into the dongle. The sink_count of DPCD of dongle will increase t

Re: [Freedreno] [PATCH v2 2/3] drm/msm/dp: do not re initialize of audio_comp at display_disable()

2021-04-14 Thread khsieh
On 2021-04-13 20:17, Stephen Boyd wrote: Quoting Kuogee Hsieh (2021-04-13 16:11:30) At dongle unplug, dp initializes audio_comp followed by sending disconnect event notification to audio and to make sure audio had shutdown completely by wait for audio completion notification at display_disable(

[Freedreno] [v1 0/3] drm: Add support for backlight control of eDP panel on ti-sn65dsi86 bridge

2021-04-14 Thread Rajeev Nandan
The backlight level of an eDP panel can be controlled through the AUX channel using DPCD registers of the panel. The capability for the Source device to adjust backlight characteristics within the panel, using the Sink device DPCD registers is indicated by the TCON_BACKLIGHT_ADJUSTMENT_CAPABLE bit

[Freedreno] [v1 1/3] drm/dp: Add DisplayPort aux backlight control support

2021-04-14 Thread Rajeev Nandan
Add panel backlight control using DPCD registers on the DisplayPort aux channel. Signed-off-by: Rajeev Nandan --- drivers/gpu/drm/Kconfig| 8 ++ drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_dp_aux_backlight.c | 191 + inclu

[Freedreno] [v1 3/3] drm/bridge: ti-sn65dsi86: Add DisplayPort aux backlight support

2021-04-14 Thread Rajeev Nandan
Add support to control the backlight of the eDP panel connected to the ti-sn65dsi86 bridge through aux channel. Signed-off-by: Rajeev Nandan --- drivers/gpu/drm/bridge/Kconfig| 1 + drivers/gpu/drm/bridge/ti-sn65dsi86.c | 26 ++ 2 files changed, 27 insertions(+)

[Freedreno] [v1 2/3] dt-bindings: drm/bridge: ti-sn65dsi86: Document use-aux-backlight

2021-04-14 Thread Rajeev Nandan
If the panel connected to the bridge supports backlight control using DPCD registers on the DisplayPort aux channel, setting "use-aux-backlight" property in the bridge node will enable the registration of a DP aux backlight device from the bridge driver. Signed-off-by: Rajeev Nandan --- .../devi