Re: [Freedreno] [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-07 Thread Rob Clark
On Thu, Jan 7, 2021 at 9:20 AM Rob Clark wrote: > > On Sat, Jan 2, 2021 at 12:26 PM Iskren Chernev > wrote: > > > > The msm_gem_get_iova should be guarded with gpu != NULL and not aspace > > != NULL, because aspace is NULL when using vram carveout. > > > > Fixes: 933415e24bd0d ("drm/msm: Add sup

[Freedreno] [pull] drm/msm: drm-msm-fixes-2021-01-07

2021-01-07 Thread Rob Clark
Hi Dave, A few misc fixes The following changes since commit e319a1b956f785f618611857cd946dca2bb68542: drm/msm: add IOMMU_SUPPORT dependency (2020-12-05 08:25:52 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.git drm-msm-fixes-2021-01-07 for you to f

[Freedreno] [PATCH 1/2] drm/msm/dp: postpone irq_hpd event during connection pending state

2021-01-07 Thread Kuogee Hsieh
irq_hpd event can only be executed at connected state. Therefore irq_hpd event should be postponed if it happened at connection pending state. This patch also make sure both link rate and lane are valid before start link training. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display

[Freedreno] [PATCH 2/2] drm/msm/dp: unplug interrupt missed after irq_hpd handler

2021-01-07 Thread Kuogee Hsieh
There is HPD unplug interrupts missed at scenario of an irq_hpd followed by unplug interrupts with around 10 ms in between. Since both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts, irq_hpd handler should not issues either aux or sw reset to avoid following unplug interrupt be cleared a

[Freedreno] [PATCH 0/2] *** fix missing unplug interrupt problem ***

2021-01-07 Thread Kuogee Hsieh
Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts. Therefore irq_hpd handler should not issues either aux or sw reset to avoid following unplug interrupt be cleared accidentally. Kuogee Hsieh (2): drm/msm/dp: postpone irq_hpd event during connection pending state drm/msm/dp: unp

Re: [Freedreno] [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-07 Thread Rob Clark
On Wed, Jan 6, 2021 at 8:50 PM Sai Prakash Ranjan wrote: > > On 2021-01-05 01:00, Konrad Dybcio wrote: > > Using this code on A5xx (and probably older too) causes a > > smmu bug. > > > > Fixes: 474dadb8b0d5 ("drm/msm/a6xx: Add support for using system > > cache(LLC)") > > Signed-off-by: Konrad Dyb

Re: [Freedreno] [PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-07 Thread Rob Clark
On Sat, Jan 2, 2021 at 12:26 PM Iskren Chernev wrote: > > The msm_gem_get_iova should be guarded with gpu != NULL and not aspace > != NULL, because aspace is NULL when using vram carveout. > > Fixes: 933415e24bd0d ("drm/msm: Add support for private address space > instances") > > Signed-off-by: I