Re: [Freedreno] [v3, 3/3] dt-bindings: drm/msm/gpu: Add cooling device support

2020-10-28 Thread mka
On Wed, Oct 28, 2020 at 07:09:54PM +0530, Akhil P Oommen wrote: > Add cooling device support to gpu. A cooling device is bound to a > thermal zone to allow thermal mitigation. > > Signed-off-by: Akhil P Oommen > --- > Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++ > 1 file ch

Re: [Freedreno] [v3, 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support

2020-10-28 Thread mka
Hi Akhil, On Wed, Oct 28, 2020 at 07:09:53PM +0530, Akhil P Oommen wrote: > Add cooling-cells property and the cooling maps for the gpu tzones > to support GPU cooling. > > Signed-off-by: Akhil P Oommen > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 30 +++--- > 1 file c

Re: [Freedreno] [PATCH 2/3] opp: Add devres wrapper for dev_pm_opp_set_prop_name

2020-10-28 Thread Viresh Kumar
On 28-10-20, 19:02, Frank Lee wrote: > On Wed, Oct 28, 2020 at 6:29 PM Viresh Kumar wrote: > > > > On 12-10-20, 21:55, Frank Lee wrote: > > > From: Yangtao Li > > > > > > Add devres wrapper for dev_pm_opp_set_prop_name() to simplify driver > > > code. > > > > > > Signed-off-by: Yangtao Li > > >

[Freedreno] [PATCH v2 1/2] drm/msm: Implement shutdown callback for adreno

2020-10-28 Thread Akhil P Oommen
Implement the shutdown callback for adreno gpu platform device to safely shutdown it before a system reboot. This helps to avoid futher transactions from gpu after the smmu is moved to bypass mode. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_device.c | 6 ++ 1 file ch

[Freedreno] [PATCH v2 2/2] drm/msm: Fix duplicate gpu node in icc summary

2020-10-28 Thread Akhil P Oommen
The dev_pm_opp_of_add_table() api initializes the icc nodes for gpu indirectly. So we can avoid using of_icc_get() api in the common probe path. To improve this, move of_icc_get() to target specific code where it is required. This patch helps to fix duplicate gpu node listed in the interconnect su

[Freedreno] [PATCH v3 3/3] dt-bindings: drm/msm/gpu: Add cooling device support

2020-10-28 Thread Akhil P Oommen
Add cooling device support to gpu. A cooling device is bound to a thermal zone to allow thermal mitigation. Signed-off-by: Akhil P Oommen --- Documentation/devicetree/bindings/display/msm/gpu.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[Freedreno] [PATCH v3 2/3] arm64: dts: qcom: sc7180: Add gpu cooling support

2020-10-28 Thread Akhil P Oommen
Add cooling-cells property and the cooling maps for the gpu tzones to support GPU cooling. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dt

[Freedreno] [PATCH v3 1/3] drm/msm: Add support for GPU cooling

2020-10-28 Thread Akhil P Oommen
Register GPU as a devfreq cooling device so that it can be passively cooled by the thermal framework. Signed-off-by: Akhil P Oommen --- Changes in v3: 1. Minor fix in binding documentation (RobH) Changes in v2: 1. Update the dt bindings documentation drivers/gpu/drm/msm/msm_gpu.c

Re: [Freedreno] [PATCH 2/3] opp: Add devres wrapper for dev_pm_opp_set_prop_name

2020-10-28 Thread Frank Lee
On Wed, Oct 28, 2020 at 6:29 PM Viresh Kumar wrote: > > On 12-10-20, 21:55, Frank Lee wrote: > > From: Yangtao Li > > > > Add devres wrapper for dev_pm_opp_set_prop_name() to simplify driver > > code. > > > > Signed-off-by: Yangtao Li > > Signed-off-by: Yangtao Li > > --- > > drivers/opp/core.

Re: [Freedreno] [PATCH 2/3] opp: Add devres wrapper for dev_pm_opp_set_prop_name

2020-10-28 Thread Viresh Kumar
On 12-10-20, 21:55, Frank Lee wrote: > From: Yangtao Li > > Add devres wrapper for dev_pm_opp_set_prop_name() to simplify driver > code. > > Signed-off-by: Yangtao Li > Signed-off-by: Yangtao Li > --- > drivers/opp/core.c | 39 +++ > include/linux/pm_op