Re: [Freedreno] [DPU PATCH v5 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-03-31 Thread Sam Ravnborg
Hi Tanmay Reviewing the yaml bindings triggered a few comments. See below. Sam On Tue, Mar 31, 2020 at 05:30:27PM -0700, Tanmay Shah wrote: > From: Chandan Uddaraju > > Add bindings for Snapdragon DisplayPort and > display-port PLL driver. > > Changes in V2: > Provide details about s

[Freedreno] [DPU PATCH v5 5/5] drm/msm/dpu: add display port support in DPU

2020-03-31 Thread Tanmay Shah
From: Jeykumar Sankaran Add display port support in DPU by creating hooks for DP encoder enumeration and encoder mode initialization. This change is based on the Snapdragon Display port driver changes[1]. changes in v2: - rebase on [2] (Sean Paul) - remove unwanted error checks

[Freedreno] [DPU PATCH v5 4/5] drm/msm/dp: add support for DP PLL driver

2020-03-31 Thread Tanmay Shah
From: Chandan Uddaraju Add the needed DP PLL specific files to support display port interface on msm targets. The DP driver calls the DP PLL driver registration. The DP driver sets the link and pixel clock sources. Changes in v2: -- Update copyright markings on all relevant files. -- Use DRM_DE

[Freedreno] [DPU PATCH v5 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-03-31 Thread Tanmay Shah
From: Chandan Uddaraju Add bindings for Snapdragon DisplayPort and display-port PLL driver. Changes in V2: Provide details about sel-gpio Changes in V4: Provide details about max dp lanes Change the commit text Changes in V5: Moved dp.txt to yaml file. Signed-off-by: Chandan Uddaraju Signed-

[Freedreno] [DPU PATCH v5 2/5] drm: add constant N value in helper file

2020-03-31 Thread Tanmay Shah
From: Chandan Uddaraju The constant N value (0x8000) is used by multiple DP drivers. Define this value in header file and use this in the existing i915 display driver. Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- include/dr

[Freedreno] [DPU PATCH v5 0/5] Add support for DisplayPort driver on SnapDragon.

2020-03-31 Thread Tanmay Shah
These patches add support for Display-Port driver on SnapDragon 845 hardware. It adds DP driver and DP PLL driver files along with the needed device-tree bindings. The block diagram of DP driver is shown below: +-+ |DRM FRAMEWORK| +

Re: [Freedreno] [PATCH 3/5] drm: msm: scale DDR BW along with GPU frequency

2020-03-31 Thread Jordan Crouse
On Tue, Mar 31, 2020 at 01:25:51PM +0530, Sharat Masetty wrote: > This patch adds support to parse the OPP tables attached the GPU device, > the main opp table and the DDR bandwidth opp table. Additionally, vote > for the GPU->DDR bandwidth when setting the GPU frequency by querying > the linked DD

Re: [Freedreno] [PATCH 4/5] drm: msm: a6xx: Fix off by one error when setting GPU freq

2020-03-31 Thread Jordan Crouse
On Tue, Mar 31, 2020 at 01:25:52PM +0530, Sharat Masetty wrote: > This patch fixes an error in the for loop, thereby allowing search on > the full list of possible GPU power levels. > > Signed-off-by: Sharat Masetty Oh fun. This qualifies for drm-fixes. Can you pull this out of the stack and CC

Re: [Freedreno] [PATCH v10 0/2] Add support for rm69299 Visionox panel driver and add devicetree bindings for visionox panel

2020-03-31 Thread Matthias Kaehlcke
On Mon, Mar 30, 2020 at 09:25:11PM +0200, Sam Ravnborg wrote: > Hi Matthias. > > On Sun, Mar 29, 2020 at 10:44:17AM -0700, Matthias Kaehlcke wrote: > > Hi Sam, > > > > On Sat, Mar 28, 2020 at 09:40:47PM +0100, Sam Ravnborg wrote: > > > Hi Harigovindan > > > > > > On Fri, Mar 27, 2020 at 01:06:34

Re: [Freedreno] [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-03-31 Thread Doug Anderson
Hi, On Tue, Mar 31, 2020 at 6:58 AM Kalyan Thota wrote: > > "The PM core always increments the runtime usage counter > before calling the ->suspend() callback and decrements it > after calling the ->resume() callback" > > DPU and DSI are managed as runtime devices. When > suspend is triggered, PM

Re: [Freedreno] [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-03-31 Thread kalyan_t
On 2020-03-31 00:25, Doug Anderson wrote: Hi, On Mon, Mar 30, 2020 at 2:04 AM Kalyan Thota wrote: "The PM core always increments the runtime usage counter before calling the ->suspend() callback and decrements it after calling the ->resume() callback" DPU and DSI are managed as runtime devi

[Freedreno] [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-03-31 Thread Kalyan Thota
"The PM core always increments the runtime usage counter before calling the ->suspend() callback and decrements it after calling the ->resume() callback" DPU and DSI are managed as runtime devices. When suspend is triggered, PM core adds a refcount on all the devices and calls device suspend, sinc

[Freedreno] [PATCH 4/5] drm: msm: a6xx: Fix off by one error when setting GPU freq

2020-03-31 Thread Sharat Masetty
This patch fixes an error in the for loop, thereby allowing search on the full list of possible GPU power levels. Signed-off-by: Sharat Masetty --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/d

[Freedreno] [PATCH 5/5] dt-bindings: drm/msm/gpu: Document OPP phandle list for the GPU

2020-03-31 Thread Sharat Masetty
Update the documentation for listing the multiple optional GPU and the DDR OPP tables to help enable DDR scaling. Signed-off-by: Sharat Masetty --- .../devicetree/bindings/display/msm/gpu.txt| 63 +- 1 file changed, 61 insertions(+), 2 deletions(-) diff --git a/Docum

[Freedreno] [PATCH 3/5] drm: msm: scale DDR BW along with GPU frequency

2020-03-31 Thread Sharat Masetty
This patch adds support to parse the OPP tables attached the GPU device, the main opp table and the DDR bandwidth opp table. Additionally, vote for the GPU->DDR bandwidth when setting the GPU frequency by querying the linked DDR BW opp to the GPU opp. Signed-off-by: Sharat Masetty --- drivers/gp

[Freedreno] [PATCH 1/5] arm64: dts: qcom: sc7180: Add interconnect bindings for GPU

2020-03-31 Thread Sharat Masetty
This patch adds the interconnect bindings to the GPU node. This enables the GPU->DDR path bandwidth voting. Signed-off-by: Sharat Masetty --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco

[Freedreno] [PATCH 2/5] arm64: dts: qcom: sc7180: Add GPU DDR BW opp table

2020-03-31 Thread Sharat Masetty
This patch adds a new opp table listing the GPU DDR bandwidth opps. Also adds a required_opp binding to the GPUs main OPP table which holds a phandle to a bandwidth opp in the new table. This enables linking the GPU power level opp to the DDR bandwidth opp and helps with scaling DDR along with GPU

[Freedreno] [PATCH 0/5] Add support for GPU DDR BW scaling

2020-03-31 Thread Sharat Masetty
This series adds support for GPU DDR bandwidth scaling and is based on the bindings from Sarvana[1]. This work is based on Sibi's work for CPU side [2] which also lists all the needed dependencies to get this series working. My workspace is based on a chrome tag [3]. Although the bindings add suppo