Re: [Freedreno] [PATCH] drm/msm/mdp5: enable autocommit

2019-12-16 Thread Jeffrey Hugo
On Thu, Dec 12, 2019 at 7:40 PM Brian Masney wrote: > > Hi Jeffrey, > > On Tue, Dec 03, 2019 at 07:18:31AM -0700, Jeffrey Hugo wrote: > > On Mon, Dec 2, 2019 at 6:40 PM Brian Masney wrote: > > > On Wed, Nov 13, 2019 at 06:23:34AM -0500, Brian Masney wrote: > > > > On Tue, Nov 12, 2019 at 08:38:27

Re: [Freedreno] [PATCH v3 5/5] drm/msm/a6xx: Support split pagetables

2019-12-16 Thread Rob Clark
On Mon, Dec 16, 2019 at 8:38 AM Jordan Crouse wrote: > > Attempt to enable split pagetables if the arm-smmu driver supports it. > This will move the default address space from the default region to > the address range assigned to TTBR1. The behavior should be transparent > to the driver for now bu

[Freedreno] [PATCH v3 3/5] drm/msm: Attach the IOMMU device during initialization

2019-12-16 Thread Jordan Crouse
Everywhere an IOMMU object is created by msm_gpu_create_address_space the IOMMU device is attached immediately after. Instead of carrying around the infrastructure to do the attach from the device specific code do it directly in the msm_iommu_init() function. This gets it out of the way for more ag

[Freedreno] [PATCH v3 4/5] drm/msm: Refactor address space initialization

2019-12-16 Thread Jordan Crouse
Refactor how address space initialization works. Instead of having the address space function create the MMU object (and thus require separate but equal functions for gpummu and iommu) use a single function and pass the MMU struct. Make the generic code cleaner by using target specific functions to

[Freedreno] [PATCH v3 5/5] drm/msm/a6xx: Support split pagetables

2019-12-16 Thread Jordan Crouse
Attempt to enable split pagetables if the arm-smmu driver supports it. This will move the default address space from the default region to the address range assigned to TTBR1. The behavior should be transparent to the driver for now but it gets the default buffers out of the way when we want to sta

[Freedreno] [PATCH v3 0/5] iommu/arm-smmu: Split pagetable support for arm-smmu-v2

2019-12-16 Thread Jordan Crouse
address space for the TTBR1 range. These patches are on based on top of linux-next-20191216 with [1], [2], and [3] from Robin on the iommu list. Change log: v3: Remove the implementation specific and make split pagetable support part of the generic configuration [1] https://lists.linuxfoundation.org

Re: [Freedreno] [PATCH 4/5] drm: msm: a6xx: fix debug bus register configuration

2019-12-16 Thread Jordan Crouse
On Tue, Dec 03, 2019 at 03:06:15PM +, Sharat Masetty wrote: > Fix the cx debugbus related register configuration, to collect accurate > bus data during gpu snapshot. This helps with complete snapshot dump > and also complete proper GPU recovery. Reviewed-by: Jordan Crouse This guy should be

Re: [Freedreno] [PATCH 2/5] drm: msm: a6xx: Add support for A618

2019-12-16 Thread Jordan Crouse
On Tue, Dec 03, 2019 at 03:06:11PM +, Sharat Masetty wrote: > This patch adds support for enabling Graphics Bus Interface(GBIF) > used in multiple A6xx series chipets. Also makes changes to the > PDC/RSC sequencing specifically required for A618. This is needed > for proper interfacing with RPM

Re: [Freedreno] [PATCH 3/5] drm: msm: a6xx: Dump GBIF registers, debugbus in gpu state

2019-12-16 Thread Jordan Crouse
On Tue, Dec 03, 2019 at 03:06:12PM +, Sharat Masetty wrote: > Add the relevant GBIF registers and the debug bus to the a6xx gpu > state. This comes in pretty handy when debugging GPU bus related > issues. > > Change-Id: I224fda727012a456ccd28ca14caf9fcce236e629 > Signed-off-by: Sharat Masetty

Re: [Freedreno] [PATCH 4/4] drm/msm/dpu: Remove unneeded semicolon in dpu_encoder.c

2019-12-16 Thread Jordan Crouse
On Sat, Dec 14, 2019 at 05:31:50PM +0800, zhengbin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:2260:3-4: Unneeded semicolon Reviewed-by: Jordan Crouse > > Reported-by: Hulk Robot > Signed-off-by: zhengbin > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encod

Re: [Freedreno] [PATCH 3/4] drm/msm/dpu: Remove unneeded semicolon in dpu_plane.c

2019-12-16 Thread Jordan Crouse
On Sat, Dec 14, 2019 at 05:31:49PM +0800, zhengbin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c:741:2-3: Unneeded semicolon > Reviewed-by: Jordan Crouse > Reported-by: Hulk Robot > Signed-off-by: zhengbin > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

Re: [Freedreno] [PATCH 1/4] drm/msm/hdmi: Remove unneeded semicolon

2019-12-16 Thread Jordan Crouse
On Sat, Dec 14, 2019 at 05:31:47PM +0800, zhengbin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/msm/hdmi/hdmi_connector.c:104:3-4: Unneeded semicolon Reviewed-by: Jordan Crouse > Reported-by: Hulk Robot > Signed-off-by: zhengbin > --- > drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 2

Re: [Freedreno] [PATCH 2/4] drm/msm/mdp5: Remove unneeded semicolon

2019-12-16 Thread Jordan Crouse
On Sat, Dec 14, 2019 at 05:31:48PM +0800, zhengbin wrote: > Fixes coccicheck warning: > > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:905:2-3: Unneeded semicolon > Reviewed-by: Jordan Crouse > Reported-by: Hulk Robot > Signed-off-by: zhengbin > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c |

Re: [Freedreno] [DPU PATCH v3 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon 845

2019-12-16 Thread vadiraj kaveri
Hi Chandan, I see some difference in DP and PLL base address between SD845 Android 4.9 kernel and [DPU,v3,1/5] dt-bindings. And also I find difference in reg format, why is that so? Is it possible to share your git tree of SD845 DP to check on DB845C? [DPU,v3,1/5] dt-bindings: msm/dp: add bindin