Re: [Freedreno] [PATCH v2] drm/msm/dsi: Implement reset correctly

On Fri, Oct 11, 2019 at 06:39:39AM -0700, Jeffrey Hugo wrote: > On msm8998, vblank timeouts are observed because the DSI controller is not > reset properly, which ends up stalling the MDP. This is because the reset > logic is not correct per the hardware documentation. > > The documentation state

Re: [Freedreno] [PATCH v2 1/3] dt-bindings: power: Convert Generic Power Domain bindings to json-schema

On Wed, Oct 02, 2019 at 06:06:30PM +0200, Krzysztof Kozlowski wrote: > Convert Generic Power Domain bindings to DT schema format using > json-schema. The consumer bindings are split to separate file. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Select all nodes for

[Freedreno] [PATCH v2] drm/msm/dsi: Implement reset correctly

On msm8998, vblank timeouts are observed because the DSI controller is not reset properly, which ends up stalling the MDP. This is because the reset logic is not correct per the hardware documentation. The documentation states that after asserting reset, software should wait some time (no indicat

Re: [Freedreno] [PATCH v2] drm/msm: Sanitize the modeset_is_locked checks in dpu

On Thu, Oct 10, 2019 at 02:17:44PM -0400, Sean Paul wrote: > From: Sean Paul > > As Daniel mentions in his email [1], non-blocking commits don't hold the > modeset locks, so we can safely access state as long as these functions > are in the commit path. So remove the WARN_ON in dpu_kms_encoder_en

Re: [Freedreno] [PATCH 0/4] drm/msm: Remove four set but not used variables

On Thu, Oct 10, 2019 at 02:55:02PM +0800, zhengbin wrote: > zhengbin (4): > drm/msm/mdp5: Remove set but not used variable 'fmt' > drm/msm/mdp5: Remove set but not used variable 'hw_cfg' in blend_setup > drm/msm/dsi: Remove set but not used variable 'lpx' > drm/msm/dsi: Remove set but not u

Re: [Freedreno] [PATCH] drm/msm/mdp5: make config variables static

On Wed, Oct 09, 2019 at 01:05:22PM +0100, Ben Dooks wrote: > A number of the config structs are not exported so make > them static to avoid the following sparse warnings: > > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:17:26: warning: symbol > 'msm8x74v1_config' was not declared. Should it be static

Re: [Freedreno] [PATCH] drm/msm: make a5xx_show and a5xx_gpu_state_put static

On Wed, Oct 09, 2019 at 09:44:06AM -0600, Jordan Crouse wrote: > On Wed, Oct 09, 2019 at 12:46:07PM +0100, Ben Dooks wrote: > > The a5xx_show and a5xx_gpu_state_put objects are not exported > > outside of the file, so make them static to avoid the following > > warnings from sparse: > > > > driver

Re: [Freedreno] [PATCH 0/4] treewide: fix interrupted release

On Thu, Oct 10, 2019 at 03:50:43PM +0200, Daniel Vetter wrote: > On Thu, Oct 10, 2019 at 03:13:29PM +0200, Johan Hovold wrote: > > Two old USB drivers had a bug in them which could lead to memory leaks > > if an interrupted process raced with a disconnect event. > > > > Turns out we had a few more