Re: [Freedreno] [PATCH v3 00/22] Associate ddc adapters with connectors

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 06:01:14PM +0200, Andrzej Pietrasiewicz wrote: > It is difficult for a user to know which of the i2c adapters is for which > drm connector. This series addresses this problem. > > The idea is to have a symbolic link in connector's sysfs directory, e.g.: > > ls -l /sys/clas

[Freedreno] [PATCH] drm/msm: Transition console to msm framebuffer

2019-06-28 Thread Jeffrey Hugo
If booting a device using EFI, efifb will likely come up and claim the console. When the msm display stack finally comes up, we want the console to move over to the msm fb, so add support to kick out any firmware based framebuffers to accomplish the console transition. Suggested-by: Rob Clark Si

Re: [Freedreno] [PATCH v3 00/22] Associate ddc adapters with connectors

2019-06-28 Thread Laurent Pinchart
Hi Andrzej, Just FYI, I have a patch series that reworks how bridges and connectors are handled, and it will heavily conflict with this. The purpose of the two series isn't the same, so both make sense. I will post the patches this weekend, and will then review this series in that context. Hopeful

[Freedreno] [PATCH v3 17/22] drm/ast: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/ast/ast_mode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index ffccbef962a4..155c3487a1a7 100644 --- a/drivers

[Freedreno] [PATCH v3 22/22] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/radeon/radeon_connectors.c | 82 +- 1 file changed, 63 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/ra

[Freedreno] [PATCH v3 15/22] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sti/sti_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index f03d617edc4c..c5e6c33ff2cd 100644 --- a/drivers

[Freedreno] [PATCH v3 16/22] drm/mgag200: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mgag200/mgag200_mode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index a25054015e8c..a22dbecd

[Freedreno] [PATCH v3 11/22] drm/vc4: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/vc4/vc4_hdmi.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 87ad0879edf3..

[Freedreno] [PATCH v3 00/22] Associate ddc adapters with connectors

2019-06-28 Thread Andrzej Pietrasiewicz
It is difficult for a user to know which of the i2c adapters is for which drm connector. This series addresses this problem. The idea is to have a symbolic link in connector's sysfs directory, e.g.: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0

[Freedreno] [PATCH v3 19/22] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bri

[Freedreno] [PATCH v3 14/22] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c index 62d014c20988..c373edb9

[Freedreno] [PATCH v3 06/22] drm/sun4i: hdmi: Provide ddc symlink in sun4i hdmi connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sun4i/sun4i_hdmi.h | 1 - drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 14 +++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hd

[Freedreno] [PATCH v3 04/22] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/inno_hdmi.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c

[Freedreno] [PATCH v3 13/22] drm: zte: Provide ddc symlink in vga connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_vga.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_vga.c b/drivers/gpu/drm/zte/zx_vga.c index 1634a08707

[Freedreno] [PATCH v3 01/22] drm: Include ddc adapter pointer in struct drm_connector

2019-06-28 Thread Andrzej Pietrasiewicz
Add generic code which creates symbolic links in sysfs, pointing to ddc interface used by a particular video output. For example: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \ -> ../../../../soc/1388.i2c/i2c-2 This ma

[Freedreno] [PATCH v3 10/22] drm/imx: imx-tve: Provide ddc symlink in connector's sysfs

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-tve.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index e725af8a0025..b8bee4e1f169

[Freedreno] [PATCH v3 12/22] drm: zte: Provide ddc symlink in hdmi connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_hdmi.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_hdmi.c b/drivers/gpu/drm/zte/zx_hdmi.c index bfe918b

[Freedreno] [PATCH v3 08/22] drm/tegra: Provide ddc symlink in output connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tegra/drm.h| 1 - drivers/gpu/drm/tegra/output.c | 12 ++-- drivers/gpu/drm/tegra/sor.c| 6 +++--- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/dri

[Freedreno] [PATCH v3 09/22] drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-ldb.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index 383733302280..44fdb2

[Freedreno] [PATCH v3 02/22] drm/exynos: Provide ddc symlink in connector's sysfs

2019-06-28 Thread Andrzej Pietrasiewicz
Switch to using the ddc provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/exynos/exynos_hdmi.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c in

[Freedreno] [PATCH v3 18/22] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-

[Freedreno] [PATCH v3 07/22] drm/mediatek: Provide ddc symlink in hdmi connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 5d6a9f

[Freedreno] [PATCH v3 03/22] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_h

[Freedreno] [PATCH v3 21/22] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 70 ++- 1 file changed, 51 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/dr

[Freedreno] [PATCH v3 20/22] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/ti-tfp410.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c ind

[Freedreno] [PATCH v3 05/22] drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory

2019-06-28 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector.c index 07b4cb877d82.

Re: [Freedreno] [PATCH] drm/msm: correct NULL pointer dereference in context_init

2019-06-28 Thread Rob Clark
On Wed, Jun 26, 2019 at 7:05 PM Brian Masney wrote: > > Correct attempted NULL pointer dereference in context_init() when > running without an IOMMU. > > Signed-off-by: Brian Masney > Fixes: 295b22ae596c ("drm/msm: Pass the MMU domain index in struct > msm_file_private") > --- > The no IOMMU cas