Re: [Freedreno] [PATCH 3/4] drm/msm: dpu: Untangle frame_done timeout units

2019-02-05 Thread Fritz Koenig
On Mon, Jan 28, 2019 at 12:43 PM Sean Paul wrote: > > From: Sean Paul > > There exists a bunch of confusion as to what the actual units of > frame_done is: > > - The definition states it's in # of frames > - CRTC treats it like it's ms > - frame_done_timeout comment thinks it's Hz, but it stores

Re: [Freedreno] [PATCH 4/4] drm/msm: dpu: Don't queue the frame_done watchdog for cursor

2019-02-05 Thread Fritz Koenig
On Mon, Jan 28, 2019 at 12:43 PM Sean Paul wrote: > > From: Sean Paul > > In the case of an async/cursor update, we don't wait for the frame_done > event, which means handle_frame_done is never called, and the frame_done > watchdog isn't canceled. Currently, this results in a frame_done timeout >

Re: [Freedreno] [PATCH] drm/msm: dpu: Don't set frame_busy_mask for async updates

2019-02-05 Thread Fritz Koenig
On Wed, Jan 30, 2019 at 8:32 AM Sean Paul wrote: > > From: Sean Paul > > The frame_busy mask is used in frame_done event handling, which is not > invoked for async commits. So an async commit will leave the > frame_busy mask populated after it completes and future commits will start > with the bu