Re: [Freedreno] [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU

2018-12-14 Thread Doug Anderson
Hi, On Fri, Dec 14, 2018 at 3:58 PM Doug Anderson wrote: > > Hi, > > On Fri, Dec 14, 2018 at 2:16 PM Jordan Crouse wrote: > > > > Add documentation for the interconnect and interconnect-names bindings > > for the GPU node as detailed by bindings/interconnect/interconnect.txt. > > > > Signed-off-

Re: [Freedreno] [PATCH v2 2/2] arm64: dts: sdm845: Add interconnect for GPU

2018-12-14 Thread Doug Anderson
Hi, On Fri, Dec 14, 2018 at 2:16 PM Jordan Crouse wrote: > > Define an interconnect port for the GPU to set bus > capabilities. > > Signed-off-by: Jordan Crouse > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++ > 1 file changed, 3 insertions(+) Looks good to me. This could go into Andy's

[Freedreno] [PATCH v5 4/5] drm/msm: clean up display thread

2018-12-14 Thread Jeykumar Sankaran
Since there are no clients using these threads, cleaning it up. changes in v2: - switch all the dependent clients to use system wq before removing the disp_threads (Sean Paul) changes in v3: - none changes in v4: - none changes in v5: - Rebase on latest ti

Re: [Freedreno] [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU

2018-12-14 Thread Doug Anderson
Hi, On Fri, Dec 14, 2018 at 2:16 PM Jordan Crouse wrote: > > Add documentation for the interconnect and interconnect-names bindings > for the GPU node as detailed by bindings/interconnect/interconnect.txt. > > Signed-off-by: Jordan Crouse > --- > Documentation/devicetree/bindings/display/msm/gp

[Freedreno] [PATCH v5 3/5] drm/msm/dpu: use msm wq for idle power collapse

2018-12-14 Thread Jeykumar Sankaran
msm is using msm wq for dispatching commit and vblank events. Switch idle power collapse feature also to use msm wq to handle delayed work handlers so that msm can get rid of redundant display threads. changes in v2: - patch introduced in v2 changes in v3: - none changes in v4:

[Freedreno] [PATCH v5 1/5] drm/msm/dpu: use kthread_destroy_worker to release msm workers

2018-12-14 Thread Jeykumar Sankaran
use kthread_destroy_worker to destroy workers and release their associated kthreads. changes in v3: - introduced in the series changes in v4: - none changes in v5: - none Signed-off-by: Jeykumar Sankaran --- drivers/gpu/drm/msm/msm_drv.c | 6 ++ 1 file changed, 2 ins

[Freedreno] [PATCH v5 2/5] drm/msm/dpu: use msm wq for vblank events

2018-12-14 Thread Jeykumar Sankaran
DPU was using one thread per display to dispatch async commits and vblank requests. Since clean up already happened in msm to use the common thread for all the display commits, display threads are only used to cater vblank requests. Since a single thread is sufficient to do the job without any perf

[Freedreno] [PATCH v5 5/5] drm/msm: subclass work object for vblank events

2018-12-14 Thread Jeykumar Sankaran
msm maintains a separate structure to define vblank work definitions and a list to track events submitted to the workqueue. We can avoid this redundant list and its protection mechanism, if we subclass the work object to encapsulate vblank event parameters. changes in v2: - subclass optimi

[Freedreno] [PATCH 7/7] [stable-4.19] drm/msm: fix address space warning

2018-12-14 Thread Arnd Bergmann
In the linux-4.19 stable kernel, we get a warning about a type mismatch between phys_addr_t and dma_addr_t: drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c: In function '_dpu_dbg_dump_dpu_dbg_bus': drivers/gpu/drm/msm/disp/dpu1/dpu_dbg.c:2003:16: error: passing argument 3 of 'dma_alloc_coherent' from in

[Freedreno] [PATCH 0/7] v4.19-stable randconfig fixes

2018-12-14 Thread Arnd Bergmann
Hi Greg, I did some randconfig testing on linux-4.19 arm/arm64/x86. So far I needed 27 patches, most of which are also still needed in mainline Linux. I had submitted some before, and others were not submitted previously for some reason. I'll try to get those fixed in mainline and then make sure w

[Freedreno] [PATCH v2 2/2] arm64: dts: sdm845: Add interconnect for GPU

2018-12-14 Thread Jordan Crouse
Define an interconnect port for the GPU to set bus capabilities. Signed-off-by: Jordan Crouse --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 0a5ddfc4c59b..2acfea877

[Freedreno] [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU

2018-12-14 Thread Jordan Crouse
Add documentation for the interconnect and interconnect-names bindings for the GPU node as detailed by bindings/interconnect/interconnect.txt. Signed-off-by: Jordan Crouse --- Documentation/devicetree/bindings/display/msm/gpu.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Document

[Freedreno] [PATCH v2 0/2] arm64: dts: sdm845: Add sdm845 GPU interconnect

2018-12-14 Thread Jordan Crouse
Two quick patches to document and add an interconnect port definition for the sdm845 GPU. This is based on the base GPU DT changes: https://patchwork.freedesktop.org/series/39308/ As well as the DT nodes from Georgi: https://patchwork.kernel.org/patch/10719483/ v2: Fix interconnect supplier to m

[Freedreno] [DPU PATCH v2] drm/msm/dpu: Change RGB565 and BGR565 format map.

2018-12-14 Thread Tanmay Shah
Red and Blue colors will be interchanged on display with current format maps for RGB565 and BGR565. Change both format maps to display correct colors. Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Freedreno] [DPU PATCH v1] drm/msm/dpu: Change RGB565 and BGR565 format map.

2018-12-14 Thread jshekhar
On 2018-12-15 00:04, jshek...@codeaurora.org wrote: On 2018-12-14 23:53, Tanmay Shah wrote: Red and Blue colors will be interchanged on display with current format maps for RGB565 and BGR565. Change both format maps to dispaly correct colors. spelling: dispaly/display Signed-off-by: Tanmay

Re: [Freedreno] [DPU PATCH v1] drm/msm/dpu: Change RGB565 and BGR565 format map.

2018-12-14 Thread jshekhar
On 2018-12-14 23:53, Tanmay Shah wrote: Red and Blue colors will be interchanged on display with current format maps for RGB565 and BGR565. Change both format maps to dispaly correct colors. Signed-off-by: Tanmay Shah LGTM. Reviewed-by: Jayant Shekhar --- drivers/gpu/drm/msm/disp/dpu1/d

[Freedreno] [DPU PATCH v1] drm/msm/dpu: Change RGB565 and BGR565 format map.

2018-12-14 Thread Tanmay Shah
Red and Blue colors will be interchanged on display with current format maps for RGB565 and BGR565. Change both format maps to dispaly correct colors. Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Freedreno] [DPU PATCH v2] drm/msm/dpu: Clean up dpu hw interrupts

2018-12-14 Thread Jayant Shekhar
Remove unused functions and macros from dpu hw interrupts file. changes in v2: Removed clear_interrupt_status (Jordan Crouse) Signed-off-by: Jayant Shekhar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 44 --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 4

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-14 Thread Doug Anderson
Hi, On Thu, Dec 13, 2018 at 8:41 PM Viresh Kumar wrote: > > On 12-12-18, 14:18, Jordan Crouse wrote: > > + gpu_opp_table: opp-table { > > + compatible = "operating-points-v2-qcom-level"; > > I think you need to mention "operating-points-v2" as well

Re: [Freedreno] [DPU PATCH ] drm/msm/dpu: Ignore alpha for XBGR8888 format

2018-12-14 Thread Sean Paul
On Fri, Nov 30, 2018 at 05:22:50PM +0530, Jayant Shekhar wrote: > Alpha enable in the pixel format will help in > selecting the blend rule. By keeping alpha enable > to true we are allowing foreground alpha to blend > with the layer. If alpha is don't care, then we > should not allow pixel alpha to

Re: [Freedreno] [PATCH v3 2/3] drm/msm/dpu: handle failures while initializing displays

2018-12-14 Thread Jordan Crouse
On Thu, Dec 13, 2018 at 10:51:03AM -0800, Jeykumar Sankaran wrote: > Bail out KMS hw init on display initialization failures with > proper error logging. > > changes in v3: > - introduced in the series > > Signed-off-by: Jeykumar Sankaran > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c |

Re: [Freedreno] [DPU PATCH] drm/msm/dpu: Clean up dpu hw interrupts

2018-12-14 Thread Jordan Crouse
On Fri, Dec 14, 2018 at 02:19:12PM +0530, Jayant Shekhar wrote: > Remove unused functions and macros from dpu hw interrupts > file. > > Signed-off-by: Jayant Shekhar > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 30 > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interr

Re: [Freedreno] [PATCH v3 3/3] drm/msm/dpu: add display port support in DPU

2018-12-14 Thread Jordan Crouse
On Thu, Dec 13, 2018 at 10:51:04AM -0800, Jeykumar Sankaran wrote: > Add display port support in DPU by creating hooks > for DP encoder enumeration and encoder mode > initialization. > > This change is based on the SDM845 Display port > driver changes[1]. > > changes in v2: > - rebase on [2

Re: [Freedreno] [PATCH v3 3/3] drm/msm/dpu: add display port support in DPU

2018-12-14 Thread Sean Paul
On Thu, Dec 13, 2018 at 10:51:04AM -0800, Jeykumar Sankaran wrote: > Add display port support in DPU by creating hooks > for DP encoder enumeration and encoder mode > initialization. > > This change is based on the SDM845 Display port > driver changes[1]. > > changes in v2: > - rebase on [2

Re: [Freedreno] [PATCH v3 2/3] drm/msm/dpu: handle failures while initializing displays

2018-12-14 Thread Sean Paul
On Thu, Dec 13, 2018 at 10:51:03AM -0800, Jeykumar Sankaran wrote: > Bail out KMS hw init on display initialization failures with > proper error logging. > > changes in v3: > - introduced in the series > > Signed-off-by: Jeykumar Sankaran > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c |

Re: [Freedreno] [PATCH v2 0/6] DPU resource manager cleanup

2018-12-14 Thread Sean Paul
On Fri, Dec 07, 2018 at 06:38:32PM -0800, Jeykumar Sankaran wrote: > First set of clean up patches for DPU resource manager. > Removes/realigns some of the redudant RM interfaces. > Eventual plan is to migrate resource maintenence using > private state objects. > > Thanks and Regards, > Jeykumar

Re: [Freedreno] [PATCH v4 4/5] drm/msm: clean up display thread

2018-12-14 Thread Sean Paul
On Thu, Dec 06, 2018 at 06:41:43PM -0800, Jeykumar Sankaran wrote: > Since there are no clients using these threads, > cleaning it up. > > changes in v2: > - switch all the dependent clients to use system wq > before removing the disp_threads (Sean Paul) > changes in v3: > - no

[Freedreno] [DPU PATCH] drm/msm/dpu: Clean up dpu hw interrupts

2018-12-14 Thread Jayant Shekhar
Remove unused functions and macros from dpu hw interrupts file. Signed-off-by: Jayant Shekhar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 30 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 34 --- 2 files changed, 64 deletions(-) diff --