Re: [Freedreno] [PATCH] drm/msm: fix handling of cmdstream offset

2018-10-16 Thread Kristian Høgsberg
On Mon, Oct 15, 2018 at 10:33 AM Rob Clark wrote: > > Userspace hasn't used submit cmds with submit_offset != 0 for a while, > but this starts cropping up again with cmdstream sub-buffer-allocation > in libdrm_freedreno. > > Doesn't do much good to increment the buf ptr before assigning it. Revie

Re: [Freedreno] [PATCH] drm/msm: dpu: Don't set legacy plane->crtc pointer

2018-10-16 Thread Sean Paul
On Tue, Oct 16, 2018 at 12:44 PM Daniel Vetter wrote: > > On Tue, Oct 16, 2018 at 11:52:45AM -0400, Sean Paul wrote: > > From: Sean Paul > > > > It causes a WARN in drm_atomic_get_plane_state(), and is not used by > > atomic (or dpu). > > > > Signed-off-by: Sean Paul > > Reviewed-by: Daniel Vett

Re: [Freedreno] [PATCH] drm/msm: dpu: Don't set legacy plane->crtc pointer

2018-10-16 Thread Daniel Vetter
On Tue, Oct 16, 2018 at 11:52:45AM -0400, Sean Paul wrote: > From: Sean Paul > > It causes a WARN in drm_atomic_get_plane_state(), and is not used by > atomic (or dpu). > > Signed-off-by: Sean Paul Reviewed-by: Daniel Vetter I guess leftover from refactoring and upstreaming in parallel? -Dan

[Freedreno] [PATCH] drm/msm: dpu: Don't set legacy plane->crtc pointer

2018-10-16 Thread Sean Paul
From: Sean Paul It causes a WARN in drm_atomic_get_plane_state(), and is not used by atomic (or dpu). Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dp