Re: [Freedreno] [PATCH] drm/msm/adreno/a6xx: Set the GPU frequency after turning on the GMU

2018-08-03 Thread Kristian Høgsberg
On Fri, Aug 3, 2018 at 8:43 PM Rob Clark wrote: > > On Fri, Aug 3, 2018 at 5:06 PM Jordan Crouse wrote: > > > > Set the correct initial GPU frequency on the GMU just after turning on > > or resetting the GMU so it doesn't keep running at a horribly slow > > speed. > > > > Signed-off-by: Jordan Cr

Re: [Freedreno] [PATCH] drm/msm/adreno/a6xx: Set the GPU frequency after turning on the GMU

2018-08-03 Thread Rob Clark
On Fri, Aug 3, 2018 at 5:06 PM Jordan Crouse wrote: > > Set the correct initial GPU frequency on the GMU just after turning on > or resetting the GMU so it doesn't keep running at a horribly slow > speed. > > Signed-off-by: Jordan Crouse *much* better :-) Tested-by: Rob Clark > --- > driver

[Freedreno] [PATCH] drm/msm/adreno/a6xx: Set the GPU frequency after turning on the GMU

2018-08-03 Thread Jordan Crouse
Set the correct initial GPU frequency on the GMU just after turning on or resetting the GMU so it doesn't keep running at a horribly slow speed. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/

Re: [Freedreno] [PATCH] drm/msm/dpu: enable cursor plane on dpu

2018-08-03 Thread Sean Paul
On Thu, Aug 02, 2018 at 04:24:44PM +0530, Sravanthi Kollukuduru wrote: > Reserve DMA pipe for cursor plane and attach it to the > crtc during the initialization. > > Signed-off-by: Sravanthi Kollukuduru Hi Sravanthi, Thanks for sending this. I have a few comments, mostly based off my own cursor

[Freedreno] [PATCH] drm/msm/adreno/a6xx: Fix HFI clock votes

2018-08-03 Thread Jordan Crouse
Fix two issues with the GPU clock vote on HFI. First, pick the largest non-zero arc value for the MX rail instead of just the maximum index (which is likely zero on sdm845). Secondly fix a typo that was blowing away the correct vote value in the GMU table. Signed-off-by: Jordan Crouse --- driver

Re: [Freedreno] [PATCH] drm/msm/adreno: Remove VLA usage

2018-08-03 Thread Rob Clark
On Thu, Aug 2, 2018 at 7:24 PM, Kees Cook wrote: > On Fri, Jun 29, 2018 at 2:20 PM, Jordan Crouse wrote: >> On Fri, Jun 29, 2018 at 11:48:18AM -0700, Kees Cook wrote: >>> In the quest to remove all stack VLA usage from the kernel[1], this >>> switches to using a kasprintf()ed buffer. Return paths