Re: [Freedreno] [patch v2] drm/msm/dsi: free first element on error

2017-02-16 Thread Jani Nikula
On Thu, 16 Feb 2017, Rob Clark wrote: > On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter > wrote: >> We're off by one here. We free something that wasn't allocated and we >> don't free msm_host->bus_clks[]. >> >> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") >> Signed-off-by:

Re: [Freedreno] [patch] drm/msm/dsi: free first element on error

2017-02-16 Thread Jani Nikula
On Thu, 16 Feb 2017, walter harms wrote: > Am 16.02.2017 12:53, schrieb Dan Carpenter: >> On Thu, Feb 16, 2017 at 01:27:47PM +0200, Jani Nikula wrote: >>> On Thu, 16 Feb 2017, Dan Carpenter wrote: We want to free msm_host->bus_clks[0] so the > should be >=. Fixes: 6e0eb52eba9e ("dr

Re: [Freedreno] [patch] drm/msm/dsi: free first element on error

2017-02-16 Thread walter harms
Am 16.02.2017 12:53, schrieb Dan Carpenter: > On Thu, Feb 16, 2017 at 01:27:47PM +0200, Jani Nikula wrote: >> On Thu, 16 Feb 2017, Dan Carpenter wrote: >>> We want to free msm_host->bus_clks[0] so the > should be >=. >>> >>> Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") >>> S

Re: [Freedreno] [patch] drm/msm/dsi: free first element on error

2017-02-16 Thread Jani Nikula
On Thu, 16 Feb 2017, Dan Carpenter wrote: > We want to free msm_host->bus_clks[0] so the > should be >=. > > Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c > b/drivers/gpu/drm/msm/dsi/dsi_host.c

Re: [Freedreno] [patch v2] drm/msm/dsi: free first element on error

2017-02-16 Thread Rob Clark
On Thu, Feb 16, 2017 at 7:00 AM, Dan Carpenter wrote: > We're off by one here. We free something that wasn't allocated and we > don't free msm_host->bus_clks[]. > > Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") > Signed-off-by: Dan Carpenter Thanks Reviewed-by: Rob Clark

Re: [Freedreno] [patch] drm/msm/dsi: free first element on error

2017-02-16 Thread Rob Clark
On Thu, Feb 16, 2017 at 7:03 AM, walter harms wrote: > > > Am 16.02.2017 12:53, schrieb Dan Carpenter: >> On Thu, Feb 16, 2017 at 01:27:47PM +0200, Jani Nikula wrote: >>> On Thu, 16 Feb 2017, Dan Carpenter wrote: We want to free msm_host->bus_clks[0] so the > should be >=. Fixes: 6

[Freedreno] [patch v2] drm/msm/dsi: free first element on error

2017-02-16 Thread Dan Carpenter
We're off by one here. We free something that wasn't allocated and we don't free msm_host->bus_clks[]. Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 1fc07

Re: [Freedreno] [patch] drm/msm/dsi: free first element on error

2017-02-16 Thread Dan Carpenter
On Thu, Feb 16, 2017 at 01:27:47PM +0200, Jani Nikula wrote: > On Thu, 16 Feb 2017, Dan Carpenter wrote: > > We want to free msm_host->bus_clks[0] so the > should be >=. > > > > Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") > > Signed-off-by: Dan Carpenter > > > > diff --git a

[Freedreno] [patch] drm/msm/dsi: free first element on error

2017-02-16 Thread Dan Carpenter
We want to free msm_host->bus_clks[0] so the > should be >=. Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 1fc07ce24686..239e79b39a45 100644 --- a/drivers/