[Freeciv-Dev] [bug #22347] helptext_building() -> is_nation_pickable(): assertion '!is_server()' failed

Update of bug #22347 (project freeciv): Status:None => Ready For Test Release: => S2_5, trunk Planned Release: => 2.5.0, 2.6.0 __

[Freeciv-Dev] [bug #22346] assertion '((void *)0) != punitclass->cache.native_tile_extras' failed

Follow-up Comment #1, bug #22346 (project freeciv): Attached fix for bug #22347 would also solve this one. ___ Reply to this item at: ___ Message posté via/par

[Freeciv-Dev] [bug #22347] helptext_building() -> is_nation_pickable(): assertion '!is_server()' failed

Follow-up Comment #2, bug #22347 (project freeciv): See also bug #22346. ___ Reply to this item at: ___ Message posté via/par Gna! http://gna.org/ _

[Freeciv-Dev] [bug #22386] in can_unit_do_activity_targeted_at() [common/unit.c::1018]: assertion 'target != NULL' failed

Update of bug #22386 (project freeciv): Status:None => Ready For Test Planned Release: => 2.6.0 ___ Follow-up Comment #1: Probable fix attach

[Freeciv-Dev] [bug #22390] Musicset option change does not take effect immediately

URL: Summary: Musicset option change does not take effect immediately Project: Freeciv Submitted by: cazfi Submitted on: Thu 24 Jul 2014 11:42:00 AM EEST Category: None Severity

[Freeciv-Dev] [bug #22390] Musicset option change does not take effect immediately

Update of bug #22390 (project freeciv): Category:None => client ___ Reply to this item at: ___ Message sent

[Freeciv-Dev] [bug #22386] in can_unit_do_activity_targeted_at() [common/unit.c::1018]: assertion 'target != NULL' failed

Follow-up Comment #2, bug #22386 (project freeciv): Also Pollution and Fallout cleaning activities are targeted (though their check is the other way around from irrigation/mine - extra *must* exist to be removed) Are they similarly affected? __

[Freeciv-Dev] [patch #4968] Infracache to calculate value of extras, and not separately for roads and bases

Follow-up Comment #1, patch #4968 (project freeciv): - Handle conflicting extras correctly when calculating value of extra addition (like base evaluation used to do) (file #21535) ___ Additional Item Attachment: File name: InfraExtra-2.pat

[Freeciv-Dev] [bug #22391] Crash in do_paradrop()

URL: Summary: Crash in do_paradrop() Project: Freeciv Submitted by: pepeto Submitted on: jeu. 24 juil. 2014 12:47:25 CEST Category: general Severity: 3 - Normal

[Freeciv-Dev] [patch #4982] Better transporter_for_unit()

URL: Summary: Better transporter_for_unit() Project: Freeciv Submitted by: pepeto Submitted on: jeu. 24 juil. 2014 12:51:47 CEST Category: general Priority: 5 - Normal

[Freeciv-Dev] [bug #22386] in can_unit_do_activity_targeted_at() [common/unit.c::1018]: assertion 'target != NULL' failed

Follow-up Comment #3, bug #22386 (project freeciv): It seems you have done the check in patch #4086. I don't get any error messages for pollution nor nuclear fallout. ___ Reply to this item at:

[Freeciv-Dev] [bug #22216] trunk server crashes in execute_orders()

Follow-up Comment #3, bug #22216 (project freeciv): Fixed typo for bug #21143. (file #21540) ___ Additional Item Attachment: File name: load_S2_5_unit_orders.patchSize:0 KB ___

[Freeciv-Dev] [bug #22364] Pre-2.3 savegame causing network warnings about too great values to a data type

Update of bug #22364 (project freeciv): Category:None => general Status:None => Ready For Test Planned Release: => 2.4.3, 2.5.0-beta2, 2.6.0

[Freeciv-Dev] [patch #4983] Introduce the UnitState requirement type with the test Transported

URL: Summary: Introduce the UnitState requirement type with the test Transported Project: Freeciv Submitted by: sveinung Submitted on: Thu 24 Jul 2014 12:45:53 PM UTC Category: None

[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks

Follow-up Comment #2, bug #22381 (project freeciv): _ For the source tile in unit_attack_unit_at_tile_result(), changing to can_exist_at_tile() would be better._ Another benefit of testing for can exist is that it becomes consistent with spy actions. __

[Freeciv-Dev] [patch #4894] Add the new test TransportDependent to the UnitState requirement type

Update of patch #4894 (project freeciv): Summary: UnitState requirement type with the test TransportDependent => Add the new test TransportDependent to the UnitState requirement type ___ Follow-up Comment #3: Update to app

[Freeciv-Dev] [patch #4683] Make the "Marines" and "AttFromNonNative" flags action neutral

Update of patch #4683 (project freeciv): Status: Wont Do => In Progress Open/Closed: Closed => Open ___ Follow-up Comment #3: _It seems a logica

[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks

Follow-up Comment #3, bug #22381 (project freeciv): That the source tile isn't checking can_exist_at_tile() now is an oversight (and a bug). I'm unsure of the right solution for the destination tile though. Should the source bug just be fixed, and we can discuss the destination more? Should can

[Freeciv-Dev] [patch #4984] What destination tiles should a non AttackNonNative be able to attack?

URL: Summary: What destination tiles should a non AttackNonNative be able to attack? Project: Freeciv Submitted by: sveinung Submitted on: Thu 24 Jul 2014 01:18:40 PM UTC Category: None

[Freeciv-Dev] [patch #4984] What destination tiles should a non AttackNonNative be able to attack?

Follow-up Comment #1, patch #4984 (project freeciv): * The current limit is that the tile must have a native terrain type or be native from an extra. * Should a city where the unit could exist make it native? _Is there a narrative reason UTYF_TRIREME units should not attack unsafe terrains?_ A po

[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks

Follow-up Comment #4, bug #22381 (project freeciv): _Should the source bug just be fixed, and we can discuss the destination more?_ I think that is a good idea. I raised patch #4984 for discussing that issue. I could start working on this bug today (unless you already have started). _As for cons

[Freeciv-Dev] [bug #22381] Inconsistent nativity limits on source tile for regular attacks

Update of bug #22381 (project freeciv): Status: In Progress => None Assigned to:sveinung => None ___ Follow-up Comment #6: I wrote the source

[Freeciv-Dev] [patch #4985] Path-finding better attack handling

URL: Summary: Path-finding better attack handling Project: Freeciv Submitted by: pepeto Submitted on: jeu. 24 juil. 2014 16:07:28 CEST Category: ai Priority: 5 - Normal

[Freeciv-Dev] [patch #4985] Path-finding better attack handling

Follow-up Comment #2, patch #4985 (project freeciv): I have thought about that and based by first version of the patch on it. But the process is very different. In combat.c, we test unit/unit (duplicating lot of useless tests) with full data. In path-finding, we want to know (1) if we are able to

[Freeciv-Dev] [bug #22187] Client allows attempted violation of embarks/disembarks restrictions

Update of bug #22187 (project freeciv): Assigned to: pepeto => None ___ Follow-up Comment #12: I won't do that for S2_5. ___ Reply

[Freeciv-Dev] [bug #22392] 1: in is_native_to_class() [movement.c::301]: assertion '((void *)0) != punitclass->cache.native_tile_bases' failed.

URL: Summary: 1: in is_native_to_class() [movement.c::301]: assertion '((void *)0) != punitclass->cache.native_tile_bases' failed. Project: Freeciv Submitted by: pepeto Submitted on: jeu. 24 juil. 2014 20:35:3

[Freeciv-Dev] [bug #22392] 1: in is_native_to_class() [movement.c::301]: assertion '((void *)0) != punitclass->cache.native_tile_bases' failed.

Update of bug #22392 (project freeciv): Status:None => Ready For Test Operating System:None => Any Planned Release: => 2.4.3 __

[Freeciv-Dev] [bug #22393] 1: in begin_phase() [srv_main.c::1028]: assertion 'ptrans != ((void *)0)' failed.

Follow-up Comment #1, bug #22393 (project freeciv): Looks like its cause by land barbarians in the ocean. Attaching savegame with barbarians in ocean. Started with a a set gameseed and mapseed so reproducable: /ruleset classic /set minplayers 0 /set timeout -1 /set saveturns 100 /set alliedvicto

[Freeciv-Dev] [bug #22393] 1: in begin_phase() [srv_main.c::1028]: assertion 'ptrans != ((void *)0)' failed.

Follow-up Comment #2, bug #22393 (project freeciv): Do the second patch in patch ##4973 solve your issue? ___ Reply to this item at: ___ Message posté via/par G

[Freeciv-Dev] [bug #22393] 1: in begin_phase() [srv_main.c::1028]: assertion 'ptrans != ((void *)0)' failed.

Follow-up Comment #3, bug #22393 (project freeciv): _Do the second patch in patch ##4973 solve your issue?_ Yes. ___ Reply to this item at: ___ Message sent via/

[Freeciv-Dev] [patch #4977] Add meta knowledge for the building (improvement) requirement type.

Update of patch #4977 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at: