Re: [Freeciv-Dev] (PR#39637) Typo in server/cityturn.c

2007-08-30 Thread Egor Vyscrebentsov
http://bugs.freeciv.org/Ticket/Display.html?id=39637 > On Thu, 30 Aug 2007 Joan Creus wrote: > The variable name has sneaked into the string, I think. It says "pimprove > sold!" when it should be "improvement sold". See diff. Didn't it was decided that we need to use word 'building' instead of

Re: [Freeciv-Dev] (PR#39545) [Patch] Up to date freeciv.spec.in

2007-08-30 Thread Egor Vyscrebentsov
http://bugs.freeciv.org/Ticket/Display.html?id=39545 > On Wed, 29 Aug 2007 Marko Lindqvist wrote: > On 29/08/2007, Egor Vyscrebentsov wrote: > > > > PS. It seems to me that we may move away from alternatives, assuming > > that civclient is always gui-gtk-2.0 client. However, I had some > > thoug

[Freeciv-Dev] (PR#39641) [Patch] Use default metamessage from start

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39641 > Automatic metamessage is set (and sent) to metaserver only after first player is actually connected server. Attached patch fixes this. For trunk, S2_1 and S2_0. - ML diff -Nurd -X.diff_ignore freeciv/server/srv_main.c freeciv/server/srv

Re: [Freeciv-Dev] (PR#17982) units that obsolete each other

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=17982 > On 23/06/2006, Billy Naylor <[EMAIL PROTECTED]> wrote: > > using revision 12030 of freeciv 2.1.0 > > a broken rndCIv ruleset had Ballista & Catapult obsolete each other, > which meant the client froze when the first city was created. > > this

[Freeciv-Dev] (PR#39640) [rulesets] Norman nation

2007-08-30 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39640 > Norman nation, written by me, flag by Wikimedia Commons' User:Andersersej. See also http://forum.freeciv.org/viewtopic.php?t=2273&start=90 ~Daniel <> norman.ruleset Description: Binary data ___

[Freeciv-Dev] (PR#12165) Tileset tag memory leak

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=12165 > Subject: duplicate tileset tags cause a memory leak Date: Mon, 07 Feb 2005 20:50:17 -0500 To: The default queue From: Jason Dorje Short This is in 2.0 and 2.0.99. The code is in tilespec.c: for (k = 0; k < num_tags; k++) { (void) hash_repl

Re: [Freeciv-Dev] (PR#39630) Typos in several nation rulesets

2007-08-30 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39630 > On 8/30/07, Joan Creus <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39630 > > > > This transaction appears to have no content > > Several typos I have found in the ottoman, colombian, westphalian, malian, > by

Re: [Freeciv-Dev] (PR#39638) Non i18n'd string in client/helpdata.c

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39638 > On 31/08/2007, Daniel Markstedt <[EMAIL PROTECTED]> wrote: > > > The sentence produced by this string is awful even in its raw English form: > > * Each worked tile that gives more than 2 All will suffer a -1 > penalty when not celebrating. >

Re: [Freeciv-Dev] (PR#39638) Non i18n'd string in client/helpdata.c

2007-08-30 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39638 > On 8/31/07, Joan Creus <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39638 > > > > In client/helpdata.c, line 1253 (revision 13433) (within > helptext_government()) the output variable is assigned "All", withou

Re: [Freeciv-Dev] (PR#39634) [Bug] Magic ruleset crash in maybe_make_contact() -> unit_owner()

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39634 > On 30/08/2007, Pepeto _ <[EMAIL PROTECTED]> wrote: > > I looked at the code it seems it's not what I described. But I think > it's something linked to this. BUT, I found a bad code line in this code > which must be changed: > wakeup_neighbo

[Freeciv-Dev] (PR#39639) [Patch] Fix attribute chunk delta problems

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39639 > Attribute chunk packet has constant size data block. If there is not that much usable data, delta code has been working with somewhat random data. This has caused extra traffic at least. Attached patch fills unused portion of data block wit

Re: [Freeciv-Dev] (PR#39627) [Bug] assert fail when taking player

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39627 > On 30/08/2007, Pepeto _ <[EMAIL PROTECTED]> wrote: > > > [EMAIL PROTECTED] - Mar. Aoû. 28 22:55:36 2007]: > > > > On 29/08/07, Michael Kaufman <[EMAIL PROTECTED]> wrote: > > > > > > The last time I checked, not doing a client reset on player

Re: [Freeciv-Dev] (PR#39627) [Bug] assert fail when taking player

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39627 > On 29/08/2007, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > On 29/08/07, Michael Kaufman <[EMAIL PROTECTED]> wrote: > > > > The last time I checked, not doing a client reset on player switch caused > > bad things to happen, but I can't be mor

[Freeciv-Dev] (PR#39627) [Bug] assert fail when taking player

2007-08-30 Thread Pepeto _
http://bugs.freeciv.org/Ticket/Display.html?id=39627 > > [EMAIL PROTECTED] - Mar. Aoû. 28 22:55:36 2007]: > > On 29/08/07, Michael Kaufman <[EMAIL PROTECTED]> wrote: > > > > The last time I checked, not doing a client reset on player switch caused > > bad things to happen, but I can't be more sp

[Freeciv-Dev] (PR#39637) Typo in server/cityturn.c

2007-08-30 Thread Joan Creus
http://bugs.freeciv.org/Ticket/Display.html?id=39637 > This transaction appears to have no content The variable name has sneaked into the string, I think. It says "pimprove sold!" when it should be "improvement sold". See diff. Cheers, Joan The variable name has sneaked into the string, I think

[Freeciv-Dev] (PR#39638) Non i18n'd string in client/helpdata.c

2007-08-30 Thread Joan Creus
http://bugs.freeciv.org/Ticket/Display.html?id=39638 > In client/helpdata.c, line 1253 (revision 13433) (within helptext_government()) the output variable is assigned "All", without the _( const char *output = "All"; As far as I've seen, in the default ruleset, this string only appears on th

[Freeciv-Dev] (PR#39634) [Bug] Magic ruleset crash in maybe_make_contact() -> unit_owner()

2007-08-30 Thread Pepeto _
http://bugs.freeciv.org/Ticket/Display.html?id=39634 > Why this 'open' state is always by default when we post response, so annoying, sorry :( ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39634) [Bug] Magic ruleset crash in maybe_make_contact() -> unit_owner()

2007-08-30 Thread Pepeto _
http://bugs.freeciv.org/Ticket/Display.html?id=39634 > > [pepeto - Jeu. Aoû. 30 15:56:42 2007]: > > I think you you ran the server with autoauttack on? I already observed > this crash on warserver 0.8.13d when I hosted them. I reported this > crash to Yaro, but his forum is no available since he

[Freeciv-Dev] (PR#39634) [Bug] Magic ruleset crash in maybe_make_contact() -> unit_owner()

2007-08-30 Thread Pepeto _
http://bugs.freeciv.org/Ticket/Display.html?id=39634 > I think you you ran the server with autoauttack on? I already observed this crash on warserver 0.8.13d when I hosted them. I reported this crash to Yaro, but his forum is no available since he left from Freeciv. But I found the revision he f

[Freeciv-Dev] (PR#39636) [Patch] Fix failing vision assert

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39636 > Assert fails when updating unit causes it to have smaller vision range. Consistency between vision layers is being checked in wrong place - when we are in the middle of the process updating them one by one. Attached patch removes assert af

[Freeciv-Dev] (PR#39635) [Patch] Silence S2_1 "bad unit type ... fstk" -error messages

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39635 > There are many legitimate reasons why fstk is called with unit type it cannot handle (with custom rulesets at least). In these cases it simply fails to find target, which is handled in a sane way. There is real problem in that AI is not usi

[Freeciv-Dev] (PR#39634) [Bug] Magic ruleset crash in maybe_make_contact() -> unit_owner()

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39634 > Server crash in S2_1 using magic ruleset. Cannot reproduce. Program received signal SIGSEGV, Segmentation fault. unit_owner (punit=0x0125a001) at ../../src.patched/common/unit.c:1100 1100{ (gdb) bt full #0 unit_owner (punit=0x

Re: [Freeciv-Dev] (PR#4712) Version strings for svn versions

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=4712 > On 14/08/2007, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > > Attached patch adds target fc_svnrev_gen.h to common/Makefile. At > this point this file is not used (included) anywhere, and it is not > dependency for anything (it will be built

[Freeciv-Dev] (PR#39633) [Patch] Add new 3rd party programs to lists of src-check scripts

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39633 > This silences src-check errors about some more 3rd party sources. For S2_1 and trunk. Remaining errors should be fixed (or if there is legitimate reason, silenced) - ML diff -Nurd -X.diff_ignore freeciv/tests/copyright.sh freeciv/tests

Re: [Freeciv-Dev] (PR#39632) [Patch] Remove CVS references from docs

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39632 > On 30/08/2007, Marko Lindqvist <[EMAIL PROTECTED]> wrote: > > I still found some places where documentation referred Freeciv > version control as CVS. Patch contains also some other minor > corrections applicable for both S2_1 and TRUNK. S

[Freeciv-Dev] (PR#39632) [Patch] Remove CVS references from docs

2007-08-30 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=39632 > I still found some places where documentation referred Freeciv version control as CVS. Patch contains also some other minor corrections applicable for both S2_1 and TRUNK. - ML diff -Nurd -X.diff_ignore freeciv/debian/build.debian freeci

[Freeciv-Dev] (PR#39629) Freeciv SDl/Client Win2000

2007-08-30 Thread Pepeto _
http://bugs.freeciv.org/Ticket/Display.html?id=39629 > I think it's not linked with the SDL client. It's a usual client crash. It should be fixed since revisions 13382 (trunk) and 13384 (2.1) (just after beta 6 release...) in the patch for #18010. This bugs was already reported many times: #1585

[Freeciv-Dev] RE : (PR#39629) Freeciv SDl/Client Win2000

2007-08-30 Thread Champsavoir Nicolas
http://bugs.freeciv.org/Ticket/Display.html?id=39629 > Freeciv Windows SDL Client 2.1.0 beta 6. -Message d'origine- De : Daniel Markstedt [mailto:[EMAIL PROTECTED] Envoyé : mercredi 29 août 2007 23:21 À : Champsavoir Nicolas Objet : Re: [Freeciv-Dev] (PR#39629) Freeciv SDl/Client Win200