Re: [iwn] Review split 3

Committed ,thanks! -adrian On 29 July 2013 11:39, Cedric GROSS wrote: > > >> De : Warren Block [mailto:wbl...@wonkity.com] >> Envoyé : lundi 29 juillet 2013 20:11 >> À : Adrian Chadd >> Cc : Cedric GROSS; freebsd-wireless@freebsd.org >> >> On Mon, 29 Jul 2013, Adrian Chadd wrote: >> >> > Hi! >

RE: [iwn] Review split 3

> De : Warren Block [mailto:wbl...@wonkity.com] > Envoyé : lundi 29 juillet 2013 20:11 > À : Adrian Chadd > Cc : Cedric GROSS; freebsd-wireless@freebsd.org > > On Mon, 29 Jul 2013, Adrian Chadd wrote: > > > Hi! > > > > Cool! ok, the style niggles. > > > > * Your #define IWN_blah needs a TAB bet

Re: [iwn] Review split 3

On Mon, 29 Jul 2013, Adrian Chadd wrote: Hi! Cool! ok, the style niggles. * Your #define IWN_blah needs a TAB between #define and the IWN_blah value. Right now you have spaces. There is whitespace at the end of some of the comment lines also. textproc/igor will find problems like that: i

Re: [iwn] Review split 3

Hi! Cool! ok, the style niggles. * Your #define IWN_blah needs a TAB between #define and the IWN_blah value. Right now you have spaces. * $FreeBSD$ should be after the copyright header, not before * Your new file is missing the standard single-include stuff.. ie #ifndef __IF_IWN_DEVID_H__ #defin

[iwn] Review split 3

Hello, As discuss we Adrian, previous big patch is too heavy for direct application in repo. So I resume splitting modification. Here is split 3. This one create if_iwn_devif.h for storing device ID and subdevice ID for later use. If_iwn.c and If_iwnreg.h modified as needed. Cedric