chuck added a comment.
Overall, it is exciting to see this work being done. I realize the code is in
its early stages and has asserts to help catch "the important" code paths, but
it might be good to remove some of the asserts and have the commands set
standard NVMe errors where appropriate.
grehan requested changes to this revision.
grehan added a comment.
This revision now requires changes to proceed.
Chuck - the review for this is now in https://reviews.freebsd.org/D14022,
where I believe your comments have already been addressed.
REVISION DETAIL
https://reviews.freebsd.org/
chuck added a comment.
@grehan OK. So is the thought that this review be closed and efforts should
focus on https://reviews.freebsd.org/D14022?
REVISION DETAIL
https://reviews.freebsd.org/D13995
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sux2mfgj
grehan added a comment.
Yep, that's correct. The code in the new review is based on this code so it's
really a continuation of the effort.
REVISION DETAIL
https://reviews.freebsd.org/D13995
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sux2mfgj_gmail
grehan commandeered this revision.
grehan edited reviewers, added: sux2mfgj_gmail.com; removed: grehan.
REVISION DETAIL
https://reviews.freebsd.org/D13995
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: grehan, trasz, imp, sux2mfgj_gmail.com
Cc: chuck, sean
grehan abandoned this revision.
grehan added a comment.
Closing this revision - moving to https://reviews.freebsd.org/D14022
REVISION DETAIL
https://reviews.freebsd.org/D13995
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: grehan, trasz, imp, sux2mfgj_
