[Differential] D9904: fix UEFI boot on physical machines

sepherosa_gmail.com accepted this revision. This revision has a positive review. REVISION DETAIL https://reviews.freebsd.org/D9904 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: decui_microsoft.com, imp, jhb, will, kib, delphij, emaste, marcel, honzhan_mi

[Differential] D9686: fix UEFI VM's bootup on Hyper-V (i.e. Hyper-V Generation-2 VM)

sepherosa_gmail.com accepted this revision. sepherosa_gmail.com added a comment. This revision has a positive review. We plan to commit this near the end of this week, if no objection comes. It detects possible errors, and obviously will not make the situation worse than before. REVISION DE

[Differential] [Abandoned] D5291: hyperv/vmbus: Select an IDT vector has lower priority than LAPIC timer and IPIs vectors

sepherosa_gmail.com abandoned this revision. REVISION DETAIL https://reviews.freebsd.org/D5291 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, adrian, delphij, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, royger Cc:

[Differential] [Updated] D5316: hyperv/hn: Add option to bind TX taskqueues to the specified CPU

sepherosa_gmail.com updated the summary for this revision. REVISION DETAIL https://reviews.freebsd.org/D5316 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com,

[Differential] [Commented On] D5316: hyperv/hn: Add option to bind TX taskqueues to the specified CPU

sepherosa_gmail.com added a comment. In https://reviews.freebsd.org/D5316#113452, @howard0su_gmail.com wrote: > I worried so many options just brings headache to the end user without the clearly instruction on how to tune it. Please introduce new option when it is really needed. Maybe it

[Differential] [Request, 5 lines] D5318: hyperv/hn: Free the txdesc buf_ring when the TX ring is destroyed

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION DETAIL https://revie

[Differential] [Request, 2 lines] D5317: hyperv/hn: Enable IP header checksum offloading for WIN8 (WinServ2012)

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION SUMMARY Tested on Wi

[Differential] [Request, 33 lines] D5316: hyperv/hn: Add option to bind TX taskqueues to the specified CPU

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION DETAIL https://revie

[Differential] [Commented On] D5291: hyperv/vmbus: Select an IDT vector has lower priority than LAPIC timer and IPIs vectors

sepherosa_gmail.com added a comment. In https://reviews.freebsd.org/D5291#112900, @royger wrote: > I guess this supersedes https://reviews.freebsd.org/D5254? I would expand the commit message so that it's explicitly stated why the hypervisor vector should have a lower priority. O

[Differential] [Request, 10 lines] D5291: hyperv/vmbus: Select an IDT vector has lower priority than LAPIC timer and IPIs vectors

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added a subscriber: freebsd-virtualization-list. REVISION SUMMARY Better and simple solution is to do the

[Differential] [Request, 76 lines] D5290: hyperv/hn: Use buf_ring for txdesc list

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION SUMMARY So one spinl

[Differential] [Request, 612 lines] D5283: hyperv/hn: Split TX ring data structure out of softc

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION SUMMARY This paves t

[Differential] [Request, 4 lines] D5282: hyperv/hn: Use non-fast taskqueue for transmission

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION SUMMARY Performance

[Differential] [Commented On] D5276: hyperv/hn: Use taskqueue_enqueue()

sepherosa_gmail.com added a comment. In https://reviews.freebsd.org/D5276#112396, @howard0su_gmail.com wrote: > This change is a noop since two functions are identical. Yeah, that's the purpose of this change! REVISION DETAIL https://reviews.freebsd.org/D5276 EMAIL PREFERENCES

[Differential] [Request, 10 lines] D5276: hyperv/hn: Use taskqueue_enqueue()

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION SUMMARY This also ea

[Differential] [Request, 374 lines] D5275: hyperv/hn: Split RX ring data structure out of softc

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION SUMMARY This paves t

[Differential] [Request, 74 lines] D5274: hyperv/hn: Change global tunable prefix to hw.hn

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION SUMMARY And use SYSC

[Differential] [Request, 7 lines] D5273: hyperv/hn: Always do transmission scheduling.

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION SUMMARY This one giv

[Differential] [Request, 42 lines] D5272: hyperv/hn: Add option to allow sharing TX taskq between hn instances

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION SUMMARY It is off by

[Differential] [Updated, 115 lines] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

sepherosa_gmail.com updated this revision to Diff 13282. sepherosa_gmail.com added a comment. Expand length limitation to 32 bits. Suggested by hselasky. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D5185?vs=13028&id=13282 REVISION DETAIL https://reviews.freebsd.org/D5185 AFFEC

[Differential] [Commented On] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

sepherosa_gmail.com added a comment. In https://reviews.freebsd.org/D5185#110952, @hselasky wrote: > The size of lro_ctrl already changed when the statistics was made 64-bit. Just remember to bump the FreeBSD_version. Might not be possible to MFC. OK, let's wait for others inputs

[Differential] [Commented On] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

sepherosa_gmail.com added inline comments. INLINE COMMENTS sys/netinet/tcp_lro.h:94 My intention here is too keep the size of lro_ctrl unchanged on amd64 (I think there is an implicit 4 bytes padding after lro_mbuf_max :). But I am fine to change them into unsigned int. Does anyone know

[Differential] [Updated, 114 lines] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

sepherosa_gmail.com updated the summary for this revision. sepherosa_gmail.com updated this revision to Diff 13028. sepherosa_gmail.com added a comment. Address gallatin and adrian's concern. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D5185?vs=12995&id=13028 REVISION DETAIL htt

[Differential] [Commented On] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

sepherosa_gmail.com added a comment. I will adjust the patch accordingly. INLINE COMMENTS sys/netinet/tcp_lro.c:655 Sure :) sys/netinet/tcp_lro.c:684 Sounds fine to me. I did the byte limit before (https://reviews.freebsd.org/D4825). But it turns out the ACKs need seperate limit (appen

[Differential] [Commented On] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

sepherosa_gmail.com added inline comments. INLINE COMMENTS sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:455 OK, I will split it out. REVISION DETAIL https://reviews.freebsd.org/D5185 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, n

[Differential] [Updated] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

sepherosa_gmail.com updated the summary for this revision. REVISION DETAIL https://reviews.freebsd.org/D5185 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com,

[Differential] [Request, 117 lines] D5185: tcp/lro: Allow network drivers to set the limit for TCP ACK/data segment aggregation limit

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, gallatin, hselasky, np. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. Herald

[Differential] [Request, 19 lines] D5175: hyperv/hn: Add an option to always do transmission scheduling

sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION SUMMARY It is off by