[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

grehan added a comment. So a comment on this: in general, api's are not added to FreeBSD that don't have base-system clients that use them, or for a good reason. I think this falls into the latter but I'd like to cut it down a bit. - can the get_unrestricted_guest() routine be removed ?

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

grehan added inline comments. INLINE COMMENTS > bhyveload.c:566 > +{ > + return (vm_get_capability(ctx, vcpu, > + VM_CAP_UNRESTRICTED_GUEST, retval)); Minor style(9) - should be an empty line before the rreturn - see the routine above. > bhyveload.c:567 > + return (

[Differential] D14473: userboot: add callbacks to set unrestricted guest mode

grehan accepted this revision. grehan added a comment. You may be able to get away with just the "set" call. Given that all h/w that is supported by bhyve, with the exception of only Nehalem systems, support this, you may want to use just the error from the set call to handle this low-probab

[Differential] D13995: NVMe controller emulator for bhyve.

grehan abandoned this revision. grehan added a comment. Closing this revision - moving to https://reviews.freebsd.org/D14022 REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: grehan, trasz, imp, sux2mfgj_

[Differential] D13995: NVMe controller emulator for bhyve.

grehan commandeered this revision. grehan edited reviewers, added: sux2mfgj_gmail.com; removed: grehan. REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: grehan, trasz, imp, sux2mfgj_gmail.com Cc: chuck, sean

[Differential] D13995: NVMe controller emulator for bhyve.

grehan added a comment. Yep, that's correct. The code in the new review is based on this code so it's really a continuation of the effort. REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sux2mfgj_gmail

[Differential] D13995: NVMe controller emulator for bhyve.

grehan requested changes to this revision. grehan added a comment. This revision now requires changes to proceed. Chuck - the review for this is now in https://reviews.freebsd.org/D14022, where I believe your comments have already been addressed. REVISION DETAIL https://reviews.freebsd.org/

[Differential] D13995: NVMe controller emulator for bhyve.

grehan added a comment. The updated version of this code is at https://reviews.freebsd.org/D14022 I've moved the reviewer/subscriber list over as well. REVISION DETAIL https://reviews.freebsd.org/D13995 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ T

[Differential] D13995: NVMe controller emulator for bhyve.

grehan added a comment. Leon Dang has also been working on NVMe emulation, and his version works with Linux, Windows and UEFI boot. I'll post that code for review since it is a bit more recent and tested. In the meantime, that version can be seen at www.freebsd.org/~grehan/pci_nvme.c (T

[Differential] D10540: vmx: explicit checking for necessary invvpid/invept types

grehan added inline comments. INLINE COMMENTS > ept.c:68 > + (((cap) & INVEPT_REQUIRED_TYPES_MASK) == INVEPT_REQUIRED_TYPES_MASK) > > #define EPT_PWLEVELS4 /* page walk levels */ Might be worth splitting these out into individual tests, since I have a change

[Differential] [Updated] D5473: ATA/ATAPI6 device emulation in bhyve

grehan added a comment. Support for legacy o/s's has driven much of bhyve development. I'm all for this, though I agree there should be some consolidation of code that could be shared between ATA/ATAPI and AHCI. REVISION DETAIL https://reviews.freebsd.org/D5473 EMAIL PREFERENCES https:/