kristof closed this revision.
kristof added a comment.
Herald added subscribers: farrokhi, ae.
Assorted pf VIMAGE fixes have been done, and pf is now usable inside VIMAGE
jails.
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D1309/new/
REVISION DETAIL
https://reviews.freebsd.org/D
On 2 Jul 2018, at 16:17, Kristof Provost wrote:
Hi Jakub,
On 30 Jun 2018, at 17:07, Jakub Chromy wrote:
I've just installed a 11.2-RELEASE guest under bhyve (hypervisor is
11.1-RELEASE)... and I cant use Virtio network interface with PF:
odine:/boot/kernel# /sbin/pfctl -n -f ~/loca
Hi Jakub,
On 30 Jun 2018, at 17:07, Jakub Chromy wrote:
I've just installed a 11.2-RELEASE guest under bhyve (hypervisor is
11.1-RELEASE)... and I cant use Virtio network interface with PF:
odine:/boot/kernel# /sbin/pfctl -n -f ~/local/tmp/pf.work
*pfctl: pfi_get_ifaces: Bad file descriptor*
kristof abandoned this revision.
REVISION DETAIL
https://reviews.freebsd.org/D1944
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kristof, trociny, gnn, zec, rodrigc, glebius, eri, bz, nvass-gmx.com
Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com, farr
kristof commandeered this revision.
kristof edited reviewers, added: nvass-gmx.com; removed: kristof.
kristof added a comment.
I'm commandeering this so it can be closed, because the patch fro bz@
(https://reviews.freebsd.org/D6924) has been included.
REVISION DETAIL
https://reviews.freebsd
kristof added inline comments.
INLINE COMMENTS
sys/netpfil/pf/pf_if.c:130 I don't understand why this is required. Surely if
an ifnet lives in V_ifnet (so, lives in the current vnet) ifp->if_vnet is
always going to be curvnet?
sys/netpfil/pf/pf_if.c:141 Why add curvnet here?
pfi_attach_ifn
kristof added inline comments.
INLINE COMMENTS
sys/netpfil/pf/pf_ioctl.c:325 It's not clear to me why this is done here,
rather than in pf_unload(). The initialisation is done in pf_load() after all.
sys/netpfil/pf/pf_ioctl.c:3725 Don't we still need to do all of this
somewhere?
REVISION DE
