Re: USB2+umass: root mount fails

2009-03-01 Thread Andrew Thompson
On Sun, Mar 01, 2009 at 12:16:20PM -0700, M. Warner Losh wrote: > In message: <20090301190057.gd90...@citylink.fud.org.nz> > Andrew Thompson writes: > : On Mon, Feb 16, 2009 at 01:53:36PM -0800, Marcel Moolenaar wrote: > : > It appears that the root mount isn't serialized with USB disc

Re: USB2+umass: root mount fails

2009-03-01 Thread M. Warner Losh
In message: <20090301190057.gd90...@citylink.fud.org.nz> Andrew Thompson writes: : On Mon, Feb 16, 2009 at 01:53:36PM -0800, Marcel Moolenaar wrote: : > It appears that the root mount isn't serialized with USB discovery : > in the same way it was under USB1. : : It seems that this is

Re: USB2+umass: root mount fails

2009-03-01 Thread Andrew Thompson
On Mon, Feb 16, 2009 at 01:53:36PM -0800, Marcel Moolenaar wrote: > It appears that the root mount isn't serialized with USB discovery > in the same way it was under USB1. It seems that this is not completly resolved with the root mount hold in r188907 as geom may not have tasted the partition tab

Re: USB2+umass: root mount fails

2009-02-21 Thread Andrew Thompson
On Sat, Feb 21, 2009 at 04:08:39PM -0800, Andrew Thompson wrote: > > > Whatever the solution may be (root_mount_hold/root_mount_rel, sync/async > explore, ...), I will commit the patch from http://wiki.freebsd.org/USB > for the moment so people can still boot. Scratch that, I used root_mount_hol

Re: USB2+umass: root mount fails

2009-02-21 Thread Andrew Thompson
Whatever the solution may be (root_mount_hold/root_mount_rel, sync/async explore, ...), I will commit the patch from http://wiki.freebsd.org/USB for the moment so people can still boot. Andrew ___ freebsd-usb@freebsd.org mailing list http://lists.freeb

Re: USB2+umass: root mount fails

2009-02-19 Thread Hans Petter Selasky
Hi Warner, On Thursday 19 February 2009, M. Warner Losh wrote: > In message: <200902190926.42992.hsela...@c2i.net> > > Hans Petter Selasky writes: > : Do you understand why probe and attach is currently partially deferred in > : some drivers? It has to do with the ability to quickly r

Re: USB2+umass: root mount fails

2009-02-19 Thread M. Warner Losh
In message: <200902190926.42992.hsela...@c2i.net> Hans Petter Selasky writes: : Do you understand why probe and attach is currently partially deferred in some : drivers? It has to do with the ability to quickly recover if a device is : suddenly detached when doing multiple sequentia

Re: USB2+umass: root mount fails

2009-02-19 Thread Alfred Perlstein
I really don't understand why it can't be made an option. The cold probe can be done right before mountroot where threads are available. Not doing this deterministically is bad, but forcing slow behavior as the only option seems equally bad. Offering choice seems to be the right solution. -Alfr

Re: USB2+umass: root mount fails

2009-02-19 Thread Hans Petter Selasky
Hi, On Thursday 19 February 2009, Andrew Thompson wrote: > I think its slightly more complex that adding a cold explore task. Cold explore is not possible any more and adds unneccesary complexity to the USB code. USB is dependant on processes/threads/tasks to execute. > Most of the USB2 perip

Re: USB2+umass: root mount fails

2009-02-18 Thread M. Warner Losh
In message: <20090219050200.ga84...@citylink.fud.org.nz> Andrew Thompson writes: : On Tue, Feb 17, 2009 at 08:54:24AM -0700, M. Warner Losh wrote: : > In message: <200902170856.11631.hsela...@c2i.net> : > Hans Petter Selasky writes: : > : On Tuesday 17 February 2009, Marce

Re: USB2+umass: root mount fails

2009-02-18 Thread Andrew Thompson
On Tue, Feb 17, 2009 at 08:54:24AM -0700, M. Warner Losh wrote: > In message: <200902170856.11631.hsela...@c2i.net> > Hans Petter Selasky writes: > : On Tuesday 17 February 2009, Marcel Moolenaar wrote: > : > > But it looks like the old usb code didn't call it either... I think > : >

Re: USB2+umass: root mount fails

2009-02-17 Thread Marcel Moolenaar
On Feb 16, 2009, at 11:56 PM, Hans Petter Selasky wrote: On Tuesday 17 February 2009, Marcel Moolenaar wrote: On Feb 16, 2009, at 6:03 PM, M. Warner Losh wrote: : root_mount_hold() and root_mount_rel() are specifically : designed to inform the mountroot code that it needs to : wait (or that i

Re: USB2+umass: root mount fails

2009-02-17 Thread M. Warner Losh
In message: <200902170856.11631.hsela...@c2i.net> Hans Petter Selasky writes: : On Tuesday 17 February 2009, Marcel Moolenaar wrote: : > On Feb 16, 2009, at 6:03 PM, M. Warner Losh wrote: : > > : root_mount_hold() and root_mount_rel() are specifically : > > : designed to inform the mou

Re: USB2+umass: root mount fails

2009-02-16 Thread Hans Petter Selasky
On Tuesday 17 February 2009, Marcel Moolenaar wrote: > On Feb 16, 2009, at 6:03 PM, M. Warner Losh wrote: > > : root_mount_hold() and root_mount_rel() are specifically > > : designed to inform the mountroot code that it needs to > > : wait (or that it should go ahead and mount root). > > > > But it

Re: USB2+umass: root mount fails

2009-02-16 Thread Marcel Moolenaar
On Feb 16, 2009, at 6:03 PM, M. Warner Losh wrote: : root_mount_hold() and root_mount_rel() are specifically : designed to inform the mountroot code that it needs to : wait (or that it should go ahead and mount root). But it looks like the old usb code didn't call it either... I think old cod

Re: USB2+umass: root mount fails

2009-02-16 Thread M. Warner Losh
In message: <6e9b5ff6-685b-427c-87a7-c95850da5...@mac.com> Marcel Moolenaar writes: : : On Feb 16, 2009, at 4:35 PM, M. Warner Losh wrote: : : > In message: <741faa3b-b91a-4a23-b47f-21141a8d0...@mac.com> : >Marcel Moolenaar writes: : > : : > : On Feb 16, 2009, at 3:13 PM

Re: USB2+umass: root mount fails

2009-02-16 Thread M. Warner Losh
In message: <6e9b5ff6-685b-427c-87a7-c95850da5...@mac.com> Marcel Moolenaar writes: : : On Feb 16, 2009, at 4:35 PM, M. Warner Losh wrote: : : > In message: <741faa3b-b91a-4a23-b47f-21141a8d0...@mac.com> : >Marcel Moolenaar writes: : > : : > : On Feb 16, 2009, at 3:13 PM

Re: USB2+umass: root mount fails

2009-02-16 Thread Marcel Moolenaar
On Feb 16, 2009, at 4:35 PM, M. Warner Losh wrote: In message: <741faa3b-b91a-4a23-b47f-21141a8d0...@mac.com> Marcel Moolenaar writes: : : On Feb 16, 2009, at 3:13 PM, M. Warner Losh wrote: : : > In message: : >Marcel Moolenaar writes: : > : Before I dig into the code,

Re: USB2+umass: root mount fails

2009-02-16 Thread M. Warner Losh
In message: <741faa3b-b91a-4a23-b47f-21141a8d0...@mac.com> Marcel Moolenaar writes: : : On Feb 16, 2009, at 3:13 PM, M. Warner Losh wrote: : : > In message: : >Marcel Moolenaar writes: : > : Before I dig into the code, what's the current status of : > : root mounts on U

Re: USB2+umass: root mount fails

2009-02-16 Thread Marcel Moolenaar
On Feb 16, 2009, at 3:13 PM, M. Warner Losh wrote: In message: Marcel Moolenaar writes: : Before I dig into the code, what's the current status of : root mounts on USB mass storage devices? First, there's a kludge-o-round that is similar to your "sleep 10" that you've added. It l

Re: USB2+umass: root mount fails

2009-02-16 Thread M. Warner Losh
In message: Marcel Moolenaar writes: : Before I dig into the code, what's the current status of : root mounts on USB mass storage devices? First, there's a kludge-o-round that is similar to your "sleep 10" that you've added. It loops waiting for more devices to show up if the desire