Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Simon J. Gerraty
On Tue, 7 May 2013 13:05:07 -0700, Garrett Cooper writes: >A common pattern that I've seen at Isilon and something else that I've >wanted to have for a while is the ability to designate where the top of a >source tree was. This is important and helpful when dealing with source >files that buil

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Simon J. Gerraty
On Tue, 7 May 2013 21:25:37 -0600, Warner Losh writes: >where does MAKEOBJDIRPREFIX come into play? I don't normally use it, it is a handy but rather crude implement. I normally use MAKEOBJDIR='${.CURDIR:S,${SRCTOP},${OBJTOP},}' which gives you a similar - but much neater result than MAKEOBJDI

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-08 Thread Simon J. Gerraty
On Wed, 8 May 2013 15:49:12 -0600, Warner Losh writes: >> MAKEOBJDIR=3D'${.CURDIR:S,${SRCTOP},${OBJTOP},}' >>=20 >> which gives you a similar - but much neater result than >> MAKEOBJDIRPREFIX. > >Isn't that backwards. MAKEOBJDIRPREFIX in today's FreeBSD is much more = >like OBJTOP than what you've

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-08 Thread Simon J. Gerraty
>> Do you mean why not simply use ${MACHINE}.${MACHINE_ARCH} always? >> Encoding both MACHINE and MACHINE_ARCH always is doable, but I avoid = >'.' Actually I only avoid '.' in the captured dirdeps. So ${MACHINE}.${MACHINE_ARCH} in objdir may be ok - will take a look. Dealing with ${MACHINE}.${M

Re: bmake exports disallowed environment variables

2013-06-10 Thread Simon J. Gerraty
Hi Chris, >bmake appears to export ${.MAKE.LEVEL} into the environment, which sh >doesn't support, due to the leading '.'. Normally this is ignored, Yes, though env(1) does allow it. The leading '.' was deliberately chosen to reduce the risk of this being picked up from user environment. That

Re: bmake exports disallowed environment variables

2013-06-10 Thread Simon J. Gerraty
On Mon, 10 Jun 2013 10:59:31 -0600, Warner Losh writes: >Then perhaps you can share the /bin/sh syntax to unset it? No, the point is that this variable is not supposed to be manipulated by sh at all. The name was chosen precisely because it cannot easily be put into the environment. That and it "

Re: Meta mode toolchain bootstrapping [was Re: FreeBSD targets/ out-of-date]

2015-11-12 Thread Simon J. Gerraty
Bryan Drewery wrote: > On 9/3/2015 11:46 AM, Simon J. Gerraty wrote: > > Anyway, bootstrap-toolchain leverages src/Makefile.inc1 to build an > > initial set of tools. It then attempts to use that to build toolchain > > for MACHINE=host which is currently failing becau

Re: Meta mode toolchain bootstrapping [was Re: FreeBSD targets/ out-of-date]

2015-11-13 Thread Simon J. Gerraty
Bryan Drewery wrote: > > WITH_META_FILES should give you improvements already in that regard. > > Yes, it's a step. We'll need cookies in a lot of places too. I wish > WITH_META_MODE had been WITH_META_BUILD or WITH_DIRDEPS_BUILD so I could WITH_DIRDEPS_BUILD would be more accurate. Its not too

Re: Meta mode toolchain bootstrapping [was Re: FreeBSD targets/ out-of-date]

2015-11-13 Thread Simon J. Gerraty
Bryan Drewery wrote: > On 11/13/2015 9:22 AM, Simon J. Gerraty wrote: > > Bryan Drewery wrote: > >>> WITH_META_FILES should give you improvements already in that regard. > >> > >> Yes, it's a step. We'll need cookies in a lot of places too. I wis

Re: 11.0-CURRENT SRC_ENV_CONF file vs. MAKEOBJDIRPREFIX in the file: they do not mix

2015-12-07 Thread Simon J. Gerraty
Mark Millard wrote: > My guess is that it is picking up the > > MAKEOBJDIRPREFIX=/usr/obj/xtoolchain You should use ?= if you want this to work. There are many places in Makefile.inc1 where MAKEOBJDIRPREFIX is tweaked in the environment of a sub-make. By using = above, you break that. _

Re: 11.0-CURRENT SRC_ENV_CONF file vs. MAKEOBJDIRPREFIX in the file: they do not mix

2015-12-07 Thread Simon J. Gerraty
Mark Millard wrote: > >> MAKEOBJDIRPREFIX=/usr/obj/xtoolchain > > > > You should use ?= if you want this to work. > > There are many places in Makefile.inc1 where MAKEOBJDIRPREFIX is tweaked > > in the environment of a sub-make. > > > > By using = above, you break that. > > That presumes that M

Re: if_igb.ko symbolic link generation is still messed up in that it hard wires the path at installkernel time, messing up copying to other places

2017-09-09 Thread Simon J. Gerraty
Mark Millard wrote: > # ls -lTt /media/boot/kernel/if_igb.ko /mnt/boot/kerndb/if_igb.ko > lrwxr-xr-x 1 root wheel 25 Sep 8 22:47:36 2017 /mnt/boot/kerndb/if_igb.ko > -> /mnt/boot/kernel/if_em.ko > lrwxr-xr-x 1 root wheel 68 Sep 6 20:27:20 2017 > /media/boot/kernel/if_igb.ko -> > /usr/ob

Re: svn commit: r363031 - in head: contrib/bmake contrib/bmake/lst.lib contrib/bmake/mk contrib/bmake/mk/sys contrib/bmake/unit-tests usr.bin/bmake (make now broken)

2020-07-08 Thread Simon J. Gerraty via freebsd-toolchain
Mark Millard wrote: > [External Email. Be cautious of content] > > > This seems to have broken doing buildworld buildkernel and > other things using make: Ouch sorry I saw this at one point but couldn't reproduce while trying to work out what it was complaining about. The line numbers did/do n

Re: svn commit: r363031 - in head: contrib/bmake contrib/bmake/lst.lib contrib/bmake/mk contrib/bmake/mk/sys contrib/bmake/unit-tests usr.bin/bmake (make now broken)

2020-07-09 Thread Simon J. Gerraty via freebsd-toolchain
Mark Millard wrote: > > though the one in ports is real issue: > > > > $ make config > > make: "/usr/ports/Mk/bsd.port.mk" line 2096: warning: String comparison > > operator should be either == or != > > make: "/usr/ports/Mk/bsd.port.mk" line 2096: Malformed conditional > > (defined(MAKE_JOBS_NU