[RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Garrett Cooper
Hi, A common pattern that I've seen at Isilon and something else that I've wanted to have for a while is the ability to designate where the top of a source tree was. This is important and helpful when dealing with source files that build upon each other or depend on sources located in other sec

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Xin Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 05/07/13 13:05, Garrett Cooper wrote: > Hi, A common pattern that I've seen at Isilon and something else > that I've wanted to have for a while is the ability to designate > where the top of a source tree was. This is important and helpful > when

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Garrett Cooper
On Tue, May 7, 2013 at 1:12 PM, Xin Li wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 05/07/13 13:05, Garrett Cooper wrote: > > Hi, A common pattern that I've seen at Isilon and something else > > that I've wanted to have for a while is the ability to designate > > where the to

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Brooks Davis
On Tue, May 07, 2013 at 01:05:07PM -0700, Garrett Cooper wrote: > Hi, > A common pattern that I've seen at Isilon and something else that I've > wanted to have for a while is the ability to designate where the top of a > source tree was. This is important and helpful when dealing with source >

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Garrett Cooper
On May 7, 2013, at 1:39 PM, Brooks Davis wrote: > On Tue, May 07, 2013 at 01:05:07PM -0700, Garrett Cooper wrote: >> Hi, >>A common pattern that I've seen at Isilon and something else that I've >> wanted to have for a while is the ability to designate where the top of a >> source tree was. Thi

clang doesn't make temporary files in all instances, causes build races by not using mk*temp(3) in /tmp

2013-05-07 Thread Garrett Cooper
Hi Dimitriy, I ran into the following error when trying to execute make tinderbox with FreeBSD svn head with ATF changes I'm going to push to benno@: cc -O -pipe -DHAVE_CONFIG_H -I/scratch/freebsd/head-svn/gnu/lib/libgomp -I. -I/scratch/freebsd/head-svn/gnu/lib/libgomp/../../../contrib/gccli

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Warner Losh
On May 7, 2013, at 2:46 PM, Garrett Cooper wrote: > On May 7, 2013, at 1:39 PM, Brooks Davis wrote: > >> On Tue, May 07, 2013 at 01:05:07PM -0700, Garrett Cooper wrote: >>> Hi, >>> A common pattern that I've seen at Isilon and something else that I've >>> wanted to have for a while is the abil

Re: clang doesn't make temporary files in all instances, causes build races by not using mk*temp(3) in /tmp

2013-05-07 Thread Garrett Cooper
On Tue, May 7, 2013 at 1:58 PM, Garrett Cooper wrote: > Hi Dimitriy, > I ran into the following error when trying to execute make > tinderbox with FreeBSD svn head with ATF changes I'm going to push to > benno@: > > cc -O -pipe -DHAVE_CONFIG_H > -I/scratch/freebsd/head-svn/gnu/lib/libgomp -I

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Garrett Cooper
On Tue, May 7, 2013 at 2:00 PM, Warner Losh wrote: > > On May 7, 2013, at 2:46 PM, Garrett Cooper wrote: > > > On May 7, 2013, at 1:39 PM, Brooks Davis wrote: > > > >> On Tue, May 07, 2013 at 01:05:07PM -0700, Garrett Cooper wrote: > >>> Hi, > >>> A common pattern that I've seen at Isilon and s

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Simon J. Gerraty
On Tue, 7 May 2013 13:05:07 -0700, Garrett Cooper writes: >A common pattern that I've seen at Isilon and something else that I've >wanted to have for a while is the ability to designate where the top of a >source tree was. This is important and helpful when dealing with source >files that buil

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Warner Losh
On May 7, 2013, at 3:31 PM, Simon J. Gerraty wrote: > > On Tue, 7 May 2013 13:05:07 -0700, Garrett Cooper writes: >> A common pattern that I've seen at Isilon and something else that I've >> wanted to have for a while is the ability to designate where the top of a >> source tree was. This is i

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Garrett Cooper
On Tue, May 7, 2013 at 2:26 PM, Garrett Cooper wrote: > > On Tue, May 7, 2013 at 2:00 PM, Warner Losh wrote: > >> >> On May 7, 2013, at 2:46 PM, Garrett Cooper wrote: >> >> > On May 7, 2013, at 1:39 PM, Brooks Davis wrote: >> > >> >> On Tue, May 07, 2013 at 01:05:07PM -0700, Garrett Cooper wrote

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Warner Losh
On May 7, 2013, at 9:42 PM, Garrett Cooper wrote: > On Tue, May 7, 2013 at 2:26 PM, Garrett Cooper wrote: > > On Tue, May 7, 2013 at 2:00 PM, Warner Losh wrote: > > On May 7, 2013, at 2:46 PM, Garrett Cooper wrote: > > > On May 7, 2013, at 1:39 PM, Brooks Davis wrote: > > > >> On Tue, May 07

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Garrett Cooper
On May 7, 2013, at 10:09 PM, Warner Losh wrote: > > On May 7, 2013, at 9:42 PM, Garrett Cooper wrote: > >> On Tue, May 7, 2013 at 2:26 PM, Garrett Cooper wrote: >> >> On Tue, May 7, 2013 at 2:00 PM, Warner Losh wrote: >> >> On May 7, 2013, at 2:46 PM, Garrett Cooper wrote: >> >>> On May 7,

Re: [RFC] adding a variable to .mk and Makefile.inc1 to point to top of the FreeBSD source tree

2013-05-07 Thread Simon J. Gerraty
On Tue, 7 May 2013 21:25:37 -0600, Warner Losh writes: >where does MAKEOBJDIRPREFIX come into play? I don't normally use it, it is a handy but rather crude implement. I normally use MAKEOBJDIR='${.CURDIR:S,${SRCTOP},${OBJTOP},}' which gives you a similar - but much neater result than MAKEOBJDI