Re: Resurrecting clang external toolchain support in Makefile.inc

2015-02-11 Thread Baptiste Daroussin
On Wed, Feb 11, 2015 at 11:55:17PM -0700, Warner Losh wrote: > > > On Feb 11, 2015, at 7:14 PM, Peter Grehan wrote: > > > > Hi Warner, > > > >> I like this patch better than the one I have. I’m not 100% sure the > >> ‘else’ clause will work > > > > The else for CROSS_BINUTILS_PREFIX ? If so, y

Re: Resurrecting clang external toolchain support in Makefile.inc

2015-02-11 Thread Warner Losh
> On Feb 11, 2015, at 7:14 PM, Peter Grehan wrote: > > Hi Warner, > >> I like this patch better than the one I have. I’m not 100% sure the >> ‘else’ clause will work > > The else for CROSS_BINUTILS_PREFIX ? If so, yes, that appears to work: I'm > building with in-tree binutils. > > Ok for th

Re: Resurrecting clang external toolchain support in Makefile.inc

2015-02-11 Thread Peter Grehan
Hi Warner, I like this patch better than the one I have. I’m not 100% sure the ‘else’ clause will work The else for CROSS_BINUTILS_PREFIX ? If so, yes, that appears to work: I'm building with in-tree binutils. Ok for this to be committed ? later, Peter.

Re: Resurrecting clang external toolchain support in Makefile.inc

2015-02-11 Thread Warner Losh
> On Feb 11, 2015, at 5:02 PM, Peter Grehan wrote: > > Hi Bapt, > >> In my opinion we should track down the last traces of XFLAGS and turn them >> into >> proper XCFLAGS and XCXXFLAGS, the intent was to get rid of XFLAGS because the >> name was confusing. >> >> so instead of adding XFLAGS to

Re: Resurrecting clang external toolchain support in Makefile.inc

2015-02-11 Thread Peter Grehan
Hi Bapt, In my opinion we should track down the last traces of XFLAGS and turn them into proper XCFLAGS and XCXXFLAGS, the intent was to get rid of XFLAGS because the name was confusing. so instead of adding XFLAGS to XC*FLAGS, the XFLAGS should juste be converted into XC*FLAGS directly in my o

Re: Resurrecting clang external toolchain support in Makefile.inc

2015-02-11 Thread Baptiste Daroussin
On Tue, Feb 10, 2015 at 07:50:59PM -0700, Warner Losh wrote: > > > On Feb 10, 2015, at 7:32 PM, Peter Grehan wrote: > > > > Hi toolchain folk, > > > > I've recently tried using the base system clang as an external toolchain > > i.e. > > > > make CROSS_COMPILER_PREFIX=/usr/bin/ buildworld >

Re: Resurrecting clang external toolchain support in Makefile.inc

2015-02-10 Thread Warner Losh
> On Feb 10, 2015, at 7:32 PM, Peter Grehan wrote: > > Hi toolchain folk, > > I've recently tried using the base system clang as an external toolchain i.e. > > make CROSS_COMPILER_PREFIX=/usr/bin/ buildworld > > .. and found that this no longer works after r273755 which split XFLAGS into >