[Differential] [Accepted] D2690: In ypbind, eliminate error: dereferencing type-punned pointer will break strict-aliasing rules

2015-07-14 Thread rodrigc (Craig Rodrigues)
rodrigc accepted this revision. This revision has a positive review. REPOSITORY rS FreeBSD src repository BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D2690 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: araujo, bapt, emaste, dim, rodrigc

[Differential] [Commented On] D2690: In ypbind, eliminate error: dereferencing type-punned pointer will break strict-aliasing rules

2015-06-15 Thread rodrigc (Craig Rodrigues)
rodrigc added a comment. Sorry for the late response. Please address @dim 's comment, if you have not addressed it already. Also, removing the type-alias punned warnings is trickier than the other types of fixes that we have done to clean up the code. For this change, I would feel more comfortab

[Differential] [Request, 22 lines] D2690: In ypbind, eliminate error: dereferencing type-punned pointer will break strict-aliasing rules

2015-05-31 Thread rodrigc (Craig Rodrigues)
rodrigc created this revision. rodrigc added reviewers: araujo, bapt, emaste, dim. rodrigc added a subscriber: freebsd-toolchain. rodrigc set the repository for this revision to rS FreeBSD src repository. Herald added a subscriber: imp. REVISION SUMMARY Without this fix, compiling ypbind with gc

[Differential] [Abandoned] D2305: Fix bootstraping of crunchide

2015-04-17 Thread rodrigc (Craig Rodrigues)
rodrigc abandoned this revision. rodrigc added a comment. Fixed by rS281659 REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, imp, emaste Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailm

[Differential] [Request, 6 lines] D2305: Fix bootstraping of crunchide

2015-04-16 Thread rodrigc (Craig Rodrigues)
rodrigc created this revision. rodrigc added reviewers: emaste, imp. rodrigc added a subscriber: freebsd-toolchain. REVISION SUMMARY When using an external gcc 4.9 toolchain on a FreeBSD 10.1 build host, building of the CURRENT branch failed when trying to build rescue. See this discussio

[Differential] [Closed] D2285: gcc 4.9.1 compilation fixes for aesni

2015-04-16 Thread rodrigc (Craig Rodrigues)
rodrigc closed this revision. rodrigc updated this revision to Diff 4852. rodrigc added a comment. Closed by commit rS281606 (authored by @rodrigc). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2285?vs=4840&id=4852#toc REVISION DETAIL https://reviews.freebsd.org/D2285 AFFECTED FILES

[Differential] [Updated, 36 lines] D2285: gcc 4.9.1 compilation fixes for aesni

2015-04-15 Thread rodrigc (Craig Rodrigues)
rodrigc updated this revision to Diff 4840. rodrigc added a comment. Change to <> CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2285?vs=4825&id=4840 REVISION DETAIL https://reviews.freebsd.org/D2285 AFFECTED FILES sys/crypto/aesni/aesencdec.h sys/crypto/aesni/aesni_ghash.c sy

[Differential] [Updated, 36 lines] D2285: gcc 4.9.1 compilation fixes for aesni

2015-04-14 Thread rodrigc (Craig Rodrigues)
rodrigc updated this revision to Diff 4825. rodrigc added a comment. OK, here's an updated diff where things are separate out into a different header file. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2285?vs=4798&id=4825 REVISION DETAIL https://reviews.freebsd.org/D2285 AFFECTED

[Differential] [Request, 16 lines] D2285: gcc 4.9.1 compilation fixes for aesni

2015-04-12 Thread rodrigc (Craig Rodrigues)
rodrigc created this revision. rodrigc added a reviewer: jmg. rodrigc added a subscriber: freebsd-toolchain. REVISION SUMMARY In the version of gcc in the FreeBSD tree, this modification was made to the compiler: https://svnweb.freebsd.org/base?view=revision&revision=r242182 #if __STDC

[Differential] [Closed] D1722: Add -s option to config

2015-03-31 Thread rodrigc (Craig Rodrigues)
rodrigc closed this revision. rodrigc added a comment. Committed under rS277904 REVISION DETAIL https://reviews.freebsd.org/D1722 To: rodrigc, brooks, imp Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/m

[Differential] [Accepted] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

2015-03-31 Thread rodrigc (Craig Rodrigues)
rodrigc accepted this revision. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D2187 To: dim, bapt, emaste, imp, rodrigc Cc: emaste, imp, freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/li

[Differential] [Request, 27 lines] D1722: Add -s option to config

2015-01-29 Thread rodrigc (Craig Rodrigues)
rodrigc created this revision. rodrigc added reviewers: brooks, imp. rodrigc added a subscriber: freebsd-toolchain. REVISION SUMMARY This option allows for specifying the directory to use as the location for configuration source files. This option was ported from NetBSD. Submitted by: St