[Differential] [Accepted] D3175: ar: add -U (unique) option to disable -D (deterministic) mode

imp accepted this revision. imp added a reviewer: imp. This revision has a positive review. REVISION DETAIL https://reviews.freebsd.org/D3175 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks, bapt, imp Cc: freebsd-toolchain-list __

[Differential] [Requested Changes To] D1932: Remove the non-standard CC alias for c++

imp requested changes to this revision. imp added a reviewer: imp. imp added a comment. This revision now requires changes to proceed. So "it is icky" likely isn't a good enough reason. Do a ports run w/o it causing any problems and prove me wrong... REPOSITORY rS FreeBSD src repository REVI

[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

imp added a comment. CC has been an alias for the default C++ compiler the entire life FreeBSD has had a C++ compiler. Sure, it isn't based on any "standards" but it is a very de-facto standard that many ports rely on. FreeBSD isn't the only system to do this. Sun did this for years, as did SGI

[Differential] [Accepted] D2576: Update crunch bootstrapping test

imp accepted this revision. imp added a comment. This revision has a positive review. matches my memory, but I didn't verify the R numbers as correct. I assume Ed did, so I'm good with this in... REVISION DETAIL https://reviews.freebsd.org/D2576 EMAIL PREFERENCES https://reviews.freebsd.or

[Differential] [Accepted] D2408: Add ELF Tool Chain's c++filt to the build

imp added a subscriber: imp. imp accepted this revision. imp added a reviewer: imp. imp added a comment. I came to troll you for TOLO -> YOLO, but brooks beat me to it... REVISION DETAIL https://reviews.freebsd.org/D2408 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpref

[Differential] [Accepted] D2317: readelf: Validate MIPS option header

imp accepted this revision. imp added a comment. This revision is now accepted and ready to land. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D2317 To: emaste, imp Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list

[Differential] [Commented On] D2305: Fix bootstraping of crunchide

imp added inline comments. INLINE COMMENTS Makefile.inc1:1470 RELEASEDIR is detritus, so I removed it in D2313. It hasn't been a thing since FreeBSD 9's rewrite of the release process. REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, imp, emaste Cc: freebsd-toolchain _

[Differential] [Commented On] D2305: Fix bootstraping of crunchide

imp added inline comments. INLINE COMMENTS Makefile.inc1:1476 kgzip is actually old, detritus, so I removed it in D2313. REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, imp, emaste Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.

[Differential] [Updated] D2305: Fix bootstraping of crunchide

imp added a comment. I think that we've stumbled on more stuff we can just kill :) INLINE COMMENTS Makefile.inc1:1469 I'd be inclined to promote it. Makefile.inc1:1470 Can you tell me where in the tree we define RELEASEDIR? Is it still even a thing? Makefile.inc1:1475 I'd love to know w

[Differential] [Accepted] D2302: Add arm64 to universe if binutils is available

imp accepted this revision. imp added a comment. This revision is now accepted and ready to land. I like this... REVISION DETAIL https://reviews.freebsd.org/D2302 To: emaste, andrew, imp Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing

[Differential] [Commented On] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

imp added inline comments. BRANCH /head INLINE COMMENTS Makefile.inc1:416 The OBJCOPY was more my concern. Why do we need it for i386 on amd64 and nor for powerpc on powerpc64? REVISION DETAIL https://reviews.freebsd.org/D2187 To: dim, bapt, emaste, imp, rodrigc Cc: emaste, imp, freebsd-

[Differential] [Accepted] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

imp accepted this revision. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D2187 To: dim, rodrigc, bapt, emaste, imp Cc: emaste, imp, freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listin

[Differential] [Commented On] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

imp added a comment. Where is OBJCOPY defined? BRANCH /head INLINE COMMENTS Makefile.inc1:416 Do we need a similar change for powerpc? Using Xfoo unconditionally is cool. REVISION DETAIL https://reviews.freebsd.org/D2187 To: dim, rodrigc, bapt, imp Cc: imp, freebsd-toolchain ___

[Differential] [Updated] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

imp added a comment. >>! In D2187#7, @bapt wrote: > yup you are right > > This looks ok for me I still would be more confident with @imp reviewing as > well :) Using Xfoo unconditionally is good. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D2187 To: dim, rodrigc, bapt, imp C

[Differential] [Accepted] D2156: Switch to ELF toolchain readelf

imp accepted this revision. imp added a comment. This revision is now accepted and ready to land. Looks good REVISION DETAIL https://reviews.freebsd.org/D2156 To: emaste, imp Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http:/

[Differential] [Accepted] D2003: Do not strip crunched binary; it will be done by install

imp accepted this revision. imp added a comment. This revision is now accepted and ready to land. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D2003 To: emaste, andrew, imp Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mail

[Differential] [Accepted] D1974: Support out-of-tree binutils with in-tree compiler

imp added a subscriber: imp. imp accepted this revision. imp added a reviewer: imp. imp added a comment. looks good to me. I've reviewed this in the past as well... REVISION DETAIL https://reviews.freebsd.org/D1974 To: emaste, bapt, imp Cc: imp, andrew, freebsd-toolchain __

[Differential] [Accepted] D1819: libdwarf: Handle .rel relocations

imp accepted this revision. imp added a reviewer: imp. REVISION DETAIL https://reviews.freebsd.org/D1819 To: emaste, br, rpaulo, gnn, imp Cc: rpaulo, freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/lis

[Differential] [Accepted] D1722: Add -s option to config

imp accepted this revision. imp added a comment. This revision is now accepted and ready to land. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D1722 To: rodrigc, brooks, imp Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mai

[Differential] [Accepted] D1682: Preserve hard & symbolic links when modifying source file

imp accepted this revision. imp added a reviewer: imp. REVISION DETAIL https://reviews.freebsd.org/D1682 To: emaste, rpaulo, imp Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-too

[Differential] [Accepted] D1543: crunchide: Correct 64-bit section header offset

imp accepted this revision. imp added a reviewer: imp. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1543 To: emaste, pfg, imp Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://

[Differential] [Accepted] D1468: Fix the ARM build of compiler-rt

imp accepted this revision. imp added a reviewer: imp. This revision is now accepted and ready to land. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1468 To: andrew, loos, sbruno, rpaulo, ian, dim, imp Cc: freebsd-toolchain ___ freebsd

[Differential] [Accepted] D1341: Set up default shstrtab entries at initialization

imp added a subscriber: imp. imp accepted this revision. imp added a reviewer: imp. imp added a comment. This revision is now accepted and ready to land. I believe this is OK... REVISION DETAIL https://reviews.freebsd.org/D1341 To: emaste, imp Cc: imp, freebsd-toolchain ___

[Differential] [Accepted] D1327: Do not strip all when stripping an explicit symbol

imp added a subscriber: imp. imp accepted this revision. imp added a reviewer: imp. imp added a comment. This revision is now accepted and ready to land. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D1327 To: emaste, imp Cc: imp, freebsd-toolchain _