[Differential] [Request, 2, 362 lines] D3238: Remove old GNU Binutils tools now provided by ELF Tool Chain

emaste created this revision. emaste added reviewers: bapt, brooks, imp. emaste added a subscriber: freebsd-toolchain-list. REVISION SUMMARY Posting for comment, review and testing. REVISION DETAIL https://reviews.freebsd.org/D3238 AFFECTED FILES UPDATING gnu/usr.bin/binutils/Makefile

[Differential] [Request, 25 lines] D3237: Fix ar default deterministic mode for -x

emaste created this revision. emaste added reviewers: jhibbits, bapt, brooks. emaste added subscribers: freebsd-toolchain-list, jhibbits. REVISION SUMMARY Reported by: @jhibbits REVISION DETAIL https://reviews.freebsd.org/D3237 AFFECTED FILES usr.bin/ar/ar.c CHANGE DETAILS diff --git a/

[Differential] [Updated, 3 lines] D3190: ar: enable deterministic mode by default

emaste updated this revision to Diff 7272. emaste added a comment. Add note of -D default in man page. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D3190?vs=7271&id=7272 REVISION DETAIL https://reviews.freebsd.org/D3190 AFFECTED FILES usr.bin/ar/ar.1 usr.bin/ar/ar.c CHANGE DE

[Differential] [Request, 2 lines] D3190: ar: enable deterministic mode by default

emaste created this revision. emaste added reviewers: bapt, brooks. emaste added a subscriber: freebsd-toolchain-list. REVISION SUMMARY Ar cannot handle UIDs with more than 6 digits, and there's little value in storing the mtime, uid, gid and mode anyhow. Turn on deterministic (-D) mode by de

[Differential] [Closed] D2338: readelf: avoid division by zero for files with invalid sh_entsize

This revision was automatically updated to reflect the committed changes. Closed by commit rS285845: readelf: avoid division by zero on section entry size (authored by emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2338?vs=7069&id=7269#toc REPOSITORY rS FreeBSD src repository

[Differential] [Closed] D3175: ar: add -U (unique) option to disable -D (deterministic) mode

This revision was automatically updated to reflect the committed changes. Closed by commit rS285844: ar: add -U (unique) option to disable -D (deterministic) mode (authored by emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D3175?vs=7235&id=7268#toc REPOSITORY rS FreeBSD src rep

[Differential] [Request, 39 lines] D3175: ar: add -U (unique) option to disable -D (deterministic) mode

emaste created this revision. emaste added reviewers: brooks, bapt. emaste added a subscriber: freebsd-toolchain-list. REVISION SUMMARY I'd like to make ar(1) produce deterministic output by default. In order to do so we'll first need an option to turn off deterministic mode. Note that thi

[Differential] [Commented On] D2338: readelf: avoid division by zero for files with invalid sh_entsize

emaste added a comment. Yes - sorry for the delay. I realized I had a newer implementation that factored the divide-by-zero checks into a helper function, and uploaded the new diff a few days ago. REVISION DETAIL https://reviews.freebsd.org/D2338 EMAIL PREFERENCES https://reviews.freebsd

[Differential] [Updated, 62 lines] D2338: readelf: avoid division by zero for files with invalid sh_entsize

emaste updated this revision to Diff 7069. emaste added a comment. This revision now requires review to proceed. Add a `get_ent_count` helper to check for 0 entsize instead of expanding the check inline everywhere. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2338?vs=4930&id=7069 R

[Differential] [Closed] D2933: Significantly speed up ar(1) on UFS file systems

This revision was automatically updated to reflect the committed changes. Closed by commit rS284928: speed up ar(1) on UFS file systems (authored by emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2933?vs=6543&id=6545#toc REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST

[Differential] [Updated, 26 lines] D2933: Significantly speed up ar(1) on UFS file systems

emaste updated this revision to Diff 6543. emaste added a comment. This revision now requires review to proceed. - give full path to file with comment explaining the deadlock avoidance - avoid confusing page mask manipulation and just touch the last byte explicitly CHANGES SINCE LAST UPDATE ht

[Differential] [Request, 20 lines] D2933: Significantly speed up ar(1) on UFS file systems

emaste created this revision. emaste added a reviewer: kib. emaste added subscribers: davide, dim, freebsd-toolchain-list, kib. REVISION SUMMARY Fault in the buffer prior to writing as a workaround for poor performance due to interaction with kernel fs deadlock avoidance code. See the comment p

[Differential] [Commented On] D2887: Allow ELF Tool Chain elfcopy to be installed as objcopy

emaste added a comment. In https://reviews.freebsd.org/D2887#56056, @bapt wrote: > Why not always build elfcopy and just make a hardlink objcopy if > MK_ELFCOPY_AS_OBJCOPY is set? > > That will make elfcopy always available to users That's a possibility, although I think I'd prefer to (eventua

[Differential] [Request, 31 lines] D2887: Allow ELF Tool Chain elfcopy to be installed as objcopy

emaste created this revision. emaste added a reviewer: andrew. emaste added a subscriber: freebsd-toolchain-list. Herald added subscribers: emaste, bdrewery. REVISION SUMMARY ELF Tool Chain elfcopy is nearly a drop-in replacement for GNU objcopy (but does not currently support PE output, needed

[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

emaste added a comment. In https://reviews.freebsd.org/D1932#49686, @imp wrote: > it is a very de-facto standard that many ports rely on. Many ports will choose CC if it exists, but I'm not sure they rely on it. Autoconf and cmake builds will try a list and if they pick c++ next they'll be fi

[Differential] [Accepted] D1932: Remove the non-standard CC alias for c++

emaste accepted this revision. REPOSITORY rS FreeBSD src repository BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1932 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: dim, theraven, emaste Cc: freebsd-toolchain

[Differential] [Closed] D2576: Update crunch bootstrapping test

This revision was automatically updated to reflect the committed changes. Closed by commit rS283108: Update crunch bootstrapping test for recent fixes (authored by emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2576?vs=5456&id=5476#toc REPOSITORY rS FreeBSD src repository REV

[Differential] [Request, 9 lines] D2576: Update crunch bootstrapping test

emaste created this revision. emaste added a reviewer: imp. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY - r277259 crunchide: Correct 64-bit section header offset - r281674 crunchide: always include both 32- and 64-bit ELF support With built-in cross-size support we also

[Differential] [Closed] D2408: Add ELF Tool Chain's c++filt to the build

This revision was automatically updated to reflect the committed changes. Closed by commit rS282285: Add ELF Tool Chain's c++filt to the build (authored by emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2408?vs=5108&id=5123#toc REPOSITORY rS FreeBSD src repository REVISION DE

[Differential] [Commented On] D2408: Add ELF Tool Chain's c++filt to the build

emaste added inline comments. INLINE COMMENTS gnu/usr.bin/cc/Makefile:16 Sigh, this is backwards. Will update to `== "no"` - i.e., build GCC's c++filt in the `WITHOUT_ELFTOOLCHAIN_TOOLS` case. REVISION DETAIL https://reviews.freebsd.org/D2408 EMAIL PREFERENCES https://reviews.freebsd.or

[Differential] [Updated, 26 lines] D2408: Add ELF Tool Chain's c++filt to the build

emaste updated this revision to Diff 5108. emaste added a comment. - prefer ELF Tool Chain's c++filt - exclude from make delete-old - fix typo CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2408?vs=5105&id=5108 REVISION DETAIL https://reviews.freebsd.org/D2408 AFFECTED FILES gnu/

[Differential] [Commented On] D2408: Add ELF Tool Chain's c++filt to the build

emaste added a comment. Oh - we also need either: diff --git a/gnu/usr.bin/cc/Makefile b/gnu/usr.bin/cc/Makefile index abc9876..12ee7f8 100644 --- a/gnu/usr.bin/cc/Makefile +++ b/gnu/usr.bin/cc/Makefile @@ -12,7 +12,10 @@ SUBDIR+= cpp .endif .if ${MK_CXX} != "no" -SUBDIR+= c

[Differential] [Request, 19 lines] D2408: Add ELF Tool Chain's c++filt to the build

emaste created this revision. emaste added a reviewer: brooks. emaste added a subscriber: freebsd-toolchain. REVISION DETAIL https://reviews.freebsd.org/D2408 AFFECTED FILES usr.bin/Makefile usr.bin/cxxfilt/Makefile CHANGE DETAILS diff --git a/usr.bin/cxxfilt/Makefile b/usr.bin/cxxfilt/M

[Differential] [Request, 32 lines] D2338: readelf: avoid division by zero for files with invalid sh_entsize

emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY Variations reported in: https://sourceforge.net/p/elftoolchain/tickets/439 https://sourceforge.net/p/elftoolchain/tickets/444 https://sourceforge.net/p/elftoolchain/tickets/445 https://sourceforg

[Differential] [Closed] D2317: readelf: Validate MIPS option header

emaste closed this revision. emaste added a comment. Committed here: https://sourceforge.net/p/elftoolchain/code/3187, will come into FreeBSD with the next ELF Tool Chain import REVISION DETAIL https://reviews.freebsd.org/D2317 To: emaste, imp Cc: freebsd-toolchain ___

[Differential] [Request, 13 lines] D2317: readelf: Validate MIPS option header

emaste created this revision. emaste added a reviewer: imp. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY Reported by antiAgainst in ELF Tool Chain ticket 442 https://sourceforge.net/p/elftoolchain/tickets/442/ REVISION DETAIL https://reviews.freebsd.org/D2317 AFFECTED FIL

[Differential] [Commented On] D2305: Fix bootstraping of crunchide

emaste added a comment. This review can be abandoned - the original issue is now fixed. We can open another review for a future change to make it unconditional. REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, imp, emaste Cc: freebsd-toolchain

[Differential] [Requested Changes To] D2305: Fix bootstraping of crunchide

emaste requested changes to this revision. emaste added a comment. This revision now requires changes to proceed. `_crunchide` here is still needed for cross-builds (but should be addressed by D2314). `_crunch` in the context not provided in this diff is the one that needs to be updated I update

[Differential] [Updated] D2305: Fix bootstraping of crunchide

emaste added a comment. >>! In D2305#4, @emaste wrote: > I believe @imp suggested we still need it unconditionally when crossbuilding, > and also note that usr.sbin/crunch is added for `${BOOTSTRAPPING} < 114` > in bootstrap-tools. I wonder if we can just promote usr.sbin/crunch to an > unc

[Differential] [Commented On] D2305: Fix bootstraping of crunchide

emaste added inline comments. INLINE COMMENTS Makefile.inc1:1469 I believe @imp suggested we still need it unconditionally when crossbuilding, and also note that usr.sbin/crunch is added for `${BOOTSTRAPPING} < 114` in bootstrap-tools. I wonder if we can just promote usr.sbin/crunch to an

[Differential] [Closed] D2302: Add arm64 to universe if binutils is available

emaste closed this revision. emaste updated this revision to Diff 4865. emaste added a comment. Closed by commit rS281629 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2302?vs=4849&id=4865#toc REVISION DETAIL https://reviews.freebsd.org/D2302 AFFECTED FILES h

[Differential] [Commented On] D2302: Add arm64 to universe if binutils is available

emaste added inline comments. INLINE COMMENTS Makefile:383 Also add ``` universe_epilogue: universe_arm64_skip ``` REVISION DETAIL https://reviews.freebsd.org/D2302 To: emaste, imp, andrew Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.o

[Differential] [Updated, 10 lines] D2302: Add arm64 to universe if binutils is available

emaste updated this revision to Diff 4849. emaste added a comment. Add a message if we skip arm64 because we don't have binutils CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2302?vs=4846&id=4849 REVISION DETAIL https://reviews.freebsd.org/D2302 AFFECTED FILES Makefile To: emast

[Differential] [Commented On] D2302: Add arm64 to universe if binutils is available

emaste added a comment. >>! In D2302#4, @andrew wrote: > Would it be difficult to have a warning if the package is not installed? Perhaps ``` .else @echo ">> arm64 skipped - install aarch64-binutils port or package to buil

[Differential] [Request, 6 lines] D2302: Add arm64 to universe if binutils is available

emaste created this revision. emaste added reviewers: imp, andrew. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY arm64 relies on an external binutils port or package because the in-tree linker from binutils 2.17.50 does not support arm64. Add arm64 to universe if the linker is

[Differential] [Changed Subscribers] D2285: gcc 4.9.1 compilation fixes for aesni

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D2285 To: rodrigc, jmg Cc: emaste, dim, freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsu

[Differential] [Closed] D1524: ar: Disallow directory traversal

emaste closed this revision. emaste added a comment. Author: emaste Date: Thu Apr 9 13:45:17 2015 New Revision: 281311 URL: https://svnweb.freebsd.org/changeset/base/281311 REVISION DETAIL https://reviews.freebsd.org/D1524 To: emaste Cc: freebsd-toolchain _

[Differential] [Accepted] D1524: ar: Disallow directory traversal

emaste accepted this revision. emaste added a reviewer: emaste. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1524 To: emaste Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://l

[Differential] [Accepted] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. LGTM BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D2187 To: dim, rodrigc, imp, bapt, emaste Cc: emaste, imp, freebsd-toolchain ___

[Differential] [Commented On] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

emaste added inline comments. BRANCH /head INLINE COMMENTS Makefile.inc1:416 objcopy is used if you generate standalone debug. REVISION DETAIL https://reviews.freebsd.org/D2187 To: dim, bapt, emaste, imp, rodrigc Cc: emaste, imp, freebsd-toolchain _

[Differential] [Commented On] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

emaste added a comment. >>! In D2187#11, @imp wrote: > Where is OBJCOPY defined? In share/mk/sys.mk, as long as `if !defined(%POSIX)` BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D2187 To: dim, rodrigc, bapt, imp, emaste Cc: emaste, imp, freebsd-toolchain __

[Differential] [Accepted] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

emaste added a subscriber: emaste. emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. Agreed it would be nice to have @imp sign off, but looks good to me. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D2187 To: dim, rodrigc, bapt, imp, emaste

[Differential] [Closed] D2156: Switch to ELF toolchain readelf

emaste closed this revision. emaste updated this revision to Diff 4515. emaste added a comment. Closed by commit rS280859 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2156?vs=4461&id=4515#toc REVISION DETAIL https://reviews.freebsd.org/D2156 AFFECTED FILES h

[Differential] [Commented On] D2156: Switch to ELF toolchain readelf

emaste added a comment. exp-run is here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=198950 REVISION DETAIL https://reviews.freebsd.org/D2156 To: emaste, imp, bapt Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://list

[Differential] [Request, 5 lines] D2156: Switch to ELF toolchain readelf

emaste created this revision. emaste added a reviewer: imp. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY ELF toolchain readelf lacked some functionality at the time other tools (like size, strip, nm, etc.) were switched over to the ELF toolchain versions. This has been addres

[Differential] [Request, 11 lines] D2003: Do not strip crunched binary; it will be done by install

emaste created this revision. emaste added reviewers: andrew, imp. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY In cross-build cases it is possible we won't have a cross-strip during the the rescue build. Binaries are already stripped on install anyhow, so there is no need to

[Differential] [Closed] D1974: Support out-of-tree binutils with in-tree compiler

emaste closed this revision. emaste updated this revision to Diff 3999. emaste added a comment. Closed by commit rS279328 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1974?vs=3998&id=3999#toc REVISION DETAIL https://reviews.freebsd.org/D1974 AFFECTED FILES h

[Differential] [Commented On] D1974: Support out-of-tree binutils with in-tree compiler

emaste added a comment. This supports aarch64 builds by installing the aarch64-binutils port and adding `CROSS_BINUTILS_PREFIX=/usr/local/aarch64-freebsd/bin/` to the make command line. REVISION DETAIL https://reviews.freebsd.org/D1974 To: emaste, bapt Cc: andrew, freebsd-toolchain _

[Differential] [Changed Subscribers] D1974: Support out-of-tree binutils with in-tree compiler

emaste added a subscriber: andrew. REVISION DETAIL https://reviews.freebsd.org/D1974 To: emaste, bapt Cc: andrew, freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscri

[Differential] [Request, 6 lines] D1974: Support out-of-tree binutils with in-tree compiler

emaste created this revision. emaste added a reviewer: bapt. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY Right now `CROSS_BINUTILS_PATH` is honoured only when `XCC` is set, i.e. an out-of-tree compiler. Allow `CROSS_BINUTILS_PATH` to pass through to a -B option also when usi

[Differential] [Closed] D1819: libdwarf: Handle .rel relocations

emaste closed this revision. emaste updated this revision to Diff 3742. emaste added a comment. Closed by commit rS278611 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1819?vs=3741&id=3742#toc REVISION DETAIL https://reviews.freebsd.org/D1819 AFFECTED FILES h

[Differential] [Updated, 81 lines] D1819: libdwarf: Handle .rel relocations

emaste updated this revision to Diff 3741. emaste added a comment. This revision now requires review to proceed. Refactor common parts of .rel and .rela handling, based on feedback about non-obvious size==0 return from _dwarf_get_reloc_size CHANGES SINCE LAST UPDATE https://reviews.freebsd.org

[Differential] [Closed] D1826: libdwarf: Add symbol value when processing .rela relocations

emaste closed this revision. emaste updated this revision to Diff 3740. emaste added a comment. Closed by commit rS278593 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1826?vs=3739&id=3740#toc REVISION DETAIL https://reviews.freebsd.org/D1826 AFFECTED FILES h

[Differential] [Updated, 8 lines] D1826: libdwarf: Add symbol value when processing .rela relocations

emaste updated this revision to Diff 3739. emaste added a comment. This revision now requires review to proceed. explicitly skip _dwarf_write_* if size==0 and add comment explaining that means unknown or non-absolute relocation CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1826?vs=373

[Differential] [Updated] D1819: libdwarf: Handle .rel relocations

emaste added a reviewer: br. REVISION DETAIL https://reviews.freebsd.org/D1819 To: emaste, gnn, rpaulo, br Cc: rpaulo, freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsu

[Differential] [Updated] D1826: libdwarf: Add symbol value when processing .rela relocations

emaste added reviewers: kostikbel, rpaulo. REVISION DETAIL https://reviews.freebsd.org/D1826 To: emaste, kostikbel, rpaulo Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain

[Differential] [Commented On] D1826: libdwarf: Add symbol value when processing .rela relocations

emaste added a comment. See also D1819 REVISION DETAIL https://reviews.freebsd.org/D1826 To: emaste Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send

[Differential] [Request, 6 lines] D1826: libdwarf: Add symbol value when processing .rela relocations

emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY In practice .rela debug relocations often use the the .debug_* sections as the symbol, which has the value 0: ``` Relocation section '.rela.debug_info' at offset 0xd18 contains 205 entries: Offs

[Differential] [Request, 55 lines] D1819: libdwarf: Handle .rel relocations

emaste created this revision. emaste added a reviewer: gnn. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY Some architectures have .rel relocations for debug data, so handle it in addition to .rela. Issue discovered from ctfconvert on un-linked ARM object files. REVISION D

[Differential] [Closed] D1682: Preserve hard & symbolic links when modifying source file

emaste closed this revision. emaste updated this revision to Diff 3500. emaste added a comment. Closed by commit rS277843 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1682?vs=3447&id=3500#toc REVISION DETAIL https://reviews.freebsd.org/D1682 AFFECTED FILES h

[Differential] [Request, 54 lines] D1682: Preserve hard & symbolic links when modifying source file

emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY Strip is often used to modify existing files, rather than creating new files. If the existing file has hard links or is a symbolic link, act as if editing the file in place and preserve the links.

[Differential] [Updated, 55 lines] D1663: elfcopy: Select mode by the end of the program name

emaste retitled this revision from "elfcopy: Consider program name to start after last -" to "elfcopy: Select mode by the end of the program name". emaste updated the summary for this revision. emaste updated this revision to Diff 3418. emaste added a comment. Output a warning if the program name

[Differential] [Updated, 49 lines] D1663: elfcopy: Consider program name to start after last -

emaste updated this revision to Diff 3417. emaste added a comment. This revision now requires review to proceed. Just compare the end of the program name with strip/mcs rather than looking for a dash. This is the way it's done in FreeBSD ar/ranlib already, and allows names like bsdstrip. Also ad

[Differential] [Request, 3 lines] D1663: elfcopy: Consider program name to start after last -

emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY If the program name has a dash in it, consider the name to start after the last dash. We select the mode of operation (elfcopy, mcs, or strip) based on the program name. This improves use of these

[Differential] [Closed] D1543: crunchide: Correct 64-bit section header offset

emaste closed this revision. emaste added a comment. Committed as rS277259 REVISION DETAIL https://reviews.freebsd.org/D1543 To: emaste, pfg, imp Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/li

[Differential] [Updated] D1543: crunchide: Correct 64-bit section header offset

emaste added a reviewer: pfg. REVISION DETAIL https://reviews.freebsd.org/D1543 To: emaste, pfg Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any m

[Differential] [Request, 3 lines] D1543: crunchide: Correct 64-bit section header offset

emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY For 64-bit binaries the Elf_Ehdr e_shoff is at offset 40, not 44. Instead of using an incorrect hardcoded offset, let the compiler figure it out for us with offsetof(). REVISION DETAIL https://revie

[Differential] [Request, 10 lines] D1524: ar: Disallow directory traversal

emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY Set ARCHIVE_EXTRACT_SECURE_SYMLINKS and ARCHIVE_EXTRACT_SECURE_NODOTDOT as in bsdtar to prevent extraction of archive entries whose pathnames contain .. or whose target directory would be altered by a

[Differential] [Closed] D1516: Update aarch64 patch for binutils 2.25

emaste closed this revision. emaste updated this revision to Diff 3160. emaste added a comment. Closed by commit rP376986 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1516?vs=3147&id=3160#toc REVISION DETAIL https://reviews.freebsd.org/D1516 AFFECTED FILES h

[Differential] [Request, 5 lines] D1516: Update aarch64 patch for binutils 2.25

emaste created this revision. emaste added reviewers: bapt, andrew. emaste added a subscriber: freebsd-toolchain. REVISION DETAIL https://reviews.freebsd.org/D1516 AFFECTED FILES devel/aarch64-binutils/Makefile devel/binutils/files/patch-aarch64.diff To: emaste, bapt, andrew Cc: freebsd-to

[Differential] [Commented On] D1505: Enable building libclang_rt (asan, ubsan and profile) for selected arches

emaste added a comment. > Note that I also did not introduce yet another WITH_LIBCLANG_RT knob, This is fine in my opinion; we don't need another knob. REVISION DETAIL https://reviews.freebsd.org/D1505 To: dim, andrew, bapt, imp, emaste Cc: freebsd-toolchain __

[Differential] [Updated] D1505: Enable building libclang_rt (asan, ubsan and profile) for selected arches

emaste added a comment. > Apart from the bit of ugliness in lib/Makefile Perhaps the ugliness needs a comment, at least. Also a BSD.debug.mk entry for `WITH_DEBUG_FILES=yes`? REVISION DETAIL https://reviews.freebsd.org/D1505 To: dim, andrew, bapt, imp, emaste Cc: freebsd-toolchain ___

[Differential] [Changed Subscribers] D1468: Fix the ARM build of compiler-rt

emaste added a subscriber: emaste. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1468 To: andrew, loos, sbruno, rpaulo, ian, dim, imp Cc: emaste, freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/

[Differential] [Commented On] D1446: Add the AArch64 llvm backend

emaste added a comment. I imported this change then merged to my arm64 branch and it looks fine to me. REVISION DETAIL https://reviews.freebsd.org/D1446 To: dim, andrew, emaste Cc: freebsd-toolchain, emaste ___ freebsd-toolchain@freebsd.org mailing l

[Differential] [Commented On] D1446: Add the AArch64 llvm backend

emaste added a comment. >>! In D1446#10, @andrew wrote: > We will also need llvm r92 to build the kernel without using floating > point registers. Can we bring this one directly into HEAD? BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1446 To: andrew, emaste, dim Cc: freeb

[Differential] [Accepted] D1446: Add the AArch64 llvm backend

emaste accepted this revision. This revision is now accepted and ready to land. BRANCH /head INLINE COMMENTS lib/clang/include/AArch64GenAsmMatcher.inc:1 Please unexpand these before checkin. SVN does the expansion on checkout. I'm not sure if they're collapsed on checkin, or stored ve

[Differential] [Changed Subscribers] D1446: Add the AArch64 llvm backend

emaste added a subscriber: freebsd-toolchain. REVISION DETAIL https://reviews.freebsd.org/D1446 To: andrew, emaste, dim Cc: freebsd-toolchain, emaste ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-tool

[Differential] [Closed] D1428: readelf: Handle note types from different operating systems

emaste closed this revision. emaste updated this revision to Diff 3002. emaste added a comment. Closed by commit rS276705 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1428?vs=2980&id=3002#toc REVISION DETAIL https://reviews.freebsd.org/D1428 AFFECTED FILES h

[Differential] [Commented On] D1428: readelf: Handle note types from different operating systems

emaste added a comment. >>! In D1428#6, @rpaulo wrote: > > The Linux note types are Linux specific. Are you saying that FreeBSD reuses > them ? Not quite, just that the note types are vendor-specific and in a namespace specific to the note name (vendor). `NT_PRSTATUS`, `NT_FPREGSET`, and `NT_

[Differential] [Commented On] D1428: readelf: Handle note types from different operating systems

emaste added a comment. >>! In D1428#3, @rpaulo wrote: > This looks odd. Why are we relying on magic numbers instead of > constants/enums like before? Some of the constants in the previous version are Linux-specific, and don't exist in our ELF headers. We could make up our own constants (e.g.

[Differential] [Request, 191 lines] D1428: readelf: Handle note types from different operating systems

emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY Previously elftoolchain readelf(1) only displayed correct names for Linux note types. Upstream elftoolchain ticket #473 https://sourceforge.net/p/elftoolchain/tickets/473/ REVISION DETAIL https://

[Differential] [Closed] D1341: Set up default shstrtab entries at initialization

emaste closed this revision. emaste updated this revision to Diff 2813. emaste added a comment. Closed by commit rS276061 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1341?vs=2791&id=2813#toc REVISION DETAIL https://reviews.freebsd.org/D1341 AFFECTED FILES h

[Differential] [Updated] D1341: Set up default shstrtab entries at initialization

emaste updated the test plan for this revision. REVISION DETAIL https://reviews.freebsd.org/D1341 To: emaste Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscrib

[Differential] [Request, 11 lines] D1341: Set up default shstrtab entries at initialization

emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY If we use -R to remove all sections we still need a .shstrtab (which will itself be the only section entry). Do not wait until the addition of the first non-default entry to create the default ones.

[Differential] [Closed] D1327: Do not strip all when stripping an explicit symbol

emaste closed this revision. emaste updated this revision to Diff 2778. emaste added a comment. Closed by commit rS275862 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1327?vs=2767&id=2778#toc REVISION DETAIL https://reviews.freebsd.org/D1327 AFFECTED FILES h

[Differential] [Request, 3 lines] D1327: Do not strip all when stripping an explicit symbol

emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY When asked to strip a specific symbol (-N) strip still defaulted to STRIP_ALL. In this case binutils defaults to stripping nothing (other than the requested symbol(s), of course), which makes a lot mor

[Differential] [Updated] D1327: Do not strip all when stripping an explicit symbol

emaste updated the summary for this revision. REVISION DETAIL https://reviews.freebsd.org/D1327 To: emaste Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe,