emaste closed this revision.
emaste added a comment.
Committed here: https://sourceforge.net/p/elftoolchain/code/3187, will come
into FreeBSD with the next ELF Tool Chain import
REVISION DETAIL
https://reviews.freebsd.org/D2317
To: emaste, imp
Cc: freebsd-toolchain
___
On Sat, Mar 28, 2015 at 4:05 PM, Craig Rodrigues
wrote:
> Hi,
>
> To work around the problems build rescue, this time I used a build host
> running FreeBSD-CURRENT at svn revision r280353
>
> I took this patch for libc++ and applied it to my tree:
>
> http://reviews.llvm.org/D8461
>
> I used this
rodrigc abandoned this revision.
rodrigc added a comment.
Fixed by rS281659
REVISION DETAIL
https://reviews.freebsd.org/D2305
To: rodrigc, imp, emaste
Cc: freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailm
imp accepted this revision.
imp added a comment.
This revision is now accepted and ready to land.
Looks good to me.
REVISION DETAIL
https://reviews.freebsd.org/D2317
To: emaste, imp
Cc: freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
emaste created this revision.
emaste added a reviewer: imp.
emaste added a subscriber: freebsd-toolchain.
REVISION SUMMARY
Reported by antiAgainst in ELF Tool Chain ticket 442
https://sourceforge.net/p/elftoolchain/tickets/442/
REVISION DETAIL
https://reviews.freebsd.org/D2317
AFFECTED FIL
emaste added a comment.
This review can be abandoned - the original issue is now fixed.
We can open another review for a future change to make it unconditional.
REVISION DETAIL
https://reviews.freebsd.org/D2305
To: rodrigc, imp, emaste
Cc: freebsd-toolchain
imp added inline comments.
INLINE COMMENTS
Makefile.inc1:1470 RELEASEDIR is detritus, so I removed it in D2313. It
hasn't been a thing since FreeBSD 9's rewrite of the release process.
REVISION DETAIL
https://reviews.freebsd.org/D2305
To: rodrigc, imp, emaste
Cc: freebsd-toolchain
_
imp added inline comments.
INLINE COMMENTS
Makefile.inc1:1476 kgzip is actually old, detritus, so I removed it in D2313.
REVISION DETAIL
https://reviews.freebsd.org/D2305
To: rodrigc, imp, emaste
Cc: freebsd-toolchain
___
freebsd-toolchain@freebsd.
emaste requested changes to this revision.
emaste added a comment.
This revision now requires changes to proceed.
`_crunchide` here is still needed for cross-builds (but should be addressed by
D2314).
`_crunch` in the context not provided in this diff is the one that needs to be
updated
I update
imp added a comment.
I think that we've stumbled on more stuff we can just kill :)
INLINE COMMENTS
Makefile.inc1:1469 I'd be inclined to promote it.
Makefile.inc1:1470 Can you tell me where in the tree we define RELEASEDIR? Is
it still even a thing?
Makefile.inc1:1475 I'd love to know w
emaste added a comment.
>>! In D2305#4, @emaste wrote:
> I believe @imp suggested we still need it unconditionally when crossbuilding,
> and also note that usr.sbin/crunch is added for `${BOOTSTRAPPING} < 114`
> in bootstrap-tools. I wonder if we can just promote usr.sbin/crunch to an
> unc
emaste added inline comments.
INLINE COMMENTS
Makefile.inc1:1469 I believe @imp suggested we still need it unconditionally
when crossbuilding, and also note that usr.sbin/crunch is added for
`${BOOTSTRAPPING} < 114` in bootstrap-tools. I wonder if we can just
promote usr.sbin/crunch to an
12 matches
Mail list logo
