[Differential] [Commented On] D2285: gcc 4.9.1 compilation fixes for aesni

2015-04-15 Thread dim (Dimitry Andric)
dim added a comment. LGTM. REVISION DETAIL https://reviews.freebsd.org/D2285 To: rodrigc, jmg Cc: kostikbel, emaste, dim, freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To

[Differential] [Updated, 36 lines] D2285: gcc 4.9.1 compilation fixes for aesni

2015-04-15 Thread rodrigc (Craig Rodrigues)
rodrigc updated this revision to Diff 4840. rodrigc added a comment. Change to <> CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2285?vs=4825&id=4840 REVISION DETAIL https://reviews.freebsd.org/D2285 AFFECTED FILES sys/crypto/aesni/aesencdec.h sys/crypto/aesni/aesni_ghash.c sy

[Differential] [Commented On] D2285: gcc 4.9.1 compilation fixes for aesni

2015-04-15 Thread jmg (John-Mark Gurney)
jmg added a comment. we should either include both w/ quotes or both w/ angle braces… I personally would prefer quotes, but that's me, but I won't object to angle braces. INLINE COMMENTS sys/crypto/aesni/aesencdec.h:30 so it looks like the same directory as the file instead of having to spec