Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Andriy Gapon
on 29/10/2010 17:41 Andriy Gapon said the following: > on 29/10/2010 15:36 Andriy Gapon said the following: >> on 29/10/2010 12:04 Artemiev Igor said the following: >>> Yep, this problem exists. You may workaround it via bumping up >>> net.inet.tcp.sendspace up to 128k. zfs sendfile is very ineffe

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Andriy Gapon
on 29/10/2010 20:51 Artemiev Igor said the following: > On Fri, Oct 29, 2010 at 07:06:03PM +0300, Andriy Gapon wrote: >> Probably yes, but have to be careful there. >> First, do vm_page_grab only for UIO_NOCOPY case. >> Second, the first page is already "shared busy" after vm_page_io_start() >> ca

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Andriy Gapon
on 30/10/2010 11:16 Andriy Gapon said the following: > Or maybe something like the following? > It looks a little bit cleaner to me, but still is not perfect, as I have not > handled unnecessary busy-ing of the pages where something more lightweight > could > have sufficed (e.g. wiring and shared

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Andriy Gapon
on 30/10/2010 11:16 Andriy Gapon said the following: > on 30/10/2010 11:16 Andriy Gapon said the following: >> Or maybe something like the following? >> It looks a little bit cleaner to me, but still is not perfect, as I have not >> handled unnecessary busy-ing of the pages where something more lig

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Andriy Gapon
Heh, next try. Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c === --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c (revision 214318) +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c (

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Artemiev Igor
On Sat, Oct 30, 2010 at 11:25:05AM +0300, Andriy Gapon wrote: > > Note: I have only compile tested the patch. > > Missed one NULL check. > > Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c > === > --- sys/cddl/contr

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Artemiev Igor
On Sat, Oct 30, 2010 at 12:52:54PM +0300, Andriy Gapon wrote: > Heh, next try. Got a panic, "vm_page_unwire: invalid wire count: 0" ___ freebsd-stable@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-stable To unsubscribe, send

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Andriy Gapon
on 30/10/2010 13:12 Artemiev Igor said the following: > On Sat, Oct 30, 2010 at 12:52:54PM +0300, Andriy Gapon wrote: > >> Heh, next try. > > Got a panic, "vm_page_unwire: invalid wire count: 0" Oh, thank you for testing - forgot another piece (VM_ALLOC_WIRE for vm_page_alloc): Index: sys/cddl

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Artemiev Igor
On Sat, Oct 30, 2010 at 01:33:00PM +0300, Andriy Gapon wrote: > on 30/10/2010 13:12 Artemiev Igor said the following: > > On Sat, Oct 30, 2010 at 12:52:54PM +0300, Andriy Gapon wrote: > > > >> Heh, next try. > > > > Got a panic, "vm_page_unwire: invalid wire count: 0" > > Oh, thank you for testi

Re: hast vs ggate+gmirror sychrnoisation speed

2010-10-30 Thread Mikolaj Golub
On Thu, 28 Oct 2010 22:08:54 +0300 Mikolaj Golub wrote to Pawel Jakub Dawidek: PJD>> I looked at the code and the keepalive packets arbe sent from another PJD>> thread. Could you try turning them off in primary.c and see if that PJD>> helps? MG> At first I set RETRY_SLEEP to 1 sec to have mo

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Andriy Gapon
on 30/10/2010 14:25 Artemiev Igor said the following: > On Sat, Oct 30, 2010 at 01:33:00PM +0300, Andriy Gapon wrote: >> on 30/10/2010 13:12 Artemiev Igor said the following: >>> On Sat, Oct 30, 2010 at 12:52:54PM +0300, Andriy Gapon wrote: >>> Heh, next try. >>> >>> Got a panic, "vm_page_unwi

RE: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Alexander Zagrebin
> >> Oh, thank you for testing - forgot another piece > (VM_ALLOC_WIRE for vm_page_alloc): > > > > Yep, it work. But VM_ALLOC_WIRE not exists in RELENG_8, > therefore i slightly modified your patch: > > I apologize for my haste, it should have been VM_ALLOC_WIRED. > Here is a corrected patch: >

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Artemiev Igor
On Sat, Oct 30, 2010 at 05:43:54PM +0300, Andriy Gapon wrote: > I apologize for my haste, it should have been VM_ALLOC_WIRED. Ok, applied and tested under some load(~1200 active connections, outgoing ~80MB/s). Patch work as expected and i has noted no side effects. Just one question - should gro

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Kostik Belousov
On Sat, Oct 30, 2010 at 05:43:54PM +0300, Andriy Gapon wrote: > on 30/10/2010 14:25 Artemiev Igor said the following: > > On Sat, Oct 30, 2010 at 01:33:00PM +0300, Andriy Gapon wrote: > >> on 30/10/2010 13:12 Artemiev Igor said the following: > >>> On Sat, Oct 30, 2010 at 12:52:54PM +0300, Andriy G

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Andriy Gapon
on 31/10/2010 02:37 Kostik Belousov said the following: > On Sat, Oct 30, 2010 at 05:43:54PM +0300, Andriy Gapon wrote: >> on 30/10/2010 14:25 Artemiev Igor said the following: >>> On Sat, Oct 30, 2010 at 01:33:00PM +0300, Andriy Gapon wrote: on 30/10/2010 13:12 Artemiev Igor said the followin

Re: 8.1-STABLE: zfs and sendfile: problem still exists

2010-10-30 Thread Andriy Gapon
on 30/10/2010 22:01 Artemiev Igor said the following: > On Sat, Oct 30, 2010 at 05:43:54PM +0300, Andriy Gapon wrote: > >> I apologize for my haste, it should have been VM_ALLOC_WIRED. > > Ok, applied and tested under some load(~1200 active connections, outgoing > ~80MB/s). Patch work as expected