Anyone else get a chance to review this?
On Fri, Feb 5, 2010 at 8:44 PM, Nick Rogers wrote:
> I applied drbr_altq.diff to the e1000 driver (sys/dev/e1000) from HEAD on
> top of 8.0-RELEASE kernel sources. It appears to have fixed the immediate
> problem where queues simply don't work on em inter
I applied drbr_altq.diff to the e1000 driver (sys/dev/e1000) from HEAD on
top of 8.0-RELEASE kernel sources. It appears to have fixed the immediate
problem where queues simply don't work on em interfaces. Thanks a bunch.
I suppose further review and testing by others would be greatly appreciated
f
Okay ... attached is a patch to fix this for em(4) (and lay the groundwork to
fix it for other drbr_* consumer as well). I have tested it in VirtualBox,
but don't have real hardware to check for non-ALTQ performance or other
regressions.
Test, comments and review appreciated.
--
Max
Index:
Just teseted, and at least in the kernel build I'm doing its definitely
defining
that code on, hit my syntax error rebuilding em.
Jack
On Tue, Feb 2, 2010 at 2:43 PM, Jack Vogel wrote:
> It should never get to the drbr code, look at net/if_var.h, in the inline
> definition
> of drbr_dequeue()
It should never get to the drbr code, look at net/if_var.h, in the inline
definition
of drbr_dequeue() there is an #ifdef ALTQ that will effectively vector if to
use
the old IFQ_DRV_DEQUEUE() method.
I guess I can test the build on a system here, stick some syntax error in
and see if it hits.
Rig
On Tue, Feb 02, 2010 at 01:41:01PM -0800, Jack Vogel wrote:
> LOL, and I can answer my own question, I just looked and the ONLY
> 1Gig drivers using multiqueue are mine, so I guess not eh? :)
>
I was wrong. ALTQ is defined in opt_global.h so drbr_ interface
should already see ALTQ. I have to look
LOL, and I can answer my own question, I just looked and the ONLY
1Gig drivers using multiqueue are mine, so I guess not eh? :)
J.
On Tue, Feb 2, 2010 at 1:39 PM, Jack Vogel wrote:
> Thanks Max, yes, i've done some digging myself and now see how things
> work, the rubber meets the road in the d
Thanks Max, yes, i've done some digging myself and now see how things
work, the rubber meets the road in the defines in if_var.h.
And what it does is effectively short circuit Kip Macy's multiqueue code
in favor of the old method.
Right now I can see two possibilities, either the defines are not
On Tuesday 02 February 2010 18:48:02 Jack Vogel wrote:
> So apparently this thing needs no special knowledge in the driver, yet
> something in
> the new code breaks it, can someone explain tersely how the altq app
> actually
> "pokes" or "hooks up" to the driver? I am not clear about that and I
>
On Tue, Feb 02, 2010 at 09:47:17AM -0800, Nick Rogers wrote:
> On Tue, Feb 2, 2010 at 9:37 AM, Pyun YongHyeon wrote:
>
> > On Tue, Feb 02, 2010 at 09:30:52AM -0800, Nick Rogers wrote:
> > > > I guess the problem comes from multi-queue support. The drbr
> > > > interface is implemented with inline
So apparently this thing needs no special knowledge in the driver, yet
something in
the new code breaks it, can someone explain tersely how the altq app
actually
"pokes" or "hooks up" to the driver? I am not clear about that and I suspect
if I was
this would all be clearer.
Jack
On Tue, Feb 2, 2
On Tue, Feb 2, 2010 at 9:37 AM, Pyun YongHyeon wrote:
> On Tue, Feb 02, 2010 at 09:30:52AM -0800, Nick Rogers wrote:
> > > I guess the problem comes from multi-queue support. The drbr
> > > interface is implemented with inline function so em(4)/igb(4) may
> > > have to define ALTQ to the header.
On Tue, Feb 02, 2010 at 09:30:52AM -0800, Nick Rogers wrote:
> > I guess the problem comes from multi-queue support. The drbr
> > interface is implemented with inline function so em(4)/igb(4) may
> > have to define ALTQ to the header. I have not tested the patch(no
> > time at this moment) but woul
> I guess the problem comes from multi-queue support. The drbr
> interface is implemented with inline function so em(4)/igb(4) may
> have to define ALTQ to the header. I have not tested the patch(no
> time at this moment) but would you give it try?
>
> I tried the patch and it did not work.
___
On Sun, Jan 31, 2010 at 12:37:43AM -0800, Nick Rogers wrote:
> I'm having problems getting PF + ALTQ to work on em(4) interfaces under
> 8.0-RELEASE. Kernel was rebuilt with the additional options necessary for
> ALTQ and what not. Same basic configuration works fine under 7.2-RELEASE.
> Basically,
I'm having problems getting PF + ALTQ to work on em(4) interfaces under
8.0-RELEASE. Kernel was rebuilt with the additional options necessary for
ALTQ and what not. Same basic configuration works fine under 7.2-RELEASE.
Basically, the queues create successfully but running a pfctl -vsq shows a
zero
16 matches
Mail list logo
