koobs added a subscriber: freebsd-python.
REPOSITORY
rP FreeBSD ports repository
REVISION DETAIL
https://reviews.freebsd.org/D2600
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: loader, koobs
Cc: freebsd-python
__
koobs requested changes to this revision.
koobs added a comment.
This revision now requires changes to proceed.
Additional to inline comments, does the port also pass poudriere and portlint
-AC (with DEVELOPER=yes enabled in /etc/make.conf) ?
INLINE COMMENTS
devel/py-pytest-timeout/Makefile:1
koobs accepted this revision.
koobs added a comment.
This revision has a positive review.
Looks good mate!
Are you //able// to commit this? If so, the change is approved.
If not, feel free to either:
1. Assign the Bugzilla issue to me for commit
2. Obtain a ports commit bit (or permission to co
koobs added a comment.
Thanks for the clarity @rodrigc
You look good to commit then @loader, feel free to put your other PR changesets
into Phabricator reviews with me as a reviewer. Ideally we can find another
person to provide an extra pair of eyes
REPOSITORY
rP FreeBSD ports repository
koobs added a comment.
You're welcome, it looks good and congratulations! :)
REPOSITORY
rP FreeBSD ports repository
REVISION DETAIL
https://reviews.freebsd.org/D2600
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: loader, koobs
Cc: rodrigc, freebsd-pyt
koobs closed this revision.
koobs added a comment.
Closing manually, committed in https://reviews.freebsd.org/rP386987, but not
closed here because commit log didn't include:
Differential Revision: https://reviews.freebsd.org/D2600
REPOSITORY
rP FreeBSD ports repository
REVISION DETAIL
