Re: svn commit: r517602 - head/devel/py-mock

2019-11-14 Thread Kubilay Kocak
On 15/11/2019 2:27 pm, Jan Beich wrote: Kubilay Kocak writes: The canonical pytest invocation is: cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts= For a canonical it is uncommon. Besides, you've made mistakes: - No braces around `cd` compared to what Porter's Handbook recommends -

Re: svn commit: r517602 - head/devel/py-mock

2019-11-14 Thread Jan Beich
Kubilay Kocak writes: > The canonical pytest invocation is: > > cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts= For a canonical it is uncommon. Besides, you've made mistakes: - No braces around `cd` compared to what Porter's Handbook recommends - No TEST_ENV in case tests need TZ=UTC,

Re: svn commit: r517602 - head/devel/py-mock

2019-11-14 Thread Kubilay Kocak
On 15/11/2019 4:11 am, Enji Cooper wrote: + @cd ${WRKSRC} && pytest Hi Enji :) Python ports *must* always reference/use *Python-version* specific versions of binaries/scripts/interpreters for *all* invocations of them, as it can never be guaranteed that: a) A/the non-versioned binary