koobs added a comment.
You're welcome, it looks good and congratulations! :)
REPOSITORY
rP FreeBSD ports repository
REVISION DETAIL
https://reviews.freebsd.org/D2600
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: loader, koobs
Cc: rodrigc, freebsd-pyt
loader added a comment.
Hi @koobs @rodrigc,
Thanks so much for your help. I have committed it. r386987
REPOSITORY
rP FreeBSD ports repository
REVISION DETAIL
https://reviews.freebsd.org/D2600
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: loader, koo
koobs added a comment.
Thanks for the clarity @rodrigc
You look good to commit then @loader, feel free to put your other PR changesets
into Phabricator reviews with me as a reviewer. Ideally we can find another
person to provide an extra pair of eyes
REPOSITORY
rP FreeBSD ports repository
rodrigc added a subscriber: rodrigc.
rodrigc added a comment.
@loader: even if you do not have a ports commit bit,
you are allowed to commit to ports if you
put **Approved by:** a ports committer in your commit message.
See:
https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ar
loader added a comment.
Hi Kubilay,
Thanks for your help. I only have the doc commit bit,
would you like to be my port mentor?
I have a few port PRs:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199138
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199698
https://bugs.freebsd.org/bugzill
loader added a comment.
In https://reviews.freebsd.org/D2600#48323, @koobs wrote:
> Additional to inline comments, does the port also pass poudriere and portlint
> -AC (with DEVELOPER=yes enabled in /etc/make.conf) ?
Yes, poudriere log is here:
https://bz-attachments.freebsd.org/attachment.cg
