Re: Attention ports committers

2011-01-22 Thread Sahil Tandon
On Sat, 2011-01-22 at 22:18:49 +0300, Eygene Ryabinkin wrote: > If I am committing something, I am trying to make it as good as I can This is exactly how it should be! > My goal was to create the compact port that will be almost > perfect ;)) Thanks for refusing to commit rubbish into the tree,

Re: Attention ports committers

2011-01-22 Thread Eygene Ryabinkin
Joeb, good day. Wed, Jan 19, 2011 at 11:59:24AM -0500, joeb wrote: > Eygene Ryabinkin you sure missed the point of my post. Your > forensic investigation of my port is far outside the review of the > make file to commit the port. That is my personal opinion as if I would wrote the port myself an

RE: Attention ports committers

2011-01-19 Thread joeb
-Original Message- From: r...@codelabs.ru [mailto:r...@codelabs.ru]On Behalf Of Eygene Ryabinkin Sent: Friday, January 14, 2011 4:46 PM To: joeb Cc: po...@freebsd.org Subject: Re: Attention ports committers Good day. Fri, Jan 14, 2011 at 01:18:52PM -0500, joeb wrote: > I would like

Re: Attention ports committers

2011-01-15 Thread Eygene Ryabinkin
Sat, Jan 15, 2011 at 02:05:40AM -0800, per...@pluto.rain.com wrote: > Eygene Ryabinkin wrote: > > > And please, please, please, try to put your shar(1) archive > > somewhere to the Web and add the link to the PR: mail over > > gnats if not uuencoded properly makes attachments with partial > > quo

Re: Attention ports committers

2011-01-15 Thread perryh
Eygene Ryabinkin wrote: > And please, please, please, try to put your shar(1) archive > somewhere to the Web and add the link to the PR: mail over > gnats if not uuencoded properly makes attachments with partial > quoted-printable stuff left ... Sounds as if Sec. 3.6 of the Porter's Handbook nee

Re: Attention ports committers

2011-01-14 Thread Chuck Swiger
On Jan 14, 2011, at 2:09 PM, Eygene Ryabinkin wrote: > Almost all of them were addressed, as I can judge. But I had spotted some > more nits ;)). Thanks for the additional review. :-) Regards, -- -Chuck ___ freebsd-ports@freebsd.org mailing list ht

Re: Attention ports committers

2011-01-14 Thread Eygene Ryabinkin
Fri, Jan 14, 2011 at 10:47:36AM -0800, Chuck Swiger wrote: > Have you addressed the problems mentioned by Chris Rees > yet? Almost all of them were addressed, as I can judge. But I had spotted some more nits ;)). -- Eygene Ryabinkin,,,^..^,,, [ Life's unf

Re: Attention ports committers

2011-01-14 Thread Eygene Ryabinkin
Sat, Jan 15, 2011 at 12:46:02AM +0300, Eygene Ryabinkin wrote: > A couple of things about the port: [...] Two more things. There is INSTALL_MAN macros that should be used for manpage installation. Also, ${MANPREFIX}/man/man8/ is better spelled as ${MAN8PREFIX}/man/man8/ and you can use the follo

Re: Attention ports committers

2011-01-14 Thread Eygene Ryabinkin
Good day. Fri, Jan 14, 2011 at 01:18:52PM -0500, joeb wrote: > I would like to draw the attention of a ports committer to port > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/148777 > > If it needs further work please provide feedback. A couple of things about the port: - you can just us

Re: Attention ports committers

2011-01-14 Thread Chuck Swiger
On Jan 14, 2011, at 10:18 AM, joeb wrote: > I would like to draw the attention of a ports committer to port > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/148777 > > If it needs further work please provide feedback. Have you addressed the problems mentioned by Chris Rees yet? A port sub

Attention ports committers

2011-01-14 Thread joeb
I would like to draw the attention of a ports committer to port http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/148777 If it needs further work please provide feedback. Thanks for your attention to commit this port. ___ freebsd-ports@freebsd.org ma