Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On Fri, 15 Jul 2011, Stephen Montgomery-Smith wrote: On 07/15/2011 04:57 PM, Warren Block wrote: FWIW, I think the original code with a better regex like Jung-uk Kim has in http://lists.freebsd.org/pipermail/freebsd-ports/2011-July/068737.html is still the way to go. If the port requires a sp

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On 07/15/2011 04:57 PM, Warren Block wrote: FWIW, I think the original code with a better regex like Jung-uk Kim has in http://lists.freebsd.org/pipermail/freebsd-ports/2011-July/068737.html is still the way to go. If the port requires a special desktop entry filename, that seems beyond the sco

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On Fri, 15 Jul 2011, Pav Lucistnik wrote: Warren Block píše v pá 15. 07. 2011 v 07:15 -0600: It could also be made polymorphic, basing what it does on the number of fields rather than a new DESKTOP_ENTRIESv2 define. I believe that's impossible because you can create several desktop entries b

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

Warren Block píše v pá 15. 07. 2011 v 07:15 -0600: > It could also be made polymorphic, basing what it does on the > number of fields rather than a new DESKTOP_ENTRIESv2 define. I believe that's impossible because you can create several desktop entries by repeating the quadruple of values in thi

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On 15 Jul 2011 03:16, "Stephen Montgomery-Smith" wrote: > > On 07/14/2011 02:29 PM, Chris Rees wrote: >> >> >> On 14 Jul 2011 17:58, "Stephen Montgomery-Smith" > > wrote: >> >Joe Average user who doesn't actually install the ports shouldn't be >> expected to read UPDA

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

> But then we would still need to add a check to check-desktop-entries > for DESKTOP_ENTRIESv2 that would detect illegal characters in the > filename. Since this is not user settable IMHO the check should really be done in portlint, not in b.p.m. -- Eitan Adler __

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

2011/7/15 Warren Block : >> How about something like this: >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=158936 > > Wouldn't the point of using a separate filename argument be to let the user > specify exactly what the name is?  Here you end up with the same > system-processed filename.  Possibl

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On Fri, 15 Jul 2011, Scot Hetzel wrote: 2011/7/14 Pav Lucistnik : Stephen Montgomery-Smith píše v čt 14. 07. 2011 v 11:57 -0500: entry.  I assume that the filename of the desktop entry is unimportant, The filename of desktop entry should be 100% inconsequential, and our only care should be

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

2011/7/14 Pav Lucistnik : > Stephen Montgomery-Smith píše v čt 14. 07. 2011 v 11:57 -0500: > >> entry.  I assume that the filename of the desktop entry is unimportant, > > The filename of desktop entry should be 100% inconsequential, and our > only care should be not have two ports installing same

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On 07/14/2011 02:29 PM, Chris Rees wrote: On 14 Jul 2011 17:58, "Stephen Montgomery-Smith" mailto:step...@missouri.edu>> wrote: >Joe Average user who doesn't actually install the ports shouldn't be expected to read UPDATING. Er... he really should and is expected to. The situation I am think

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On Thursday 14 July 2011 03:15 pm, Pav Lucistnik wrote: > Jung-uk Kim p紫e v �t 14. 07. 2011 v 15:07 -0400: > > > > entry. I assume that the filename of the desktop entry is > > > > unimportant, > > > > > > The filename of desktop entry should be 100% inconsequential, > > > and our only care should

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On 14 Jul 2011 17:58, "Stephen Montgomery-Smith" wrote: >Joe Average user who doesn't actually install the ports shouldn't be expected to read UPDATING. Er... he really should and is expected to. Chris ___ freebsd-ports@freebsd.org mailing list http://

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

Jung-uk Kim píše v čt 14. 07. 2011 v 15:15 -0400: > On Thursday 14 July 2011 01:55 pm, Stephen Montgomery-Smith wrote: > > On 07/14/2011 12:47 PM, Jung-uk Kim wrote: > > > Anyhow, I guess we can do it much simpler: > > > > > > --- Mk/bsd.port.mk 3 Jul 2011 15:51:18 - 1.687 > > > +++

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

Jung-uk Kim píše v čt 14. 07. 2011 v 15:07 -0400: > > > entry. I assume that the filename of the desktop entry is > > > unimportant, > > > > The filename of desktop entry should be 100% inconsequential, and > > our only care should be not have two ports installing same file. > > I believe the or

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On Thursday 14 July 2011 01:55 pm, Stephen Montgomery-Smith wrote: > On 07/14/2011 12:47 PM, Jung-uk Kim wrote: > > Anyhow, I guess we can do it much simpler: > > > > --- Mk/bsd.port.mk 3 Jul 2011 15:51:18 - 1.687 > > +++ Mk/bsd.port.mk 14 Jul 2011 17:26:43 - > > @@ -6432,7

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On Thursday 14 July 2011 01:54 pm, Pav Lucistnik wrote: > Stephen Montgomery-Smith p紫e v �t 14. 07. 2011 v 11:57 -0500: > > entry. I assume that the filename of the desktop entry is > > unimportant, > > The filename of desktop entry should be 100% inconsequential, and > our only care should be not

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On 07/14/2011 12:54 PM, Pav Lucistnik wrote: Stephen Montgomery-Smith píše v čt 14. 07. 2011 v 11:57 -0500: entry. I assume that the filename of the desktop entry is unimportant, The filename of desktop entry should be 100% inconsequential, and our only care should be not have two ports inst

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On 07/14/2011 12:47 PM, Jung-uk Kim wrote: Anyhow, I guess we can do it much simpler: --- Mk/bsd.port.mk 3 Jul 2011 15:51:18 - 1.687 +++ Mk/bsd.port.mk 14 Jul 2011 17:26:43 - @@ -6432,7 +6432,7 @@ ${ECHO_CMD} "@cwd ${DESKTOPDIR}">> ${TMPPLIST}; \

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

Stephen Montgomery-Smith píše v čt 14. 07. 2011 v 11:57 -0500: > entry. I assume that the filename of the desktop entry is unimportant, The filename of desktop entry should be 100% inconsequential, and our only care should be not have two ports installing same file. > and is used only internal

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On Thursday 14 July 2011 12:57 pm, Stephen Montgomery-Smith wrote: > Pav Lucistnik wrote: > > On 2011/07/14 00:57, Jung-uk Kim wrote: > >> links.diff, metalink-editor.diff, tome.diff: > >> - Add static desktop files to work around DESKTOP_ENTRIES > >> limitations. > > > > This is a step backwards a

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

Pav Lucistnik wrote: On 2011/07/14 00:57, Jung-uk Kim wrote: links.diff, metalink-editor.diff, tome.diff: - Add static desktop files to work around DESKTOP_ENTRIES limitations. This is a step backwards and I'll oppose it. I am beginning to get a clearer picture of what is going on. This

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On 2011/07/14 00:57, Jung-uk Kim wrote: links.diff, metalink-editor.diff, tome.diff: - Add static desktop files to work around DESKTOP_ENTRIES limitations. This is a step backwards and I'll oppose it. -- Pav Lucistnik ___ freebsd-por

Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2)

On Tuesday 12 July 2011 06:25 pm, Jung-uk Kim wrote: > After I updated x11-wm/compiz, GNOME was not able to start the > window manager. Basically, it complained that compiz-manager was > not found. Then, I realized compiz-manager.desktop was > automagically replaced by compizmanager.desktop. Now