nvass-gmx.com added a comment.
Thanks for taking a look Kristof,
I believe all your points are valid. Thing is that all eventhandlers need a
more thorough look. They don't work as they should; be it virtualized or not,
be it a VIMAGE or GENERIC kernel. I am trying to take a look but I ha
nvass-gmx.com added a comment.
Sure, I will take a look
REVISION DETAIL
https://reviews.freebsd.org/D1944
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri
Cc: mmoll, javier_ovi_yahoo.co
nvass-gmx.com added a comment.
Hi from me as well,
just want to say that I am here too and I am willing to work on this
even if i have to do it scratch;)
Please review:) Nikos
REVISION DETAIL
https://reviews.freebsd.org/D1944
EMAIL PREFERENCES
https://reviews.freebsd.org/setti
nvass-gmx.com added a comment.
Hi,
could you write an email to me and freebsd-virtualizat...@freebsd.org with
the necessary steps to re-produce the problem?
REVISION DETAIL
https://reviews.freebsd.org/D1944
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To:
nvass-gmx.com updated this revision to Diff 6288.
nvass-gmx.com added a comment.
Updated to today's head branch. Please review
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1944?vs=5290&id=6288
REVISION DETAIL
https://reviews.freebsd.org/D1944
AFFECTED FILES
sys/net/pfvar.h
sy
nvass-gmx.com added a comment.
In https://reviews.freebsd.org/D1944#47915, @glebius wrote:
> Thanks a lot, Nikos.
>
> I've fixed the problem of sleeping in UMA on kldunload. It was out the scope
> of the patch. I also committed the first part of the patch - mutexes
> initialization.
>
> Nikos,
nvass-gmx.com added a comment.
In https://reviews.freebsd.org/D1944#47231, @rodrigc wrote:
> I tested this patch.
>
> # kldload pf
> # kldunload pf
> kldunload: can't unload file: Device busy
>
>
> The fact that the pf module cannot be unloaded was one of the
> reasons that @glebius used t
nvass-gmx.com added a comment.
This guilde is definitely invaluable, I have seen it. It would be great if we
could move it in the source tree.
Regarding PF it can be further simplified. I think the logic right is OK but
there are many *init* functions for sure and some of these
functions can go
nvass-gmx.com updated this revision to Diff 5290.
nvass-gmx.com added a comment.
Hi,
Please review this. It updates the previous patch, with another way to unload
pf.
Eventhandlers are also touched, they should behave correctly now.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D194
nvass-gmx.com added a comment.
Yes, I am trying to fix the issues. It needs more work. I will update when I
have a new patch
REVISION DETAIL
https://reviews.freebsd.org/D1944
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: nvass-gmx.com, bz, zec, trociny
nvass-gmx.com added a comment.
>>! In D1944#11, @kristof wrote:
> Don't we still need to do all of this somewhere?
>>! In D1944#11, @kristof wrote:
> Don't we still need to do all of this somewhere?
INLINE COMMENTS
sys/netpfil/pf/pf_ioctl.c:325 pf_unload is called before pf_vnet_unit, this
nvass-gmx.com added a comment.
>>! In D1944#8, @glebius wrote:
> Nikos,
>
> acking that I see the patches. Right now I'm waiting for pf to stablize after
> recent patches to fragment handling. Kristof is working on the known problem.
> Meanwhile you can finish your patch moving from "almost there
12 matches
Mail list logo
