Re: dscp set/get

2016-10-06 Thread Franco Fichtner
> On 06 Oct 2016, at 3:32 PM, Kristof Provost wrote: > > OpenBSD seem to just always preserve the ECN bits (so there’s no dscp > keyword). > Perhaps we should do the same. The following will import the OpenBSD code regarding the subject. I retained the old manual style that is in FreeBSD to ma

Re: dscp set/get

2016-10-06 Thread Kristof Provost
On 6 Oct 2016, at 15:01, Mark Martinec wrote: Just adding recognition to a parser for a couple of DSCP constants to be mapped to TOS is not the solution. Keep in mind that DSCP is a 6-bit field, and TOS is an 8-bit field. The remaining two bits are used for ECN (Explicit Congestion Notification).

Re: dscp set/get

2016-10-06 Thread Franco Fichtner
> On 06 Oct 2016, at 3:32 PM, Kristof Provost wrote: > > On 6 Oct 2016, at 15:01, Mark Martinec wrote: >> Just adding recognition to a parser for a couple of DSCP constants >> to be mapped to TOS is not the solution. Keep in mind that DSCP >> is a 6-bit field, and TOS is an 8-bit field. The rema

Re: dscp set/get

2016-10-06 Thread Mark Martinec
Just adding recognition to a parser for a couple of DSCP constants to be mapped to TOS is not the solution. Keep in mind that DSCP is a 6-bit field, and TOS is an 8-bit field. The remaining two bits are used for ECN (Explicit Congestion Notification). Setting TOS field with the intention of chang

Re: dscp set/get

2016-10-06 Thread Kristof Provost
On 6 Oct 2016, at 10:30, Franco Fichtner wrote: On 06 Oct 2016, at 10:10 AM, Kristof Provost wrote: On 6 Oct 2016, at 6:57, Eugene M. Zheganin wrote: pf still lacks the DSCP handling, will it be difficult/expensive to add this ? AFAIK ipfw got this recently. pf has set-tos and tos keywords.

Re: dscp set/get

2016-10-06 Thread Franco Fichtner
Hi, > On 06 Oct 2016, at 10:10 AM, Kristof Provost wrote: > > On 6 Oct 2016, at 6:57, Eugene M. Zheganin wrote: >> pf still lacks the DSCP handling, will it be difficult/expensive to add >> this ? AFAIK ipfw got this recently. >> > pf has set-tos and tos keywords. What is it not letting you do?

Re: dscp set/get

2016-10-06 Thread Kristof Provost
On 6 Oct 2016, at 6:57, Eugene M. Zheganin wrote: > pf still lacks the DSCP handling, will it be difficult/expensive to add > this ? AFAIK ipfw got this recently. > pf has set-tos and tos keywords. What is it not letting you do? Regards, Kristof ___ free