[Differential] [Commented On] D1201: Allow UMA allocated memory to be freed when VNET jails are torn down.

gnn added a comment. No objection from me. REVISION DETAIL https://reviews.freebsd.org/D1201 To: rodrigc, alfredperlstein, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson Cc: freebsd-net, emaste, gnn, rwatson ___ fre

[Differential] [Accepted] D1309: VIMAGE PF fixes #1

gnn accepted this revision. gnn added a reviewer: gnn. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1309 To: rodrigc, bz, glebius, trociny, zec, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson Cc: freebsd-virtualization,

[Differential] [Accepted] D1705: sfxge: Use SFXGE_MODERATION to initialize event moderation

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to add Approved by: gnn to your commit message. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1705 To: arybchik, gnn Cc: freebsd-net ___

[Differential] [Accepted] D1704: sfxge: Pass correct address to free allocated memory in the case of load error

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to add Approved by: gnn (mentor) to your commit message. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1704 To: arybchik, gnn Cc: freebsd-net __

[Differential] [Accepted] D1703: sfxge: Remove unused esm_size member of the efsys_mem_t structure

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to add Approved by: gnn (mentor) to your commit message. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1703 To: arybchik, gnn Cc: freebsd-net __

[Differential] [Accepted] D1702: sfxge: Do not bzero() DMA allocated memory once again

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to add Approved by: gnn (mentor) to your commit message. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1702 To: arybchik, gnn Cc: freebsd-net __

[Differential] [Accepted] D1706: sfxge: implemented parameter to restrict RSS channels

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to add Approved by: gnn (mentor) to your commit message. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1706 To: arybchik, gnn Cc: freebsd-net __

[Differential] [Accepted] D1701: sfxge: Add evq argument to sfxge_tx_qcomplete()

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to add Approved by: gnn (mentor) to your commit message. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1701 To: arybchik, gnn Cc: freebsd-net __

[Differential] [Accepted] D1692: sfxge: Change sfxge_ev_qpoll() proto to avoid EVQ pointers array access

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to add Approved by: gnn (mentor) to your commit message. REVISION DETAIL https://reviews.freebsd.org/D1692 To: arybchik, gnn Cc: freebsd-net __

[Differential] [Accepted] D1700: sfxge: fixed TSO code to cope with VLAN headers

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to add Approved by: gnn (mentor) to your commit message. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1700 To: arybchik, gnn Cc: freebsd-net __

[Differential] [Requested Changes To] D1707: sfxge: access statistics buffers under port lock

gnn requested changes to this revision. gnn added a comment. This revision now requires changes to proceed. If you look at other drivers you'll see they have #define'd macros for the locks, rather than direct calls. This allows us to name the lock in the macro. See, for instance, this example

[Differential] [Accepted] D1699: sfxge: Remove extra cache-line alignment and reorder sfxge_evq_t

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to put Approved by: gnn (mentor) in the commit message. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1699 To: arybchik, gnn Cc: freebsd-net ___

[Differential] [Accepted] D1698: sfxge: Make it possible to build without EVQ statistics

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to put Approved by: gnn (mentor) in the commit message. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1698 To: arybchik, gnn Cc: freebsd-net ___

[Differential] [Accepted] D1708: sfxge: Separate software Tx queue limit for non-TCP traffic

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to put Approved by: gnn (mentor) in the commit message. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1708 To: arybchik, gnn Cc: freebsd-net ___

[Differential] [Requested Changes To] D1697: sfxge: Expect required init_state on data path and in periodic calls

gnn requested changes to this revision. gnn added a comment. This revision now requires changes to proceed. __predict_false rarely, if ever, does the right thing. Have you run any benchmarks to show that this improves performance? REVISION DETAIL https://reviews.freebsd.org/D1697 To: arybchi

[Differential] [Accepted] D1694: sfxge: Move txq->next pointer to part writable on completion path

gnn accepted this revision. gnn added a comment. This revision is now accepted and ready to land. Remember to put Approved by: gnn (mentor) in the commit message. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1694 To: arybchik, gnn Cc: freebsd-net ___

[Differential] [Accepted] D1691: sfxge: using 64-bit access for x86-64

gnn accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1691 To: arybchik, gnn Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd

[Differential] [Accepted] D1965: Add extended media types to if_media.h and ifconfig

gnn accepted this revision. gnn added a comment. BTW Mike Karels was in favor of this in an email thread. He's not yet on phabricator but I'll ask him here as well. BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1965 To: erj, adrian, jfvogel, gnn Cc: glebius, freebsd-net __

[Differential] [Updated] D1944: PF and VIMAGE fixes

gnn added a comment. Any update on this? REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, bz, zec, trociny, glebius, rodrigc, kristof, gnn Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing lis

[Differential] [Closed] D1777: Associated fix for arp/nd6 timer usage.

gnn closed this revision. gnn added a comment. I believe we can close this. REVISION DETAIL https://reviews.freebsd.org/D1777 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rrs, imp, rwatson, lstewart, kib, adrian, jhb, bz, sbruno, gnn Cc: ae, bz, freebs

[Differential] D5872: tcp: Don't prematurely drop receiving-only connections

gnn added a comment. Let's keep this moving along. Mike isn't (yet) a committer but if someone can commit this once everyone agrees that would be great. REVISION DETAIL https://reviews.freebsd.org/D5872 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To:

[Differential] D5872: tcp: Don't prematurely drop receiving-only connections

gnn added a comment. Not my comment "once everyone agrees" :-) REVISION DETAIL https://reviews.freebsd.org/D5872 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, glebius, adrian, delphij, decui_microsoft.com, honzhan_micros

[Differential] D8905: if: Defer the if_up until the ifnet.if_ioctl is called.

gnn accepted this revision. This revision has a positive review. REVISION DETAIL https://reviews.freebsd.org/D8905 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_g

[Differential] D9847: Try to extract the RFC1048 data from PXE

gnn accepted this revision. gnn added a reviewer: gnn. This revision has a positive review. REVISION DETAIL https://reviews.freebsd.org/D9847 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, oshogbo, bapt, tsoome, glebius, freebsd-net-list, #netwo

[Differential] D26757: Fix to join AllHost mcast group again when adding an existing IP address

gnn accepted this revision. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D26757/new/ REVISION DETAIL https://reviews.freebsd.org/D26757 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: yannis.planus_alstomg