[Differential] [Changed Subscribers] D1309: VIMAGE PF fixes #1

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1309 To: rodrigc, glebius, trociny, zec, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson Cc: emaste, freebsd-virtualization, freebsd-pf, freebsd-net _

[Differential] [Changed Subscribers] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, adrian, sbruno, lstewart, hselasky, imp Cc: emaste, delphij, neel, erj, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freeb

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

emaste added a comment. For future diffs, please generate with full context, e.g. -U99 INLINE COMMENTS sys/kern/kern_timeout.c:789 added EOL whitespace? sys/kern/kern_timeout.c:1067-1069 I'm a bit confused by this sentence. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gn

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

emaste added inline comments. INLINE COMMENTS kern/kern_timeout.c:1159 Yeah, something like @imp's suggestion makes it more clear to me. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, sbruno, lstewart, jhb, kostikbel, hselasky, adrian, imp Cc: jhb, kostikbel, emast

[Differential] [Changed Subscribers] D1805: [sockbuf] Don't access fields directly, use accessor functions

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1805 To: davide, kmacy, np, lstewart, rrs, rwatson Cc: emaste, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net T

[Differential] [Changed Subscribers] D1881: Allow Illumos code to co-exist with nv(9)

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send a

[Differential] [Changed Subscribers] D1869: Tests of basic nvlist add functions

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send a

[Differential] [Changed Subscribers] D1986: Teach lagg(4) to change MTU

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1986 To: rpokala-panasas.com, rstone Cc: emaste, ae, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscr

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste updated this revision to Diff 100815. emaste added reviewers: melifaro, imp, hrs. emaste added a subscriber: freebsd-net-list. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D33717?vs=100814&id=100815 CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DE

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste added reviewers: imp, hrs. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL https://reviews.freebsd.org/D33717 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, melifaro, imp, hrs Cc: freebsd-net-list

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste removed reviewers: imp, hrs. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL https://reviews.freebsd.org/D33717 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, melifaro, imp, hrs Cc: freebsd-net-list

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste updated this revision to Diff 100973. emaste added a comment. remove now-unused variable CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D33717?vs=100815&id=100973 CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL https://reviews.freebsd.org

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste added a comment. As @melifaro pointed out to prompt this change hp was passed to three getaddr() calls in newroute(), and was not otherwise used, and getaddr() does not use the passed-in value. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL http

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste added a subscriber: brooks. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL https://reviews.freebsd.org/D33717 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, melifaro, imp, hrs Cc: brooks, freebsd-net-lis

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste removed a subscriber: freebsd-net-list. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL https://reviews.freebsd.org/D33717 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, melifaro, imp, hrs Cc: brooks, fre