decui_microsoft.com updated the summary for this revision.
decui_microsoft.com updated this revision to Diff 23652.
decui_microsoft.com added a comment.
Since sephe's patch (https://reviews.freebsd.org/D8905) is accepted, let me
update this patch accordingly.
CHANGES SINCE LAST UPDATE
https
decui_microsoft.com created this revision.
decui_microsoft.com added reviewers: hselasky, sepherosa_gmail.com, cem, np,
kmacy, kib, honzhan_microsoft.com, howard0su_gmail.com, jhb, ae, delphij,
royger, glebius, gnn, rwatson.
decui_microsoft.com added a subscriber: freebsd-net-list.
REVISION SUMM
decui_microsoft.com retitled this revision from "ifnet: move the new
ifnet_event EVENTHANDLER_DECLAREs to net/if_var.h" to "ifnet: move the new
ifnet_event EVENTHANDLER_DECLARE to net/if_var.h".
REVISION DETAIL
https://reviews.freebsd.org/D9345
EMAIL PREFERENCES
https://reviews.freebsd.org/
decui_microsoft.com added inline comments.
INLINE COMMENTS
> David_A_Bright_DELL.com wrote in if_var.h:407
> I would stick with the previous "ifup/ifdown" or go with "Interface up/down".
> I think "Interface up/ifdown" reads poorly.
I was trying to keep the consistency with Line 392, 395, 401 a
decui_microsoft.com added inline comments.
INLINE COMMENTS
> David_A_Bright_DELL.com wrote in if_var.h:407
> No objection to "Interface ..." but then I'd use "Interface up/down event"
> (the "if" in "ifdown" meaning "interface" is redundant).
>
> But, then, this is a nit. I don't strongly objec
decui_microsoft.com updated this revision to Diff 24479.
decui_microsoft.com added a comment.
This revision now requires review to proceed.
fixed the comment typo pointed out by David.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D9345?vs=24465&id=24479
REVISION DETAIL
https://re
