[Differential] [Request, 15 lines] D1805: [sockbuf] Don't access fields directly, use accessor functions

davide created this revision. davide added reviewers: kmacy, np, lstewart, rrs, rwatson. davide added a subscriber: freebsd-net. davide set the repository for this revision to rS (FreeBSD src repository). REVISION SUMMARY Small step towards a saner sockbuf abstraction REVISION DETAIL https://

[Differential] [Updated, 15 lines] D1805: [sockbuf] Don't access fields directly, use accessor functions

davide updated this revision to Diff 3695. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1805?vs=3694&id=3695 REVISION DETAIL https://reviews.freebsd.org/D1805 AFFECTED FILES sys/kern/uipc_socket.c To: davide, kmacy, np, lstewart, rrs, rwatson Cc: freebsd-net

[Differential] [Updated, 12 lines] D1805: [sockbuf] Don't access fields directly, use accessor functions

davide updated this revision to Diff 3698. davide added a comment. Updated removing the last place where this was used. I was not certain about it before so I previously left it as-is, but it looks like in this case order doesn't matter considering we're holding the socket buffer lock across the

[Differential] [Request, 14 lines] D1809: [sockbuf] Don't expose lock details when isn't needed

davide created this revision. davide added reviewers: kmacy, np, rrs, lstewart, rwatson. davide added a subscriber: freebsd-net. davide set the repository for this revision to rS (FreeBSD src repository). REVISION DETAIL https://reviews.freebsd.org/D1809 AFFECTED FILES sys/dev/cxgbe/tom/t4_dd

[Differential] [Commented On] D1805: [sockbuf] Don't access fields directly, use accessor functions

davide added a comment. I plan to commit this in two days or such, so if there are objections, please raise them. REVISION DETAIL https://reviews.freebsd.org/D1805 To: davide, kmacy, np, lstewart, rrs, rwatson Cc: emaste, freebsd-net ___ freebsd-net

[Differential] [Commented On] D1809: [sockbuf] Don't expose lock details when isn't needed

davide added a comment. I plan to commit this in two days or such, so if there are objections, please raise them. REVISION DETAIL https://reviews.freebsd.org/D1809 To: davide, kmacy, np, rrs, lstewart, rwatson Cc: freebsd-net ___ freebsd-net@freebsd

[Differential] [Commented On] D1809: [sockbuf] Don't expose lock details when isn't needed

davide added a comment. Mainly for consistency at this point with whatever else it's used in the stack. REVISION DETAIL https://reviews.freebsd.org/D1809 To: davide, kmacy, np, rrs, lstewart, rwatson Cc: julian, freebsd-net ___ freebsd-net@freebsd.or

[Differential] [Commented On] D1809: [sockbuf] Don't expose lock details when isn't needed

davide added a comment. Robert, an added (somewhat related) note. SCTP has already its own sockbuf(s) and this makes integration very hackish in the tree. IIRC glebius experienced this himself while working on sendfile(), and I'm pretty sure rrs@ is kind of familiar with the problem. Introducin

[Differential] [Commented On] D1809: [sockbuf] Don't expose lock details when isn't needed

davide added inline comments. INLINE COMMENTS sys/kern/uipc_sockbuf.c:234 Thanks for spotting i'll fix up and upload a new patch. REVISION DETAIL https://reviews.freebsd.org/D1809 To: davide, kmacy, np, rrs, lstewart, rwatson Cc: julian, freebsd-net _

[Differential] [Closed] D1805: [sockbuf] Don't access fields directly, use accessor functions

davide closed this revision. davide added a comment. In HEAD now. REVISION DETAIL https://reviews.freebsd.org/D1805 To: davide, kmacy, np, lstewart, rrs, julian, adrian, rwatson Cc: emaste, freebsd-net ___ freebsd-net@freebsd.org mailing list http://