[Differential] [Changed Subscribers] D1438: FreeBSD callout rewrite and cleanup

avg added a subscriber: avg. REVISION DETAIL https://reviews.freebsd.org/D1438 To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn, rrs, kostikbel, delphij, neel, erj, mat, remkolodder, bcr, brueffer, brd, allanjude, wblock Cc: avg, jch, wblock, freebsd-net _

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

avg added a subscriber: avg. avg added a comment. This has already been committed, so I've missed the train, but I still would like to comment. And I hope that my comment won't be just a rant. So, I don't like this change for several reasons. For one, given that nv(9) is a new thing while libnvp

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

avg added a comment. Another thought. Or was the intention only to make nv(9) and hrm.. nvpair compatible only within the kernel? Section 9 seems like a big hint here, but I am not sure. If the intention was such, then my previous comment is to inform that that change affected the userland as w

[Differential] D10485: Replace dhcp option 150 by 66

avg added a comment. I only recently looked into our pxeboot and it seems to be grossly non compliant with the PXE specification. And it probably needs to be because it acts as a PXE client. For starters, it does not support "Proxy DHCP" (a PXE server running separately from a DHCP server

[Differential] D10603: distinguish NFS versus TFTP boot by rootpath

avg added a comment. My opinion is that pxeboot is in the same league as ipxe. Of course, pxeboot is more specialized, but it is still a chain-loaded PXE boot client. I see two possibilities of providing FreeBSD specific boot information. Either we provide it via FreeBSD vendor extensions

[Differential] D24989: netinet: Generate a random RSS key on boot.

avg added a comment. I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies). So, maybe just being random is not good enough? I think that hypothetical `rss_isbadkey` was mentioned for a reason? REPOSITORY rS FreeBSD src

[Differential] D24989: netinet: Generate a random RSS key on boot.

avg added a comment. In D24989#552693 , @neel_neelc.org wrote: > I believe Linux just uses random keys: > > - https://github.com/torvalds/linux/blob/29d9f30d4ce6c7a38745a54a8cddface10013490/net/ethtool/ioctl.c#L924 You are right. So, my