[ieee80211] [patch] BPF taps not working for ieee80211 interfaces in monitor mode

2013-10-09 Thread Patrick Kelsey
Hi, A bug was introduced in r254082 that results in BPF taps never being enabled for ieee80211 interfaces that are in monitor mode. Before r254082, bpf_track() in sys/net80211/ieee80211_freebsd.c was identifying ieee80211 interfaces by checking to see if the value of the ifp->if_start pointer was

Extraneous code in syncache_socket()

2014-03-30 Thread Patrick Kelsey
Using sys/netinet/tcp_syncache.c in r261594 for reference ( http://svnweb.freebsd.org/base/head/sys/netinet/tcp_syncache.c?view=markup), I believe the following code in syncache_socket() serves no purpose: These two lines beginning at line 780: if (IN6_IS_ADDR_UNSPECIFIED(&inp->in

Re: netisr observations

2014-04-11 Thread Patrick Kelsey
On Fri, Apr 11, 2014 at 2:48 AM, Adrian Chadd wrote: > [snip] > > So, hm, the thing that comes to mind is the flowid. What's the various > flowid's for flows? Are they all mapping to CPU 3 somehow The output of netstat -Q shows IP dispatch is set to default, which is direct (NETISR_DISPATCH_DIR

Re: netisr observations

2014-04-11 Thread Patrick Kelsey
On Fri, Apr 11, 2014 at 8:23 PM, hiren panchasara < hiren.panchas...@gmail.com> wrote: > On Fri, Apr 11, 2014 at 11:30 AM, Patrick Kelsey wrote: > > > > The output of netstat -Q shows IP dispatch is set to default, which is > > direct (NETISR_DISPATCH_DIRECT). That m

Looking for input on "locally patch tcpdump or merge in latest release from upstream?"

2015-05-27 Thread Patrick Kelsey
Hi, I've had a patch for a capsicum-related issue in tcpdump sitting around since last September ( https://lists.freebsd.org/pipermail/freebsd-current/2014-September/052049.html) that is still needed and that I want finally address in the tree (the patch was reviewed by rwatson@ and pjd@ back then

Re: Looking for input on "locally patch tcpdump or merge in latest release from upstream?"

2015-05-28 Thread Patrick Kelsey
-BEGIN PGP SIGNED MESSAGE- > > Hash: SHA512 > > > > Hi, Hiren, > > > > On 05/27/15 21:55, hiren panchasara wrote: > > > On 05/28/15 at 12:40P, Patrick Kelsey wrote: > > >> Hi, > > >> > > >> I've had a patch for a capsic

TCP Fast Open (RFC7413) for FreeBSD

2015-09-01 Thread Patrick Kelsey
Hi, About two weeks from now, I will be starting work on server-side TCP Fast Open (TFO) support for FreeBSD head and stable/10, with the intention of having patches up for review by November. This message is an attempt to uncover any existing work on TFO for FreeBSD, as the existence of such wor

Re: TCP Fast Open (RFC7413) for FreeBSD

2015-09-01 Thread Patrick Kelsey
> On Sep 2, 2015, at 12:54 AM, Rui Paulo wrote: > >> On Tue, 2015-09-01 at 21:19 -0400, Patrick Kelsey wrote: >> Hi, >> >> About two weeks from now, I will be starting work on server-side TCP >> Fast >> Open (TFO) support for FreeBSD head and stab

Re: TCP Fast Open (RFC7413) for FreeBSD

2015-09-02 Thread Patrick Kelsey
> On Sep 2, 2015, at 12:21 PM, Rui Paulo wrote: > >> On Wed, 2015-09-02 at 01:30 -0400, Patrick Kelsey wrote: >> >> >> >>>> On Sep 2, 2015, at 12:54 AM, Rui Paulo wrote: >>>> >>>> On Tue, 2015-09-01 at 21:19 -0400, Pat

Review posted for higher-bandwidth altq

2018-08-18 Thread Patrick Kelsey
Hi, I just posted a review (https://reviews.freebsd.org/D16782) for a patch to upgrade pfctl(8) and the pf(4) ioctl interface to be able to deal properly with bandwidth parameters greater than 32 bits. It also updates the math in the token bucket regulator and the HFSC scheduler to work up to at

Conversion of vmx(4) (VMXNET3) driver to iflib review posted

2019-01-06 Thread Patrick Kelsey
Hi, There's a patch that converts the existing vmx(4) driver to iflib available for testing/review at https://reviews.freebsd.org/D18761. Best, Patrick ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To un

Re: vmx0: watchdog timeout on queue 2, no interrupts on BSP

2019-07-20 Thread Patrick Kelsey
On Fri, Jul 19, 2019 at 10:07 AM Andriy Gapon wrote: > > Recently we experienced a strange problem. > We noticed a lot of these messages in the logs: > vmx0: watchdog timeout on queue 2 > (always queue 2) > Also, we noticed that connections to some end points did not work at all > while others wo

Re: vmx0: watchdog timeout on queue 2, no interrupts on BSP

2019-07-21 Thread Patrick Kelsey
> On Jul 21, 2019, at 4:17 PM, Andriy Gapon wrote: > >> On 20/07/2019 20:08, Patrick Kelsey wrote: >> >> >> On Fri, Jul 19, 2019 at 10:07 AM Andriy Gapon > <mailto:a...@freebsd.org>> wrote: >> >> >>Recently we experienced a

Re: TCP_FASTOPEN is absent in GENERIC

2017-01-31 Thread Patrick Kelsey
On Tue, Jan 31, 2017 at 10:53 AM, Sergey Matveychuk wrote: > Hi. > > Is there a strong reason for option TCP_FASTOPEN is absent in GENERIC > kernel? It's off by default anyway (net.inet.tcp.fastopen.enabled=0). > > Latest dns/bind* versions want it very much. > > The kernel option name is actuall

Re: vmx: strange issue, related to to tso?

2019-12-27 Thread Patrick Kelsey
On Fri, Dec 27, 2019 at 5:01 PM Andriy Gapon wrote: > On 27/12/2019 15:34, Vincenzo Maffione wrote: > > It may be useful to check what happens if you replace the vmx0 interface > with an > > em0. > > In this way you would know if the issue is vmx-specific or not. > > I'll put this on my to-do, ca

Re: vmx: strange issue, related to to tso?

2019-12-28 Thread Patrick Kelsey
s, > Vincenzo > >> Il giorno sab 28 dic 2019 alle ore 05:44 Patrick Kelsey >> ha scritto: >> >>> On Fri, Dec 27, 2019 at 5:01 PM Andriy Gapon wrote: >>> On 27/12/2019 15:34, Vincenzo Maffione wrote: >>> > It may be useful to check what hap

Re: vmx: strange issue, related to to tso?

2019-12-29 Thread Patrick Kelsey
On Sun, Dec 29, 2019 at 6:06 AM Andriy Gapon wrote: > On 28/12/2019 06:43, Patrick Kelsey wrote: > > I am not able to test this at the moment, nor likely in the very near > future, > > but I did have a few minutes to do some code reading and now believe > that the > &g

Re: terrible if_vmx / vmxnet3 rx performance with lro (post iflib)

2020-02-24 Thread Patrick Kelsey
On Thu, Feb 20, 2020 at 4:58 PM Josh Paetzel wrote: > > > On Wed, Feb 19, 2020, at 7:17 AM, Andriy Gapon wrote: > > On 18/02/2020 16:09, Andriy Gapon wrote: > > > My general experience with post-iflib vmxnet3 is that vmxnet3 has some > > > peculiarities that result in a certain "impedance mismatc

Re: terrible if_vmx / vmxnet3 rx performance with lro (post iflib)

2020-02-25 Thread Patrick Kelsey
On Mon, Feb 24, 2020 at 11:40 PM Patrick Kelsey wrote: > > > On Thu, Feb 20, 2020 at 4:58 PM Josh Paetzel wrote: > >> >> >> On Wed, Feb 19, 2020, at 7:17 AM, Andriy Gapon wrote: >> > On 18/02/2020 16:09, Andriy Gapon wrote: >> > > My general

Re: Can net.iflib.min_tx_latency=0 introduce an unbounded amount of latency?

2020-03-22 Thread Patrick Kelsey
On Sun, Mar 22, 2020 at 2:31 PM Ryan Stone wrote: > I've been tracking down a bug at work that appears to be due to > excessive latency introduced on the TX side of a TCP connection. In > looking through the iflib code, I noticed the tunable > net.iflib.min_tx_latency. My reading of the iflib c