Re: kern/143573: [em] em(4) NIC crashes intermittently

2010-02-05 Thread Earl Lapus
The following reply was made to PR kern/143573; it has been noted by GNATS. From: Earl Lapus To: bug-follo...@freebsd.org, earl.la...@gmail.com Cc: Subject: Re: kern/143573: [em] em(4) NIC crashes intermittently Date: Fri, 5 Feb 2010 16:57:11 +0800 Additional note: the kernel's /usr/sr

[ping6] freeaddrinfo()

2010-03-13 Thread Earl Lapus
Hi, I was browsing through the ping6 code and I noticed that one particular call to getaddrinfo() didn't have a freeaddrinfo() pair. All calls to getaddrinfo() should have an equivalent freeaddrinfo(), right? Attached is a patch that "tries-to-resolve" this very small issue (applies cleanly on an

Re: [ping6] freeaddrinfo()

2010-03-14 Thread Earl Lapus
On Sun, Mar 14, 2010 at 1:24 PM, Doug Barton wrote: > > For all such issues, please file a PR first so it doesn't get lost. When > you get the PR confirmation back, feel free to alert the list to its > existence. > As advised, I've just filed a PR - (PR number: 144730) -- There are seven words

Re: [ping6] freeaddrinfo()

2010-03-15 Thread Earl Lapus
On Tue, Mar 16, 2010 at 12:06 AM, Hajimu UMEMOTO wrote: > > Yup, it should be good practice.  But, this is rather intentional. > The `hostname' variable points to res->ai_canonname, and is used > later.  This is why the `res' variable is declared globally. > > Sincerely, > I see. I was unable to

Re: kern/146534: [icmp6] wrong source address in echo reply

2010-05-21 Thread Earl Lapus
The following reply was made to PR kern/146534; it has been noted by GNATS. From: Earl Lapus To: bug-follo...@freebsd.org, earl.la...@gmail.com Cc: Subject: Re: kern/146534: [icmp6] wrong source address in echo reply Date: Sat, 22 May 2010 14:06:45 +0800 --001636b14d02cd6f320487289c7c

patch review for kern/146534

2010-05-21 Thread Earl Lapus
Hi, I submitted a patch which fixes the problem described in the PR and it also retains this (http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet6/icmp6.c.diff?r1=1.118;r2=1.119;f=h) fix. I also ran the TAHI (tool version REL_3_3_0; test program version V6LC_4_0_5) phase 2 NDP test scripts and

Re: patch review for kern/146534

2010-07-04 Thread Earl Lapus
Hi, I just want to follow-up on this PR. Basically a working icmp6 functionality that exists in 7.x and below broke in 8.x and CURRENT. I believe it's too late to have it fixed in 8.1. Maybe someone on the list that really knows the icmp6 code can have a look and verify if it is indeed a bug. If i

Re: patch review for kern/146534

2010-07-05 Thread Earl Lapus
On Tue, Jul 6, 2010 at 9:25 AM, jhell wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I have reviewed this, edited the patch and determined this does fix the > problem.  The patch is attached and is also here: http://bit.ly/clqhxt > > > Regards, > Thank you, I appreciate the help. -