https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202510
--- Comment #5 from d...@my.gd ---
(In reply to Palle Girgensohn from comment #4)
Hello Palle,
Ah there may have been a small misunderstanding here.
My statement was more meant as a "the patch is made by a novice to RC and
network.subr,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202510
--- Comment #6 from Palle Girgensohn ---
Ah, OK. Good. So, hopefully someone will nurture this patch then. Any takers?
--
You are receiving this mail because:
You are the assignee for the bug.
_
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202510
Kubilay Kocak changed:
What|Removed |Added
Keywords||easy, needs-qa, patch
rstone added a subscriber: freebsd-net-list.
REVISION DETAIL
https://reviews.freebsd.org/D8685
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: rstone
Cc: freebsd-net-list, emaste
___
freebsd-net@freebsd.org mailin
hselasky added inline comments.
INLINE COMMENTS
> buf_ring.h:71
> + if (br->br_cons_head != br->br_prod_head) {
> + for (i = br->br_cons_head + 1; i != br->br_prod_head;
> + i = ((i + 1) & br->br_cons_mask))
should "br->br_cons_head + 1" be masked by br->br_cons_m
rstone updated this revision to Diff 22633.
rstone added a comment.
Ensure we don't walk off the end of the ring
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D8685?vs=22631&id=22633
REVISION DETAIL
https://reviews.freebsd.org/D8685
AFFECTED FILES
sys/sys/buf_ring.h
CHANGE DET
rstone marked an inline comment as done.
rstone added inline comments.
INLINE COMMENTS
> hselasky wrote in buf_ring.h:71
> should "br->br_cons_head + 1" be masked by br->br_cons_mask ??
Absolutely correct. Nice catch, thank you
REVISION DETAIL
https://reviews.freebsd.org/D8685
EMAIL PREFERE
Breakbulk China, Asia's largest exhibition and conference for the project cargo
and breakbulk industry, 13-16 March in Shanghai.
Email not displaying correctly?
View it in your browser
http://go.pardot.com/webmail/272542/109867/c9fea37a3d9c14526b3540841abac1402a07b1ab828bb5c50c8e9fbc93bc8d22.
