[Differential] D5872: tcp: Don't prematurely drop receiving-only connections

2016-04-27 Thread mike-karels.net (Mike Karels)
mike-karels.net added a comment. I disagree; congestion is congestion, not "congestion for everyone but me". I'd prefer to leave the cwnd change until it is replaced by something more modern. REVISION DETAIL https://reviews.freebsd.org/D5872 EMAIL PREFERENCES https://reviews.freebsd.or

[Differential] D5872: tcp: Don't prematurely drop receiving-only connections

2016-04-27 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com added a comment. In https://reviews.freebsd.org/D5872#130173, @mike-karels.net wrote: > I disagree; congestion is congestion, not "congestion for everyone but me". I'd prefer to leave the cwnd change until it is replaced by something more modern. We probably

[Differential] D6120: tcp/syncache: Set flowid and hash type properly for SYN|ACK

2016-04-27 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, rwatson, gnn, lstewart, glebius, delphij, mike-karels.net, jtl, hiren. sepherosa_gmail.com added a subscriber: freebsd-net-list. Herald added a reviewer: transport. REVISION DETAIL https://reviews.f

[Differential] D5872: tcp: Don't prematurely drop receiving-only connections

2016-04-27 Thread jtl (Jonathan T. Looney)
jtl added inline comments. INLINE COMMENTS sys/netinet/tcp_output.c:1551 In my opinion, this does //not// need to be a panic. A KASSERT() should be sufficient. Also, this is not the re-usable macro which Lawrence suggested. REVISION DETAIL https://reviews.freebsd.org/D5872 EMAIL PREFER

[Differential] D6120: tcp/syncache: Set flowid and hash type properly for SYN|ACK

2016-04-27 Thread sbruno (Sean Bruno)
sbruno accepted this revision. sbruno added a reviewer: sbruno. REVISION DETAIL https://reviews.freebsd.org/D6120 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, transport, adrian, rwatson, gnn, lstewart, glebius, delphij, mik

Regression? VLAN packet drop after upgrading from r281235

2016-04-27 Thread Zé Claudio Pastore
Hello, On a BGP border router I help manage, we run FreeBSD 10.1-STABLE, version r281235 and it works fine for several years now. We have around 4Gbit/s and 1.8Mpps routed on peak while per port interface we peak at 300Kpps. Our quality metrics are measured with: ping -s 1472 -i 0.1 As well a

Re: Regression? VLAN packet drop after upgrading from r281235

2016-04-27 Thread Ryan Stone
From a quick look at the vlan code, I can identify a few cases that might cause that counter to increment: 1) Error from the underlying ixgbe device. Does "netstat -dI ix0" show that the driver has been dropping packets? 2) Link down events on the underlying NIC. I believe that link flaps will

Re: Regression? VLAN packet drop after upgrading from r281235

2016-04-27 Thread Zé Claudio Pastore
Hello Ryan, 2016-04-27 17:28 GMT-03:00 Ryan Stone : > From a quick look at the vlan code, I can identify a few cases that might > cause that counter to increment: > > 1) Error from the underlying ixgbe device. Does "netstat -dI ix0" show > that the driver has been dropping packets? > No, it doe

[Differential] D5872: tcp: Don't prematurely drop receiving-only connections

2016-04-27 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com added inline comments. INLINE COMMENTS sys/netinet/tcp_output.c:1551 It's what I am testing w/, since I need non-INVARIANT kernel to generate enough traffic to make ENOBUFS happen. We can change it into KASSERT, however, I am wondering should we just use "if (__predict

[Differential] D6137: tcp/lro: Refactor the free/active list operation.

2016-04-27 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, gallatin, rrs, adrian, delphij, glebius, hselasky, np, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added a subscriber: freebsd-net-list. Herald added a reviewer: trans

Working divert socket example prog?

2016-04-27 Thread lpa lpa
Do anyone have a working example code of a divert loop program? I tried building this one[1] but it seems to be for FreeBSD 5 and won't build on latest system. I want to make simple measurement of pps rate for a packet traveling inside a divert socket and getting reinjected back while printing som