[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hselasky added a comment. Randall: Shooting again: Thread 1 is executing in "softclock_call_cc()" in the "new_cc = callout_cpu_switch(c, cc, new_cpu)" it has set "c->c_cpu = CPUBLOCK;" Thread 2 is now executing callout_reset(). As you can see in the implementation detail, it is reading "c_cpu"

[Differential] [Updated, 4 lines] D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets

hselasky added reviewers: network, glebius. hselasky added a subscriber: freebsd-net. hselasky set the repository for this revision to rS (FreeBSD src repository). hselasky updated this revision to Diff 3838. hselasky added a comment. Add full context. CHANGES SINCE LAST UPDATE https://reviews.

[Differential] [Updated, 4 lines] D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets

hselasky updated this revision to Diff 3839. hselasky added a comment. Use MIN() macro. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1893?vs=3838&id=3839 REVISION DETAIL https://reviews.freebsd.org/D1893 AFFECTED FILES sys/netinet/ip_output.c To: hselasky, pluknet, ae, np, meli

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

rrs added a comment. I have thought long and hard about this. I don't think its a bug. But to know for sure I will need to add some instrumentation. I suspect what is happening is a tremendous number of callouts all come due at the same time. The three back traces trying to stop or reset a callou

[Differential] [Updated, 2, 449 lines] D1438: FreeBSD callout rewrite and cleanup

hselasky updated this revision to Diff 3840. hselasky added a comment. Integrate manual page comments from Warren Block. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1438?vs=3809&id=3840 REVISION DETAIL https://reviews.freebsd.org/D1438 AFFECTED FILES share/man/man9/Makefile s

Re: Problems with Intel X520-SR2 [RESOLVED]

Hi All, Problem resolved with: FreeBSD rt01.xxx.xxx.xxx 10.1-STABLE FreeBSD 10.1-STABLE #3 r276979: Wed Jan 21 14:04:54 BRST 2015 r...@rt01.xxx.xxx.xxx:/usr/obj/usr/src/sys/GONDIM amd64 No more errors and stops. On 01/12/2014 19:29, Pieper, Jeffrey E wrote: Hi Marcelo, A couple of questi

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

hselasky added a comment. Let me re-phrase if I was unclear: I see nothing preventing the callout_reset() macro from reading (c)->c_cpu lock when it is equal to CPUBLOCK while another CPU is calling callout_cpu_switch() on the same callout. Especially in the case of a migration case done by th

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

rrs added a comment. Ok after much discussion with Hans, we *could* have an issue where the user sends in an invalid CPU. This is *not* what I think is happening with Hiren since the cc_cpu and lock is all sane (it would be a invalid index to cc_cpu which would not have an init'd lock). But I hav

[Differential] [Changed Subscribers] D1881: Allow Illumos code to co-exist with nv(9)

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send a

[Differential] [Accepted] D1648: Add stubs for deprecated VC messages

jfvogel accepted this revision. This revision is now accepted and ready to land. BRANCH review_D1648 REVISION DETAIL https://reviews.freebsd.org/D1648 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd

[Differential] [Closed] D1648: Add stubs for deprecated VC messages

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1648 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Accepted] D1868: Make libnv headers includable from C++

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1868 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1869: Tests of basic nvlist add functions

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Updated] D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets

glebius added a reviewer: ken. glebius added a comment. This is Ken's code, we probably want him to look at. Looks like a remnant from zero copy era. REVISION DETAIL https://reviews.freebsd.org/D1893 To: hselasky, pluknet, ae, np, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz,

[Differential] [Accepted] D1870: Add tests for nvlist_clone

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1870 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Changed Subscribers] D1881: Allow Illumos code to co-exist with nv(9)

will added a subscriber: will. will added a comment. What testing has been done with this change? REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: will, emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http:/

[Differential] [Accepted] D1871: Add tests for nvlist_pack/unpack

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1872: Add test cases for nvlist_move_*

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1872 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1873: Add tests for nvlist_take_*

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1873 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1874: Add tests for nvlist_free* functions

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1874 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1876: Add tests for dnvlist_take_*

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1876 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1875: Add tests for dnv_get_*

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1875 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1877: Implement asprintf in libkern

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1877 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1878: Add function to force an nvlist into the error state

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1878 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1879: Don't allocate memory for operations that do not insert

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1879 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1880: Prevent creation of an invalid nvlist

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1880 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1882: Add macros to make code compile in kernel

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1882 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1883: Move libnv into the kernel and hook it into the kernel build

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1883 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listi

[Differential] [Accepted] D1881: Allow Illumos code to co-exist with nv(9)

jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: will, emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org

[Differential] [Updated] D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets

ken added a comment. It looks okay to me. The surrounding code has changed a good bit since that was committed in 2002. By the way, I think Drew Gallatin originally wrote that chunk of code, but I can't remember for sure. REVISION DETAIL https://reviews.freebsd.org/D1893 To: hselasky, pluk

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

rstone added a comment. The primary testing that I did was to ensure that a kernel with "device zfs" would still link. However, I suppose that doesn't exclude the possibility of their being an zfs source file that is built wrong and doesn't include this header. Is there a zfs test suite that

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

will added a comment. >>! In D1881#9, @rstone wrote: > The primary testing that I did was to ensure that a kernel with "device zfs" > would still link. However, I suppose that doesn't exclude the possibility of > their being an zfs source file that is built wrong and doesn't include this > hea

[Differential] [Commented On] D1868: Make libnv headers includable from C++

pjd added a comment. Looks good to me, apart from the small nit above. INLINE COMMENTS lib/libnv/nv.h:66 Could you please add an empty line after this one for consistency? Thanks. REVISION DETAIL https://reviews.freebsd.org/D1868 To: rstone, jfvogel Cc: freebsd-net, pjd ___

[Differential] [Commented On] D1869: Tests of basic nvlist add functions

pjd added a comment. I like it. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Commented On] D1870: Add tests for nvlist_clone

pjd added inline comments. INLINE COMMENTS lib/libnv/tests/nv_tests.cc:324-331 Don't you want to test the clone here? If the values wre properly copied, if there is only one element, etc.? Now you are testing the source nvlist. REVISION DETAIL https://reviews.freebsd.org/D1870 To: rstone,

[Differential] [Commented On] D1871: Add tests for nvlist_pack/unpack

pjd added a comment. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any

[Differential] [Accepted] D1872: Add test cases for nvlist_move_*

pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D1872 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebs

[Differential] [Accepted] D1871: Add tests for nvlist_pack/unpack

pjd accepted this revision. pjd added a reviewer: pjd. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To un