Strange behavior of packet scheduling in ipfw3

2010-10-05 Thread Николай Дмуха
Hello! The system is: FreeBSD mysystem 8.0-STABLE-201005 FreeBSD 8.0-STABLE-201005 #0: Wed Jul 28 12:04:29 MSD 2010 r...@mysystem:/usr/src/sys/amd64/compile/MYKERNEL amd64 There is firewall "ipfw3" from Luigi Rizzo with packet scheduling. There is part of firewall config (tariff with 1Mbit/s

Re: mbuf changes

2010-10-05 Thread Karim Fodil-Lemelin
On 03/10/2010 9:13 AM, Luigi Rizzo wrote: On Sun, Oct 03, 2010 at 12:29:21AM +0100, Rui Paulo wrote: On 2 Oct 2010, at 21:35, Juli Mallett wrote: On Sat, Oct 2, 2010 at 12:07, Rui Paulo wrote: On 2 Oct 2010, at 16:29, Robert Watson wrote: On Thu, 30 Sep 2010, Julian Elischer wrote: On 9/3

ndis: fix ugly code

2010-10-05 Thread Paul B Mahol
Hi, If clang did not complain, I would probbaly never spot it. Patch attached. diff --git a/sys/compat/ndis/subr_ntoskrnl.c b/sys/compat/ndis/subr_ntoskrnl.c index ba1e49f..714fcd8 100644 --- a/sys/compat/ndis/subr_ntoskrnl.c +++ b/sys/compat/ndis/subr_ntoskrnl.c @@ -274,7 +274,6 @@ ntoskrnl_libi

Re: ndis: fix ugly code

2010-10-05 Thread Julian Elischer
On 10/5/10 1:19 PM, Paul B Mahol wrote: Hi, If clang did not complain, I would probbaly never spot it. Patch attached. personally I think you could use kproc_kthread_add so that a single NDIS process had three threads. ___ freebsd-net@freebsd.

Re: ndis: fix ugly code

2010-10-05 Thread Andrew Thompson
On 6 October 2010 09:19, Paul B Mahol wrote: > Hi, > > If clang did not complain, I would probbaly never spot it. > > Patch attached. Committed. ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscrib

Re: ndis: fix ugly code

2010-10-05 Thread Paul B Mahol
On 10/5/10, Julian Elischer wrote: > On 10/5/10 1:19 PM, Paul B Mahol wrote: >> Hi, >> >> If clang did not complain, I would probbaly never spot it. >> >> Patch attached. > > personally I think you could use kproc_kthread_add so that a single > NDIS process had three threads. Patch attached. No

Re: ndis: fix ugly code

2010-10-05 Thread Julian Elischer
On 10/5/10 5:27 PM, Paul B Mahol wrote: On 10/5/10, Julian Elischer wrote: On 10/5/10 1:19 PM, Paul B Mahol wrote: Hi, If clang did not complain, I would probbaly never spot it. Patch attached. personally I think you could use kproc_kthread_add so that a single NDIS process had three th

Re: ndis: fix ugly code

2010-10-05 Thread Paul B Mahol
On 10/6/10, Julian Elischer wrote: > On 10/5/10 5:27 PM, Paul B Mahol wrote: >> On 10/5/10, Julian Elischer wrote: >>>On 10/5/10 1:19 PM, Paul B Mahol wrote: Hi, If clang did not complain, I would probbaly never spot it. Patch attached. >>> personally I think you co