Re: Slipping in the window update

2005-01-10 Thread Don Lewis
On 9 Jan, Mike Silbersack wrote: > > Ok, here's an updated patch for the SYN case. I've included the patch > relative to 6.x, and some text from a tcpdump showing it in action. > > It responds to each SYN with an ACK like the latest tcpsecure document > states, but it uses a global counter to

Re: Slipping in the window update

2005-01-10 Thread Don Lewis
After a bit more thinking ... On 10 Jan, Don Lewis wrote: > and then after the dropafterack label add the code: > > + if (thflags & TH_SYN) { > + if (tp->t_state == TCPS_ESTABLISHED && > + tcp_insecure_syn == 0) { > + if (badport_bandlim(BANDLI

Re: Slipping in the window update

2005-01-10 Thread Mike Silbersack
On Mon, 10 Jan 2005, Don Lewis wrote: Now that I've looked at the above case, it looks to me like your suggested patch might affect the response to a legitimate duplicate SYN. It will definitely follow a different code path. You're right, I neglected to handle the duplicate SYN case. Couldn't we ce

Re: Slipping in the window update

2005-01-10 Thread Mike Silbersack
On Mon, 10 Jan 2005, Mike Silbersack wrote: We could do something there like if (th->th_seq != tp->irs) { goto dropafterack; /* Or however we handle these bad syns */ } else { thflags &= ~TH_SYN; th->th_seq++; if (th->th_urp > 1) th->th_urp--; else thflags &= ~TH_URG; todrop

Re: Slipping in the window update

2005-01-10 Thread Don Lewis
On 10 Jan, Mike Silbersack wrote: > > On Mon, 10 Jan 2005, Don Lewis wrote: > >> Now that I've looked at the above case, it looks to me like your >> suggested patch might affect the response to a legitimate duplicate SYN. >> It will definitely follow a different code path. > > You're right, I ne

Current problem reports assigned to you

2005-01-10 Thread FreeBSD bugmaster
Current FreeBSD problem reports Critical problems Serious problems S Submitted Tracker Resp. Description --- o [2002/07/26] kern/41007 net overfull traffic on third and fourth adap 1 problem total.

buildup of Windows time_wait talking to fbsd 4.10

2005-01-10 Thread Len Conrad
We have a windows mailserver that relays its outbound to a fbsd gateway. We changed to a different fbsd gateway running 4.10. Windows then began having trouble sending to 4.10. Windows "netstat -an" shows dozens of lines like this: source IP desitination IP

Re: buildup of Windows time_wait talking to fbsd 4.10

2005-01-10 Thread Danny
On Mon, 10 Jan 2005 10:53:39 -0600, Len Conrad <[EMAIL PROTECTED]> wrote: > > We have a windows mailserver that relays its outbound to a fbsd > gateway. We changed to a different fbsd gateway running 4.10. Windows then > began having trouble sending to 4.10. Windows "netstat -an" shows dozens >

Re: buildup of Windows time_wait talking to fbsd 4.10

2005-01-10 Thread laffer1
On Mon, 10 Jan 2005, Len Conrad wrote: We have a windows mailserver that relays its outbound to a fbsd gateway. We changed to a different fbsd gateway running 4.10. Windows then began having trouble sending to 4.10. Windows "netstat -an" shows dozens of lines like this: source IP

Re: buildup of Windows time_wait talking to fbsd 4.10

2005-01-10 Thread Len Conrad
Just off the top of my head... You mentioned the freebsd machine is the gateway. Do you have a firewall on the host blocking connections from the windows machine? a forgotten detail is that the windows machine sends just fine to the 4.10 gateway for a few minutes, but the time_wait inevitably b

Re: buildup of Windows time_wait talking to fbsd 4.10

2005-01-10 Thread Giorgos Keramidas
On 2005-01-10 11:26, Len Conrad <[EMAIL PROTECTED]> wrote: >> Just off the top of my head... >> >> You mentioned the freebsd machine is the gateway. Do you have a >> firewall on the host blocking connections from the windows machine? > > a forgotten detail is that the windows machine sends just fi

Bug in TCP window update?

2005-01-10 Thread Girish Rayas
In tcp_input.c, window is updated when below condition is true, if ((thflags & TH_ACK) && (SEQ_LT(tp->snd_wl1, th->th_seq) || (tp->snd_wl1 == th->th_seq && (SEQ_LT(tp->snd_wl2, th->th_ack) || (tp->snd_wl2 == th->th_ack && tiwin > tp->snd_wnd) This check is to prevent old segments from affecti

Re: buildup of Windows time_wait talking to fbsd 4.10

2005-01-10 Thread Lars Erik Gullerud
On Mon, 10 Jan 2005, Len Conrad wrote: We have a windows mailserver that relays its outbound to a fbsd gateway. We changed to a different fbsd gateway running 4.10. Windows then began having trouble sending to 4.10. Windows "netstat -an" shows dozens of lines like this: source IP